Add collector component #930
Conversation
✅ Deploy Preview for netdata-docusaurus ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I will structure the ActiveMQ doc according to the template and then we can merge this beautiful baby :) |
|
Update: I removed the changes made to the ActiveMQ doc, because I realized that it will be overwritten by the ingest script anyways. @ilyam8 and I will meet on Monday to discuss if we can use these components over in the netdata/go.d repo. |
|
Short summary from the meeting: |
| import React from 'react'; | ||
| import CodeBlock from '@theme/CodeBlock'; | ||
|
|
||
| export default function CollectorConfiguration({ configURL, moduleName }) { |
There was a problem hiding this comment.
Rename to : Enable collector
| import React from 'react'; | ||
| import CodeBlock from '@theme/CodeBlock'; | ||
|
|
||
| export default function CollectorConfiguration({ configURL, moduleName }) { |
There was a problem hiding this comment.
| export default function CollectorConfiguration({ configURL, moduleName }) { | |
| export default function EnableCollector({ configURL, moduleName }) { |
Delete old test file
Problem
We wanted to reuse a MDX file that had a variable.
For some reasons (@tkatsoulas feel free to add them here) we weren't able to make it fully work.
After countless hours of trying to implement MDX correctly (😭 mishmash of Markdown, Javascript, and HTML), I simply resorted to writing a JS component. ...Yes, we 'lose' the benefit of writing markdown in this particular instance, but taking 5 mins to assign tags to style the output is way better than wasting 4 hours of making MDX work (RIP brain).
Solution
I have written a simple JSX function that takes an argument, in this case the collector, and passes it to the respective variables to create dynamic content.
I strongly suggest that for components that need a variable, we just resort to JS the next time.
For components that don't need to be adapted we can simply use markdown.
Closes #896
🎤 drop.
Todo: