Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to update dependencies, remove unused code, and refactor validation logic in the
netbox_diode_plugin
project. The most important changes include updating the Docker image versions, refactoring thediode_target_validator
function, and removing the Reconciler SDK.Dependency Updates:
docker/Dockerfile-diode-netbox-plugin
tov4.1.11-3.0.2
.docker/docker-compose.yaml
tov4.1.11-3.0.2-diode-netbox-plugin
.Code Refactoring:
diode_target_validator
function innetbox_diode_plugin/models.py
to useurlparse
directly instead ofparse_target
.Code Removal:
netbox_diode_plugin/reconciler/__init__.py
,netbox_diode_plugin/reconciler/sdk/__init__.py
,netbox_diode_plugin/reconciler/sdk/client.py
,netbox_diode_plugin/reconciler/sdk/exceptions.py
, andnetbox_diode_plugin/reconciler/sdk/v1/__init__.py
[1] [2] [3] [4] [5].Simplification:
ingestion_logs
menu item fromnetbox_diode_plugin/navigation.py
[1] [2].