feat: remove ingestion logs view (#58)

* chore: remove reconciler sdk

Signed-off-by: Michal Fiedorowicz <[email protected]>

* fix: docker setup with netbox 4.1.11 for netbox-branching plugin

Signed-off-by: Michal Fiedorowicz <[email protected]>

* feat: remove ingestion logs view

Signed-off-by: Michal Fiedorowicz <[email protected]>

* chore: update CODEOWNERS

Signed-off-by: Michal Fiedorowicz <[email protected]>

---------

Signed-off-by: Michal Fiedorowicz <[email protected]>

Author: mfiedorowicz

.github/CODEOWNERS

@@ -1 +1 @@
-*                     @leoparente @mfiedorowicz
+* @leoparente @ltucker @mfiedorowicz

Makefile

@@ -19,5 +19,5 @@ docker-compose-netbox-plugin-test:
 
 .PHONY: docker-compose-netbox-plugin-test-cover
 docker-compose-netbox-plugin-test-cover:
-	-@$(DOCKER_COMPOSE) -f docker/docker-compose.yaml -f docker/docker-compose.test.yaml run --rm -u root -e COVERAGE_FILE=/opt/netbox/netbox/coverage/.coverage netbox sh -c "coverage run --source=netbox_diode_plugin --omit=*_pb2*,*/migrations/* ./manage.py test --keepdb netbox_diode_plugin && coverage xml -o /opt/netbox/netbox/coverage/report.xml && coverage report -m | tee /opt/netbox/netbox/coverage/report.txt"
+	-@$(DOCKER_COMPOSE) -f docker/docker-compose.yaml -f docker/docker-compose.test.yaml run --rm -u root -e COVERAGE_FILE=/opt/netbox/netbox/coverage/.coverage netbox sh -c "coverage run --source=netbox_diode_plugin --omit=*/migrations/* ./manage.py test --keepdb netbox_diode_plugin && coverage xml -o /opt/netbox/netbox/coverage/report.xml && coverage report -m | tee /opt/netbox/netbox/coverage/report.txt"
 	@$(MAKE) docker-compose-netbox-plugin-down

docker/Dockerfile-diode-netbox-plugin

@@ -1,4 +1,4 @@
-FROM netboxcommunity/netbox:v4.1-3.0.1
+FROM netboxcommunity/netbox:v4.1.11-3.0.2
 
 COPY ./netbox/configuration/ /etc/netbox/config/
 RUN chmod 755 /etc/netbox/config/* && \

docker/docker-compose.yaml

@@ -1,7 +1,7 @@
 name: diode-netbox-plugin
 services:
   netbox: &netbox
-    image: netboxcommunity/netbox:v4.1-3.0.1-diode-netbox-plugin
+    image: netboxcommunity/netbox:v4.1.11-3.0.2-diode-netbox-plugin
     build:
       context: .
       dockerfile: Dockerfile-diode-netbox-plugin

netbox_diode_plugin/models.py

@@ -1,19 +1,21 @@
 # !/usr/bin/env python
 # Copyright 2024 NetBox Labs Inc
 """Diode NetBox Plugin - Models."""
+from urllib.parse import urlparse
 
 from django.core.exceptions import ValidationError
 from django.db import models
 from django.urls import reverse
 from netbox.models import NetBoxModel
 
-from netbox_diode_plugin.reconciler.sdk.client import parse_target
-
 
 def diode_target_validator(target):
     """Diode target validator."""
     try:
-        _, _, _ = parse_target(target)
+        parsed_target = urlparse(target)
+
+        if parsed_target.scheme not in ["grpc", "grpcs"]:
+            raise ValueError("target should start with grpc:// or grpcs://")
     except ValueError as exc:
         raise ValidationError(exc)
 

netbox_diode_plugin/navigation.py

@@ -4,12 +4,6 @@
 
 from netbox.plugins import PluginMenu, PluginMenuItem
 
-ingestion_logs = {
-    "link": "plugins:netbox_diode_plugin:ingestion_logs",
-    "link_text": "Ingestion Logs",
-    "staff_only": True,
-}
-
 settings = {
     "link": "plugins:netbox_diode_plugin:settings",
     "link_text": "Settings",
@@ -23,7 +17,6 @@
         (
             "Diode",
             (
-                PluginMenuItem(**ingestion_logs),
                 PluginMenuItem(**settings),
             ),
         ),