ci/build-images: Standardize image sets #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, make there's the same set of images every time and they're in the same order. And if there's an image intentionally missing, comment why. Also, align spacing in the places where that's feasible, because it makes it easier to see the set of images.
mikhail-sakhnov
approved these changes
Mar 11, 2025
bayandin
added a commit
that referenced
this pull request
Mar 11, 2025
Push to ECR started to fail after #1312 changes: ``` Copy neondatabase/neonvm-controller:testrelease-20250311.1c7bb48.13791913752 to dev ECR ERROR: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed ``` It tries to push images to `<ECR>/neondatabase/<IMAGE_NAME>` instead of `<ECR>/<IMAGE_NAME>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, make there's the same set of images every time and they're in the same order. And if there's an image intentionally missing, comment why.
Also, align spacing in the places where that's feasible, because it makes it easier to see the set of images.
Noticed some painful merge conflicts trying to update #1247, figured this bit of cleanup would help (it does!).