ci/build-images: fix push to ECR #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayandin
force-pushed
the
bayandin/fix-ecr-push
branch
from
c9cd39d to
48cb70a
Compare
bayandin
commented
Mar 11, 2025
sharnoff
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Oh, whoops - thanks! Now that you mention it, I remember originally using the hard-coded names instead of env vars exactly because of this issue, in #1259 🤦
I like your solution better — maybe worth commenting what's going on with removing the neondatabase/ prefix from $image? The prefix removal syntax in bash is one of those small things I often forget what it means 😅
Sure will add a comment! Also, probably in #1283 I'm going to drop |
bayandin
force-pushed
the
bayandin/fix-ecr-push
branch
from
48cb70a to
f5809a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push to ECR started to fail after #1312 changes:
Spotted in link
It tries to push images to
<ECR>/neondatabase/<IMAGE_NAME>instead of<ECR>/<IMAGE_NAME>