CI: GHCR as the main registry #1283
Draft
+152
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedordikarev
reviewed
Mar 6, 2025
| @@ -347,11 +355,12 @@ jobs: | |||
|
|
|||
| - uses: docker/setup-buildx-action@v3 | |||
|
|
|||
| - name: Login to Dockerhub | |||
| - name: Login to GHCR | |||
There was a problem hiding this comment.
as we still need login to DockerHub, we can leave that step in place and add login to GHCR below or above, that will make PR diff more readable and easier to understand
fedordikarev
reviewed
Mar 6, 2025
.github/workflows/build-images.yaml
Outdated
| IMG_AUTOSCALER_AGENT: "neondatabase/autoscaler-agent" | ||
| IMG_DAEMON: "neondatabase/neonvm-daemon" | ||
| IMG_CLUSTER_AUTOSCALER: "neondatabase/cluster-autoscaler-neonvm" | ||
| IMG_CONTROLLER: "ghcr.io/neondatabase/neonvm-controller" |
There was a problem hiding this comment.
we can left that unchanged and add string "ghcr.io" inside the step we need it.
That will lead to:
- less changes and more readable PR
- no need for the
"${image#ghcr.io/}in theCopy images to DockerHub step
bayandin
force-pushed
the
bayandin/ghcr
branch
2 times, most recently
from
ef615bc to
57bbbeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.