ci: build images for arm and amd #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
8 times, most recently
from
18968f7 to
51ab48f
Compare
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
51ab48f to
9d868b9
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
2 times, most recently
from
4f2e65c to
8be9777
Compare
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
9d868b9 to
d69b2c9
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
8be9777 to
9cbd3a7
Compare
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
d69b2c9 to
fa8268e
Compare
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
7c084a0 to
176974c
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
4 times, most recently
from
1fd63dd to
4078a5f
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
3 times, most recently
from
879a893 to
0eb0665
Compare
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
176974c to
a44ccce
Compare
Signed-off-by: Misha Sakhnov <[email protected]>
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
a44ccce to
c375d43
Compare
sharnoff
reviewed
Feb 10, 2025
Add comments, simplify bash script.
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
04cd285 to
ec71aee
Compare
edude03
added a commit
that referenced
this pull request
Feb 10, 2025
Simplifies our setup at the expense of longer image build times. Without pushing cluster-autoscaler anywhere, it's hard to test changes from a PR. cc @mikhail-sakhnov re: #1138, @edude03 re: #1246 Co-authored-by: Michael Francis <[email protected]>
|
@sharnoff do we have anything left unreviewed here? |
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
2 times, most recently
from
c61314c to
1293c51
Compare
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
1293c51 to
5f14280
Compare
bayandin
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
I just noticed that GitHub doesn't allow merging the PR because it is missing the job e2e-tests (k3d).
It happened because now we have e2e-tests (k3d, amd64) and e2e-tests (k3d, arm64) jobs 🤷
I propose the following:
- In another PR create
conclusionjob that depends one2e-tests(like this) - Merge that PR
- Change branch protection rules (I can do that for you)
- Add
conclusionjob to this PR (or just pull the fresh main into it)
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
bf59766 to
8717280
Compare
mikhail-sakhnov
force-pushed
the
misha/build-arm-images-in-ci
branch
from
8717280 to
852494b
Compare
sharnoff
added a commit
that referenced
this pull request
Feb 12, 2025
A few changes here as a follow-up to #1138: * Don't push arch-specific images to ECR; we don't have repos for them. * Give the merge-images step an ID token to have ECR access * Don't use IMG_* vars when pushing to ECR, because the ECR repos aren't prefixed with 'neondatabase/' * Push cluster-autoscaler to ECR * Don't push neonvm-daemon to ECR
sharnoff
added a commit
that referenced
this pull request
Feb 12, 2025
A few changes here as a follow-up to #1138: * Don't push arch-specific images to ECR; we don't have repos for them. * Give the merge-images step an ID token to have ECR access * Don't use IMG_* vars when pushing to ECR, because the ECR repos aren't prefixed with 'neondatabase/' * Push cluster-autoscaler to ECR * Don't push neonvm-daemon to ECR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce matrix strategy builds to build images for arm and amd64.
After matrix execution merge artefacts using docker manifest tool
#1089