feat: Improved usability of NEAR CLI in scripts

.github/workflows/code_style.yml

@@ -5,7 +5,7 @@ on:
 jobs:
   codestyle:
     name: Code Style (fmt + clippy)
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2

src/commands/account/create_account/create_implicit_account/use_auto_generation.rs

@@ -42,7 +42,12 @@ impl SaveWithUseAutoGenerationContext {
                         .wrap_err_with(|| format!("Failed to create file: {:?}", file_path))?
                         .write(buf.as_bytes())
                         .wrap_err_with(|| format!("Failed to write to file: {:?}", folder_path))?;
-                    eprintln!("\nThe file {:?} was saved successfully", &file_path);
+
+                    tracing::info!(
+                        parent: &tracing::Span::none(),
+                        "The file {:?} was saved successfully",
+                        &file_path
+                    );
 
                     Ok(())
                 }

src/commands/account/create_account/create_implicit_account/use_ledger.rs

@@ -66,7 +66,12 @@ impl SaveWithLedgerContext {
                         .wrap_err_with(|| format!("Failed to create file: {:?}", file_path))?
                         .write(buf.as_bytes())
                         .wrap_err_with(|| format!("Failed to write to file: {:?}", file_path))?;
-                    eprintln!("\nThe file {:?} was saved successfully", &file_path);
+
+                    tracing::info!(
+                        parent: &tracing::Span::none(),
+                        "The file {:?} was saved successfully",
+                        &file_path
+                    );
 
                     Ok(())
                 }

src/commands/account/create_account/create_implicit_account/use_seed_phrase.rs

@@ -51,7 +51,12 @@ impl SaveWithSeedPhraseContext {
                         .wrap_err_with(|| format!("Failed to create file: {:?}", file_path))?
                         .write(buf.as_bytes())
                         .wrap_err_with(|| format!("Failed to write to file: {:?}", file_path))?;
-                    eprintln!("\nThe file {:?} was saved successfully", &file_path);
+
+                    tracing::info!(
+                        parent: &tracing::Span::none(),
+                        "The file {:?} was saved successfully",
+                        &file_path
+                    );
 
                     Ok(())
                 }

src/commands/account/create_account/fund_myself_create_account/sign_as/mod.rs

@@ -205,12 +205,15 @@ fn validate_new_account_id(
                     ..
                 },
             ),
-        )) => {
-            eprintln!("\nServer error.\nIt is currently possible to continue creating an account offline.\nYou can sign and send the created transaction later.");
-            Ok(())
-        }
+        )) => Ok(()),
         Err(near_jsonrpc_client::errors::JsonRpcError::TransportError(_)) => {
-            eprintln!("\nTransport error.\nIt is currently possible to continue creating an account offline.\nYou can sign and send the created transaction later.");
+            tracing::warn!(
+                parent: &tracing::Span::none(),
+                "Transport error.{}",
+                crate::common::indent_payload(
+                    "\nIt is currently possible to continue creating an account offline.\nYou can sign and send the created transaction later.\n"
+                )
+            );
             Ok(())
         }
         Err(err) => {

src/commands/account/create_account/sponsor_by_faucet_service/mod.rs

@@ -123,7 +123,6 @@ fn print_account_creation_status(
     credentials_home_dir: &std::path::Path,
     storage_message: String,
 ) -> crate::CliResult {
-    eprintln!();
     match result {
         Ok(response) => {
             tracing::info!(
@@ -133,7 +132,13 @@ fn print_account_creation_status(
                 crate::common::indent_payload(&format!("{:#?}", response))
             );
             if response.status() >= reqwest::StatusCode::BAD_REQUEST {
-                eprintln!("WARNING! The new account <{new_account_id}> could not be created successfully.\n{storage_message}\n");
+                tracing::warn!(
+                    parent: &tracing::Span::none(),
+                    "WARNING!{}",
+                    crate::common::indent_payload(&format!(
+                        "\nThe new account <{new_account_id}> could not be created successfully.\n{storage_message}\n"
+                    ))
+                );
                 return Err(color_eyre::Report::msg(format!(
                     "The faucet (helper service) server failed with status code <{}>",
                     response.status()
@@ -152,23 +157,46 @@ fn print_account_creation_status(
             match account_creation_transaction.status {
                 near_primitives::views::FinalExecutionStatus::SuccessValue(ref value) => {
                     if value == b"false" {
-                        eprintln!("WARNING! The new account <{new_account_id}> could not be created successfully.\n{storage_message}\n");
+                        tracing::warn!(
+                            parent: &tracing::Span::none(),
+                            "WARNING!{}",
+                            crate::common::indent_payload(&format!(
+                                "\nThe new account <{new_account_id}> could not be created successfully.\n{storage_message}\n"
+                            ))
+                        );
                     } else {
                         crate::common::update_used_account_list_as_signer(
                             credentials_home_dir,
                             new_account_id.as_ref(),
                         );
-                        eprintln!("New account <{new_account_id}> created successfully.\n{storage_message}\n");
+                        tracing::info!(
+                            parent: &tracing::Span::none(),
+                            "{}",
+                            crate::common::indent_payload(&format!(
+                                "\nNew account <{new_account_id}> created successfully.\n{storage_message}\n"
+                            ))
+                        );
                     }
-                    eprintln!("Transaction ID: {id}\nTo see the transaction in the transaction explorer, please open this url in your browser:\n{path}{id}\n",
-                        id=account_creation_transaction.transaction_outcome.id,
-                        path=network_config.explorer_transaction_url
+                    tracing::info!(
+                        parent: &tracing::Span::none(),
+                        "\n{}",
+                        crate::common::indent_payload(&format!(
+                            "Transaction ID: {id}\nTo see the transaction in the transaction explorer, please open this url in your browser:\n{path}{id}\n",
+                            id=account_creation_transaction.transaction_outcome.id,
+                            path=network_config.explorer_transaction_url
+                        ))
                     );
                 }
                 near_primitives::views::FinalExecutionStatus::NotStarted
                 | near_primitives::views::FinalExecutionStatus::Started => unreachable!(),
                 near_primitives::views::FinalExecutionStatus::Failure(tx_execution_error) => {
-                    eprintln!("WARNING! The new account <{new_account_id}> could not be created successfully.\n{storage_message}\n");
+                    tracing::warn!(
+                        parent: &tracing::Span::none(),
+                        "WARNING!{}",
+                        crate::common::indent_payload(&format!(
+                            "\nThe new account <{new_account_id}> could not be created successfully.\n{storage_message}\n"
+                        ))
+                    );
                     match tx_execution_error {
                         near_primitives::errors::TxExecutionError::ActionError(action_error) => {
                             return crate::common::convert_action_error_to_cli_result(
@@ -194,7 +222,13 @@ fn print_account_creation_status(
                 "JSON RPC Response:\n{}",
                 crate::common::indent_payload(&err.to_string())
             );
-            eprintln!("WARNING! The new account <{new_account_id}> could not be created successfully.\n{storage_message}\n");
+            tracing::warn!(
+                parent: &tracing::Span::none(),
+                "WARNING!{}",
+                crate::common::indent_payload(&format!(
+                    "\nThe new account <{new_account_id}> could not be created successfully.\n{storage_message}\n"
+                ))
+            );
             Err(color_eyre::Report::msg(err.to_string()))
         }
     }

src/commands/account/create_account/sponsor_by_faucet_service/network/mod.rs

@@ -32,20 +32,28 @@ impl NetworkContext {
             .wrap_err("Failed to get network config!")?
             .clone();
 
-        eprintln!("\nYour transaction:");
-        eprintln!("{:<13} {}", "signer_id:", &network_config.network_name);
-        eprintln!("actions:");
-        eprintln!(
-            "{:>5} {:<20} {}",
+        let mut info_str: String = String::new();
+        info_str.push_str(&format!(
+            "\n{:<13} {}",
+            "signer_id:", &network_config.network_name
+        ));
+        info_str.push_str("\nactions:");
+        info_str.push_str(&format!(
+            "\n{:>5} {:<20} {}",
             "--", "create account:", &previous_context.new_account_id
-        );
-        eprintln!("{:>5} {:<20}", "--", "add access key:");
-        eprintln!(
-            "{:>18} {:<13} {}",
+        ));
+        info_str.push_str(&format!("\n{:>5} {:<20}", "--", "add access key:"));
+        info_str.push_str(&format!(
+            "\n{:>18} {:<13} {}",
             "", "public key:", &previous_context.public_key
+        ));
+        info_str.push_str(&format!("\n{:>18} {:<13} FullAccess", "", "permission:"));
+        info_str.push('\n');
+
+        tracing::info!(
+            "Your transaction:{}",
+            crate::common::indent_payload(&info_str)
         );
-        eprintln!("{:>18} {:<13} FullAccess", "", "permission:");
-        eprintln!();
 
         Ok(Self {
             new_account_id: previous_context.new_account_id,

src/commands/account/import_account/mod.rs

@@ -49,15 +49,18 @@ pub fn login(
 
     let account_id = loop {
         let account_id_from_cli = input_account_id()?;
-        eprintln!();
         if crate::common::verify_account_access_key(
             account_id_from_cli.clone(),
             public_key.clone(),
             network_config.clone(),
         )
         .is_err()
         {
-            eprintln!("{}", error_message);
+            tracing::warn!(
+                parent: &tracing::Span::none(),
+                "WARNING!{}",
+                crate::common::indent_payload(error_message)
+            );
 
             #[derive(strum_macros::Display)]
             enum ConfirmOptions {
@@ -126,7 +129,11 @@ fn save_access_key(
                 public_key_str,
                 account_id.as_ref(),
             )?;
-        eprintln!("{}", storage_message);
+        tracing::info!(
+            parent: &tracing::Span::none(),
+            "\n{}",
+            crate::common::indent_payload(&storage_message)
+        );
         return Ok(());
     }
 
@@ -138,6 +145,10 @@ fn save_access_key(
         account_id.as_ref(),
     )
     .wrap_err_with(|| format!("Failed to save a file with access key: {}", public_key_str))?;
-    eprintln!("{}", storage_message);
+    tracing::info!(
+        parent: &tracing::Span::none(),
+        "\n{}",
+        crate::common::indent_payload(&storage_message)
+    );
     Ok(())
 }

src/commands/account/storage_management/storage_deposit.rs

@@ -139,9 +139,13 @@ impl SignerAccountIdContext {
                 let contract_account_id = (previous_context.get_contract_account_id)(network_config)?;
 
                 if let near_primitives::views::FinalExecutionStatus::SuccessValue(_) = outcome_view.status {
-                    eprintln!(
-                        "<{signer_account_id}> has successfully added a deposit of {deposit} to <{receiver_account_id}> on contract <{contract_account_id}>.",
-                        deposit = previous_context.deposit,
+                    tracing::info!(
+                        parent: &tracing::Span::none(),
+                        "\n{}",
+                        crate::common::indent_payload(&format!(
+                            "<{signer_account_id}> has successfully added a deposit of {deposit} to <{receiver_account_id}> on contract <{contract_account_id}>.",
+                            deposit = previous_context.deposit,
+                        ))
                     );
                 }
                 Ok(())

src/commands/account/storage_management/storage_withdraw.rs

@@ -80,9 +80,13 @@ impl SignerAccountIdContext {
             move |outcome_view, network_config| {
                 let contract_account_id = (previous_context.get_contract_account_id)(network_config)?;
                 if let near_primitives::views::FinalExecutionStatus::SuccessValue(_) = outcome_view.status {
-                    eprintln!(
-                        "<{signer_account_id}> has successfully withdraw {amount} from <{contract_account_id}>.",
-                        amount = previous_context.amount,
+                    tracing::info!(
+                        parent: &tracing::Span::none(),
+                        "\n{}",
+                        crate::common::indent_payload(&format!(
+                            "<{signer_account_id}> has successfully withdraw {amount} from <{contract_account_id}>.",
+                            amount = previous_context.amount,
+                        ))
                     );
                 }
                 Ok(())

src/commands/account/update_social_profile/sign_as.rs

@@ -86,7 +86,11 @@ impl From<SignerContext> for crate::commands::ActionContext {
         let on_after_sending_transaction_callback: crate::transaction_signature_options::OnAfterSendingTransactionCallback = Arc::new({
             move |transaction_info, _network_config| {
                 if let near_primitives::views::FinalExecutionStatus::SuccessValue(_) = transaction_info.status {
-                    eprintln!("\nProfile for {account_id} updated successfully");
+                    tracing::info!(
+                        parent: &tracing::Span::none(),
+                        "Profile for {} updated successfully",
+                        account_id
+                    );
                 } else {
                     color_eyre::eyre::bail!("Failed to update profile!");
                 };

src/commands/contract/call_function/as_read_only/mod.rs

@@ -77,7 +77,15 @@ impl FunctionContext {
             let function_name = scope.function_name.clone();
 
             move |network_config, block_reference| {
-                call_view_function(network_config, &account_id, &function_name, function_args.clone(), function_args_type.clone(), block_reference)
+                call_view_function(
+                    network_config,
+                    &account_id,
+                    &function_name,
+                    function_args.clone(),
+                    function_args_type.clone(),
+                    block_reference,
+                    &previous_context.global_context.verbosity,
+                )
             }
         });
 
@@ -117,6 +125,7 @@ fn call_view_function(
     function_args: String,
     function_args_type: super::call_function_args_type::FunctionArgsType,
     block_reference: &near_primitives::types::BlockReference,
+    verbosity: &crate::Verbosity,
 ) -> crate::CliResult {
     let args = super::call_function_args_type::function_args(function_args, function_args_type)?;
     let call_result = network_config
@@ -129,16 +138,29 @@ fn call_view_function(
             )
         })?;
     call_result.print_logs();
-    eprintln!("Result:");
+    let mut info_str = String::new();
     if call_result.result.is_empty() {
-        eprintln!("Empty result");
+        info_str.push_str("\nEmpty result");
     } else if let Ok(json_result) = call_result.parse_result_from_json::<serde_json::Value>() {
-        println!("{}", serde_json::to_string_pretty(&json_result)?);
+        info_str.push_str(&format!(
+            "\n{}",
+            serde_json::to_string_pretty(&json_result)?
+        ));
     } else if let Ok(string_result) = String::from_utf8(call_result.result) {
-        println!("{string_result}");
+        info_str.push_str(&format!("\n{string_result}"));
     } else {
-        eprintln!("The returned value is not printable (binary data)");
+        info_str.push_str("\nThe returned value is not printable (binary data)");
     }
-    eprintln!("--------------");
+
+    if let crate::Verbosity::Quiet = verbosity {
+        println!("{}", info_str);
+        return Ok(());
+    };
+    info_str.push_str("\n------------------------------------");
+    tracing::info!(
+        parent: &tracing::Span::none(),
+        "--- Result -------------------------{}",
+        crate::common::indent_payload(&info_str)
+    );
     Ok(())
 }

src/commands/contract/download_abi/mod.rs

@@ -120,6 +120,10 @@ fn download_contract_abi(
         .wrap_err_with(|| format!("Failed to create file: {:?}", file_path))?
         .write(&serde_json::to_vec_pretty(&abi_root)?)
         .wrap_err_with(|| format!("Failed to write to file: {:?}", file_path))?;
-    eprintln!("\nThe file {:?} was downloaded successfully", file_path);
+    tracing::info!(
+        parent: &tracing::Span::none(),
+        "The file {:?} was downloaded successfully",
+        file_path
+    );
     Ok(())
 }

src/commands/contract/download_wasm/mod.rs

@@ -136,7 +136,10 @@ fn download_contract_code(
         .wrap_err_with(|| format!("Failed to create file: {:?}", file_path))?
         .write(&call_access_view.code)
         .wrap_err_with(|| format!("Failed to write to file: {:?}", file_path))?;
-    eprintln!("\nThe file {:?} was downloaded successfully", file_path);
-
+    tracing::info!(
+        parent: &tracing::Span::none(),
+        "The file {:?} was downloaded successfully",
+        file_path
+    );
     Ok(())
 }