feat: Improved usability of NEAR CLI in scripts #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artob
reviewed
Feb 4, 2025
| .with(env_filter) | ||
| .init(); | ||
| } | ||
| Verbosity::Quiet => {} |
There was a problem hiding this comment.
Nice, that's a good use of the tracing crate 👍
FroVolod
force-pushed
the
update-for-quiet-option
branch
from
145b7a9 to
65180f7
Compare
added 7 commits
March 3, 2025 16:29
FroVolod
requested review from
akorchyn,
dj8yfo and
PolyProgrammist
as code owners
added 2 commits
March 5, 2025 12:32
akorchyn
previously approved these changes
Mar 6, 2025
src/commands/account/create_account/fund_myself_create_account/sign_as/mod.rs
Show resolved
Hide resolved
| @@ -138,6 +145,10 @@ fn save_access_key( | |||
| account_id.as_ref(), | |||
| ) | |||
| .wrap_err_with(|| format!("Failed to save a file with access key: {}", public_key_str))?; | |||
| eprintln!("{}", storage_message); | |||
| tracing::info!( | |||
| parent: &tracing::Span::none(), | |||
There was a problem hiding this comment.
why do we need to repeat that parent: none()?
| if let crate::Verbosity::Quiet = verbosity { | ||
| println!("{}", info_str); | ||
| }; | ||
| info_str.push_str("\n------------------------------------"); |
| println!("Contract state (values):\n{}\n", serde_json::to_string_pretty(&result.values)?); | ||
| println!("Contract state (proof):\n{:#?}\n", result.proof) | ||
| } | ||
| tracing::info!( |
There was a problem hiding this comment.
else?
To be honest, I believe that tracing could be configured with using target to display output and to remove noise
this will help to reduce that repeateness. I would ask you to take a look a bit into that direction.
I don't mind if it will come in the next PR.
frol
requested changes
Mar 6, 2025
frol
reviewed
Mar 11, 2025
src/common.rs
Outdated
Comment on lines
1340
to
1343
| if let crate::Verbosity::Quiet = verbosity { | ||
| std::io::stdout().write_all(bytes_result)?; | ||
| return Ok(()); | ||
| }; |
There was a problem hiding this comment.
Move this block before let result_output, so the program does not perform useless work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #437
Running NEAR CLI in the --quiet case:
Running NEAR CLI in the "interactive" case:
