-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix needless operation #1687
Fix needless operation #1687
Conversation
I would prefer to limit this PR to operation -> function replacements only. Maybe with additional change to the output strings. I'd prefer other questions not in code comments, but rather in a GitHub issue. @swernli, what do you think? |
Yes, I agree. The questions in the comments can be removed and the PR focused on cleaning up the existing samples. We've had some debates about reducing some redundant samples, but this PR doesn't seem like the right time to take that on. @Manvi-Agrawal you are definitely asking the right questions though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave only operation -> function changes and output string improvements. Open issues for questions instead of adding comments (or add to existing ones).
Hi @DmitryVasilevsky and @swernli, created 2 separate issues for my questions : #1708 and #1709 . Could you please take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting the general samples clean up into separate issues. The focused changes here look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing this lints!
fixes #1585.