[Question] Samples CI, location and redundancy #1709
Labels
Comments
Merged
|
This should be resolved when #1797 goes in |
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 26, 2024
… to use structs (#1797) This PR: - Updates katas to use structs instead of newtypes - Performs some minor katas formatting updates (consistency on spacing; removing trailing whitespace; etc) - Checks our samples for lint warnings or errors in the CI - updates our samples to use the latest style from Q# 1.7 - imports instead of opens - implicit entrypoint via `Main` - implicit namespaces - Adds stricter lint configs to projects within this repo Closes #1709 Thanks @ScottCarda-MS and @swernli for collaborating on this PR! --------- Co-authored-by: Scott Carda <[email protected]> Co-authored-by: Scott Carda <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> Co-authored-by: Mariia Mykhailova <[email protected]>
Manvi-Agrawal
changed the title
Manvi-Agrawal
changed the title
This was referenced Sep 25, 2024
|
Created separate issues for better triaging since #1797 addresssed a part of this issue and I am unable to reopen this issue |
Manvi-Agrawal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Edited because of sample validation changes: Investigate duplicate check in javascript that check samples in
samples.mjslist?Generic questions : Samples Location
It might be worth publishing language samples to the same/separate website, if possible, for greater discovery.
If option 2 isnt feasible, can we move samples not in samples.mjs list to a new repo? I liked classic QDK samples because they were in a separate repo. @tcNickolas has told me previously that monolith helps to simplify the dependencies. I highly doubt that somebody would likely visit this massive codebase to see these curated samples. Currently, they serve little purpose for both for Q# compiler team and people onboarding to Q#. Maybe add new samples repo as a submodule here if folks think it might be useful, although I know git submodules are a bit annoying.
Specific questions
: Is
QuantumHelloWorld.qssample needed when we have Getting started(aka minimal) and superposition sample?Also, this is not in
samples.mjslist. Interestingly, it does pop up on samples website which seems to have been updates a long time back.Is
RandomBit.qssample needed when code is very similar to superposition sample? Currently, this is in samples list and might be okay to have this duplicate to reiterate that random number can be generated using superposition.The text was updated successfully, but these errors were encountered: