[Unitary-Hack] Lint rule: Use functions

[Manvi-Agrawal]

Fixes #1471.

Future TODO

• [FollowUp] NeedlessOperation lint cleanup in samples not in list #1585
• [FollowUp] Quick fix for NeedlessOperation lint #1593

Based on https://github.com/microsoft/qsharp/blob/main/compiler/qsc_passes/src/callable_limits.rs

Note to reviewers

Main changes are in qsc_linter folder. Changes in other tests are due to this lint rule complaining about NeedlessOperation, so I converted to function and it changes span accordingly.

[minestarks]

Thanks @Manvi-Agrawal ! Would you mind resolving the conflicts in the branch so I can kick off the checks for this PR? I'll give your questions some more thought once I get the feedback from the unit tests in the CI.

[Manvi-Agrawal]

Thanks @Manvi-Agrawal ! Would you mind resolving the conflicts in the branch so I can kick off the checks for this PR? I'll give your questions some more thought once I get the feedback from the unit tests in the CI.

Done @minestarks. I was on it, and when I came back I saw your comment :-). Also, could we please connect over discord, I have few questions about other open issues xD

[orpuente-MS]

A few suggestions to convert some more comments to docstrings.

[Manvi-Agrawal]

Could you please run your local playground with the browser Developer Tools enabled, and watch the JavaScript console logs? It's reporting some panics from the Rust layer when you trigger the lint. Please ensure no panics / error messages show up in regular testing in the playground.

Nice catch @minestarks. I realized now that these were originating from unimplemented quick-fix. I had it as TODO, and converting it to no-op(similar to DivisionByZero) made rust happy :-)

[Manvi-Agrawal]

Hi @minestarks , @orpuente-MS , I have addressed all review comments. Could you please take a look?

[orpuente-MS]

@Manvi-Agrawal looks good! I will approve.

[Manvi-Agrawal]

@Manvi-Agrawal looks good! I will approve.

Thanks a ton @orpuente-MS for your review and approval.

[Manvi-Agrawal]

Hi @minestarks , do you have any other feedback for this PR. Rust panic was really good edge case. Your todays feedback would give me more bandwidth since I can work over that over the weekend, because hack ends on June 12

[minestarks]

Great work, thanks. Minor cosmetic improvements and then we should be good to go.

[minestarks]

Just needs one more signoff from @DmitryVasilevsky, @cesarzc, @sezna, @swernli, @tcNickolas (probably due to the small sample update) .