This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Data Skipping Index Part 3-1: Utils #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clee704
commented
Aug 22, 2021
Comment on lines
+28
to
+37
| "org.scalacheck" %% "scalacheck" % "1.14.2" % "test", | ||
| "org.apache.spark" %% "spark-catalyst" % sv % "test" classifier "tests", | ||
| "org.apache.spark" %% "spark-core" % sv % "test" classifier "tests", | ||
| "org.apache.spark" %% "spark-sql" % sv % "test" classifier "tests") ++ | ||
| (if (sparkVersion < Version(3, 1, 0)) | ||
| Seq("org.scalatest" %% "scalatest" % "3.0.5" % "test") | ||
| Seq("org.scalatest" %% "scalatest" % "3.0.8" % "test") | ||
| else | ||
| Seq("org.scalatest" %% "scalatest" % "3.2.7" % "test")) ++ | ||
| Seq( | ||
| "org.scalatest" %% "scalatest" % "3.2.3" % "test", | ||
| "org.scalatestplus" %% "scalatestplus-scalacheck" % "3.1.0.0-RC2" % "test")) ++ |
There was a problem hiding this comment.
Changes were necessary to use ExpressionEvalHelper for unit test.
Utility classes and methods for the rule application.
This was referenced Aug 22, 2021
sezruby
reviewed
Aug 23, 2021
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/ExpressionUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/ExpressionUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/SortedArrayLowerBound.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/SortedArrayUtils.scala
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/SortedArrayUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/extractors.scala
Show resolved
Hide resolved
added 2 commits
August 24, 2021 02:34
Needed before, not anymore
sezruby
reviewed
Aug 23, 2021
| import org.apache.spark.sql.{DataFrame, SparkSession} | ||
| import org.apache.spark.sql.catalyst.InternalRow | ||
| import org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute | ||
| import org.apache.spark.sql.catalyst.expressions._ | ||
| import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, ExprCode} | ||
| import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, Project, Window} | ||
| import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, Filter, LogicalPlan, Project, Window} |
sezruby
approved these changes
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
What changes were proposed in this pull request?
Implement utility classes and methods for the data skipping index application rule.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test