This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0664707
to
d39d05e
Compare
clee704
commented
Jul 29, 2021
b3f1f73
to
9318ab8
Compare
7f7f5df
to
6ca6cc7
Compare
sezruby
reviewed
Aug 4, 2021
src/main/scala/com/microsoft/hyperspace/index/dataskipping/DataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/rule/FilterConditionFilter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/rule/ApplyDataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
Could you split the PR? e.g. part 3-1: utils, part 3-2: apply? |
sezruby
reviewed
Aug 14, 2021
src/main/scala/com/microsoft/hyperspace/index/IndexLogEntryTags.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/DataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/DataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/rule/FilterRankFilter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/rule/FilterRankFilter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/ExpressionUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/SortedArrayLowerBound.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/SortedArrayLowerBound.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rules/ScoreBasedIndexPlanOptimizer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/plananalysis/PlanAnalyzer.scala
Show resolved
Hide resolved
sezruby
reviewed
Aug 15, 2021
src/main/scala/com/microsoft/hyperspace/index/dataskipping/rule/ApplyDataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
2c961b4
to
9e1dce4
Compare
sezruby
reviewed
Aug 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clee704 Could you update plan change examples (executedPlan) to PR description?
src/main/scala-spark2/com/microsoft/hyperspace/shim/First.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/DataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/DataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/DataSkippingIndexConfig.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/rule/ApplyDataSkippingIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/rule/DataSkippingIndexRanker.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/DataSkippingFileIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/DataSkippingFileIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/dataskipping/util/DataSkippingFileIndex.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/sources/interfaces.scala
Outdated
Show resolved
Hide resolved
sezruby
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Thanks for the detailed review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
What changes were proposed in this pull request?
Implement the data skipping index application rule.
Does this PR introduce any user-facing change?
Yes, users can create data skipping indexes that can be applied to filter queries.
How was this patch tested?
Unit test