Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v9 packages): Migrate to SWC transpilation approach #27250

Merged

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Mar 17, 2023

Changes:

Runs migrate-converged-package nx generator which makes changes below:

  1. Adds an .swcrc file to all v9 packages.
  2. Updates just.config.ts file to have all v9 packages opt in to new build:react-components task which will run swc transpilation.
  3. Updates .babelrc.json file to extend monorepo root .babelrc-v9.json file.
  4. Minor script and dependency updates to package.json which add @swc/helpers.

Related Issue(s)

TristanWatanabe and others added 30 commits January 26, 2023 18:38
…ed by v9 packages to transpile based on browser matrix
…' into use-swc-transpilation-tooling-updates
@khmakoto khmakoto enabled auto-merge (squash) March 20, 2023 19:34
Copy link
Contributor

@Mitch-At-Work Mitch-At-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @xc-uxe and confirming react-virtualizer change is correctly marked as pre-release.

@TristanWatanabe TristanWatanabe merged commit 2fac1a1 into microsoft:master Mar 21, 2023
@TristanWatanabe TristanWatanabe deleted the migrate-to-swc-es2019 branch March 21, 2023 18:10
@@ -1,4 +1,3 @@
{
"presets": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we missed few packages. packages without mapping trigger babelpostprocess errors

image

We need to use that aliasing mapping for every package that uses swc + babelpostprocess to point babel always to ESM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants