chore: update babel:postprocess #27335

layershifter · 2023-03-27T14:16:00Z

Previous Behavior

Order of tasks:

ts:esm
ts:cjs
babel:postprocess (both ESM & CJS)

New Behavior

swc:esm
babel:postprocess (only ESM)
swc:cjs

Removes lib-commonjs from the glob as now the order of tasks is different.

Related issues

Follows chore(v9 packages): Migrate to SWC transpilation approach #27250

Removes `lib-commonjs` from the glob as now the order of tasks is different.

codesandbox-ci · 2023-03-27T14:29:12Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eaca378:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2023-03-27T14:31:26Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4fad4cbbcbdb48847857c388135a3abda472add7 (build)

fabricteam · 2023-03-27T14:34:14Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-03-27T14:37:02Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1054	1107	5000
Button	mount	681	654	5000
Field	mount	1984	1950	5000
FluentProvider	mount	1394	1393	5000
FluentProviderWithTheme	mount	370	368	10
FluentProviderWithTheme	virtual-rerender	341	332	10
FluentProviderWithTheme	virtual-rerender-with-unmount	365	360	10
InfoButton	mount	238	241	5000
MakeStyles	mount	1554	1542	50000
Persona	mount	2682	2591	5000
SpinButton	mount	2361	2350	5000

fabricteam · 2023-03-27T14:37:41Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`560 B` `352 B`
`priority-overflow` createOverflowManager	`3.194 kB` `1.314 kB`
`react-accordion` Accordion (including children components)	`88.882 kB` `26.551 kB`
`react-alert` Alert	`96.647 kB` `23.133 kB`
`react-avatar` Avatar	`60.312 kB` `15.579 kB`
`react-avatar` AvatarGroup	`18.178 kB` `6.683 kB`
`react-avatar` AvatarGroupItem	`76.573 kB` `20.086 kB`
`react-badge` Badge	`25.85 kB` `7.585 kB`
`react-badge` CounterBadge	`26.833 kB` `7.889 kB`
`react-badge` PresenceBadge	`34.458 kB` `8.693 kB`
`react-button` Button	`39.749 kB` `9.959 kB`
`react-button` CompoundButton	`46.921 kB` `11.428 kB`
`react-button` MenuButton	`44.437 kB` `11.306 kB`
`react-button` SplitButton	`52.931 kB` `12.872 kB`
`react-button` ToggleButton	`58.121 kB` `11.878 kB`
`react-card` Card - All	`83.489 kB` `23.894 kB`
`react-card` Card	`78.308 kB` `22.431 kB`
`react-card` CardFooter	`9.035 kB` `3.799 kB`
`react-card` CardHeader	`10.959 kB` `4.503 kB`
`react-card` CardPreview	`9.84 kB` `4.153 kB`
`react-checkbox` Checkbox	`36.067 kB` `10.856 kB`
`react-checkbox` CheckboxField	`43.019 kB` `12.787 kB`
`react-combobox` Combobox (including child components)	`88.73 kB` `28.105 kB`
`react-combobox` ComboboxField	`85.147 kB` `27.871 kB`
`react-combobox` Dropdown (including child components)	`87.428 kB` `27.853 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`67.994 kB` `18.395 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`207.4 kB` `57.516 kB`
`react-components` react-components: FluentProvider & webLightTheme	`38.819 kB` `12.351 kB`
`react-dialog` Dialog (including children components)	`93.616 kB` `27.452 kB`
`react-divider` Divider	`19.863 kB` `6.697 kB`
`react-field` Field	`20.552 kB` `7.092 kB`
`react-image` Image	`14.011 kB` `4.993 kB`
`react-infobutton` InfoButton	`130.577 kB` `39.439 kB`
`react-infobutton` InfoLabel	`133.874 kB` `40.488 kB`
`react-input` Input	`25.747 kB` `7.697 kB`
`react-input` InputField	`35.723 kB` `10.637 kB`
`react-label` Label	`12.57 kB` `4.586 kB`
`react-link` Link	`12.301 kB` `5.07 kB`
`react-menu` Menu (including children components)	`130.926 kB` `39.629 kB`
`react-menu` Menu (including selectable components)	`134.062 kB` `40.161 kB`
`react-overflow` hooks only	`11.214 kB` `4.271 kB`
`react-persona` Persona	`67.338 kB` `17.524 kB`
`react-popover` Popover	`117.58 kB` `35.828 kB`
`react-portal` Portal	`11.649 kB` `4.263 kB`
`react-portal-compat` PortalCompatProvider	`6.446 kB` `2.185 kB`
`react-positioning` usePositioning	`24.008 kB` `8.798 kB`
`react-progress` ProgressBar	`15.961 kB` `5.675 kB`
`react-progress` ProgressField	`26.435 kB` `8.859 kB`
`react-provider` FluentProvider	`20.766 kB` `7.119 kB`
`react-radio` Radio	`35.48 kB` `11.126 kB`
`react-radio` RadioGroup	`17.988 kB` `6.544 kB`
`react-radio` RadioGroupField	`28.166 kB` `9.735 kB`
`react-select` Select	`26.957 kB` `8.766 kB`
`react-select` SelectField	`36.293 kB` `11.316 kB`
`react-slider` Slider	`35.919 kB` `11.059 kB`
`react-slider` SliderField	`45.847 kB` `14.005 kB`
`react-spinbutton` SpinButton	`35.648 kB` `10.348 kB`
`react-spinbutton` SpinButtonField	`44.671 kB` `12.812 kB`
`react-spinner` Spinner	`23.425 kB` `7.195 kB`
`react-switch` Switch	`31.413 kB` `9.294 kB`
`react-switch` SwitchField	`38.317 kB` `11.21 kB`
`react-table` DataGrid	`149.878 kB` `40.662 kB`
`react-table` Table (Primitives only)	`47.119 kB` `12.703 kB`
`react-table` Table as DataGrid	`138.018 kB` `35.282 kB`
`react-table` Table (Selection only)	`85.849 kB` `21.303 kB`
`react-table` Table (Sort only)	`85.179 kB` `21.113 kB`
`react-text` Text - Default	`15.018 kB` `5.327 kB`
`react-text` Text - Wrappers	`15.572 kB` `5.23 kB`
`react-textarea` Textarea	`29.07 kB` `9.081 kB`
`react-textarea` TextareaField	`39.454 kB` `12.055 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.33 kB` `6.764 kB`
`react-theme` Teams: Light theme	`17.895 kB` `5.162 kB`
`react-tooltip` Tooltip	`49.388 kB` `16.815 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 4fad4cbbcbdb48847857c388135a3abda472add7}

fabricteam · 2023-03-27T14:38:42Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2023-03-27T14:42:24Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-03-27T14:42:39Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-03-27T15:00:56Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1221	1244	5000
Breadcrumb	mount	2726	2627	1000
Checkbox	mount	2726	2673	5000
CheckboxBase	mount	2391	2378	5000
ChoiceGroup	mount	4786	4749	5000
ComboBox	mount	1220	1212	1000
CommandBar	mount	9810	9731	1000
ContextualMenu	mount	18041	18543	1000
DefaultButton	mount	1406	1415	5000
DetailsRow	mount	3711	3686	5000
DetailsRowFast	mount	3872	3756	5000
DetailsRowNoStyles	mount	3558	3678	5000
Dialog	mount	4239	4188	1000
DocumentCardTitle	mount	527	528	1000
Dropdown	mount	3471	3500	5000
FocusTrapZone	mount	1972	1935	5000
FocusZone	mount	1916	1861	5000
GroupedList	mount	66359	79676	2
GroupedList	virtual-rerender	32308	32228	2
GroupedList	virtual-rerender-with-unmount	90109	89333	2
GroupedListV2	mount	529	560	2
GroupedListV2	virtual-rerender	538	511	2
GroupedListV2	virtual-rerender-with-unmount	550	561	2
IconButton	mount	2109	2059	5000
Label	mount	718	753	5000
Layer	mount	4831	4798	5000
Link	mount	836	792	5000
MenuButton	mount	1791	1901	5000
MessageBar	mount	31081	31849	5000
Nav	mount	3343	3345	1000
OverflowSet	mount	1390	1371	5000
Panel	mount	2552	2539	1000
Persona	mount	1349	1375	1000
Pivot	mount	1582	1607	1000
PrimaryButton	mount	1523	1532	5000
Rating	mount	7178	7253	5000
SearchBox	mount	1618	1615	5000
Shimmer	mount	3004	2998	5000
Slider	mount	2318	2240	5000
SpinButton	mount	5217	5119	5000
Spinner	mount	812	761	5000
SplitButton	mount	3472	3430	5000
Stack	mount	861	831	5000
StackWithIntrinsicChildren	mount	1654	1653	5000
StackWithTextChildren	mount	4671	4566	5000
SwatchColorPicker	mount	10172	10079	5000
TagPicker	mount	2744	2735	5000
Text	mount	780	786	5000
TextField	mount	1755	1695	5000
ThemeProvider	mount	1565	1586	5000
ThemeProvider	virtual-rerender	1111	1106	5000
ThemeProvider	virtual-rerender-with-unmount	2369	2322	5000
Toggle	mount	1158	1117	5000
buttonNative	mount	509	504	5000

Hotell · 2023-03-27T17:43:17Z

I forgot to send PR for this last week. While it improves task execution by around 1 second it might add more issues to already existing one with source-maps #27320. So i put it on hold. would love to hear your POV. ty

Hotell

it might add more issues to source map situation for cjs as I mentioned in previous comment. but lets give it a shot.

layershifter · 2023-03-29T10:19:21Z

it might add more issues to source map situation for cjs as I mentioned in previous comment. but lets give it a shot.

@Hotell I checked sourcemap issue that you mentioned, it reproes even without Babel postprocess step. So, I think that we can merge this PR.

chore: update babel:postprocess

eaca378

Removes `lib-commonjs` from the glob as now the order of tasks is different.

layershifter requested a review from a team as a code owner March 27, 2023 14:16

msft-fluent-ui-bot added the Area: Build System label Mar 27, 2023

msft-fluent-ui-bot assigned GeoffCoxMSFT Mar 27, 2023

github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 27, 2023

Hotell approved these changes Mar 29, 2023

View reviewed changes

layershifter merged commit c0e9927 into master Mar 29, 2023

layershifter deleted the layershifter-patch-1 branch March 29, 2023 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update babel:postprocess #27335

chore: update babel:postprocess #27335

layershifter commented Mar 27, 2023 •

edited by Hotell

Loading

codesandbox-ci bot commented Mar 27, 2023

size-auditor bot commented Mar 27, 2023

fabricteam commented Mar 27, 2023

fabricteam commented Mar 27, 2023

fabricteam commented Mar 27, 2023

fabricteam commented Mar 27, 2023

fabricteam commented Mar 27, 2023

fabricteam commented Mar 27, 2023

fabricteam commented Mar 27, 2023

Hotell commented Mar 27, 2023

Hotell left a comment

layershifter commented Mar 29, 2023

chore: update babel:postprocess #27335

chore: update babel:postprocess #27335

Conversation

layershifter commented Mar 27, 2023 • edited by Hotell Loading

Previous Behavior

New Behavior

Related issues

codesandbox-ci bot commented Mar 27, 2023

size-auditor bot commented Mar 27, 2023

Asset size changes

fabricteam commented Mar 27, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam commented Mar 27, 2023

Perf Analysis (@fluentui/react-components)

fabricteam commented Mar 27, 2023

📊 Bundle size report

fabricteam commented Mar 27, 2023

Perf Analysis (@fluentui/react-northstar)

fabricteam commented Mar 27, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam commented Mar 27, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam commented Mar 27, 2023

Perf Analysis (@fluentui/react)

Hotell commented Mar 27, 2023

Hotell left a comment

Choose a reason for hiding this comment

layershifter commented Mar 29, 2023

layershifter commented Mar 27, 2023 •

edited by Hotell

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)