chore: prerequisite changes before migrating v9 packages to SWC based transpilation #26965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 32e934b7443ca457be0e760c6380ec20f03976c3 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 766 | 789 | 5000 | |
| Button | mount | 525 | 484 | 5000 | |
| Field | mount | 1526 | 1412 | 5000 | |
| FluentProvider | mount | 1089 | 1093 | 5000 | |
| FluentProviderWithTheme | mount | 252 | 254 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 217 | 191 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 281 | 272 | 10 | |
| InfoButton | mount | 168 | 188 | 5000 | |
| MakeStyles | mount | 1310 | 1315 | 50000 | |
| Persona | mount | 2108 | 2199 | 5000 | |
| SpinButton | mount | 1907 | 1928 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0fe8a72:
|
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| GroupedList | mount | 42487 | 52910 | 2 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 963 | 959 | 5000 | |
| Breadcrumb | mount | 2215 | 2238 | 1000 | |
| Checkbox | mount | 2181 | 2208 | 5000 | |
| CheckboxBase | mount | 1946 | 1960 | 5000 | |
| ChoiceGroup | mount | 3668 | 3674 | 5000 | |
| ComboBox | mount | 950 | 1009 | 1000 | |
| CommandBar | mount | 8065 | 8041 | 1000 | |
| ContextualMenu | mount | 14950 | 14476 | 1000 | |
| DefaultButton | mount | 1089 | 1109 | 5000 | |
| DetailsRow | mount | 2809 | 2830 | 5000 | |
| DetailsRowFast | mount | 2762 | 2777 | 5000 | |
| DetailsRowNoStyles | mount | 2566 | 2575 | 5000 | |
| Dialog | mount | 3123 | 3120 | 1000 | |
| DocumentCardTitle | mount | 421 | 415 | 1000 | |
| Dropdown | mount | 2633 | 2637 | 5000 | |
| FocusTrapZone | mount | 1569 | 1541 | 5000 | |
| FocusZone | mount | 1485 | 1492 | 5000 | |
| GroupedList | mount | 42487 | 52910 | 2 | Possible regression |
| GroupedList | virtual-rerender | 22454 | 22688 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 63883 | 63903 | 2 | |
| GroupedListV2 | mount | 417 | 408 | 2 | |
| GroupedListV2 | virtual-rerender | 398 | 401 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 416 | 414 | 2 | |
| IconButton | mount | 1567 | 1484 | 5000 | |
| Label | mount | 580 | 573 | 5000 | |
| Layer | mount | 3527 | 3504 | 5000 | |
| Link | mount | 650 | 656 | 5000 | |
| MenuButton | mount | 1314 | 1313 | 5000 | |
| MessageBar | mount | 26372 | 26313 | 5000 | |
| Nav | mount | 2542 | 2549 | 1000 | |
| OverflowSet | mount | 1134 | 1133 | 5000 | |
| Panel | mount | 2060 | 2094 | 1000 | |
| Persona | mount | 1029 | 1071 | 1000 | |
| Pivot | mount | 1239 | 1227 | 1000 | |
| PrimaryButton | mount | 1181 | 1189 | 5000 | |
| Rating | mount | 5899 | 5821 | 5000 | |
| SearchBox | mount | 1223 | 1223 | 5000 | |
| Shimmer | mount | 2470 | 2471 | 5000 | |
| Slider | mount | 1777 | 1770 | 5000 | |
| SpinButton | mount | 3590 | 3571 | 5000 | |
| Spinner | mount | 622 | 637 | 5000 | |
| SplitButton | mount | 2382 | 2412 | 5000 | |
| Stack | mount | 672 | 676 | 5000 | |
| StackWithIntrinsicChildren | mount | 1218 | 1234 | 5000 | |
| StackWithTextChildren | mount | 3584 | 3556 | 5000 | |
| SwatchColorPicker | mount | 7585 | 7626 | 5000 | |
| TagPicker | mount | 1879 | 1877 | 5000 | |
| Text | mount | 627 | 627 | 5000 | |
| TextField | mount | 1284 | 1290 | 5000 | |
| ThemeProvider | mount | 1124 | 1137 | 5000 | |
| ThemeProvider | virtual-rerender | 918 | 911 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1682 | 1649 | 5000 | |
| Toggle | mount | 907 | 912 | 5000 | |
| buttonNative | mount | 390 | 370 | 5000 |
🕵 FluentUI-v0 No visual regressions between this PR and main |
TristanWatanabe
commented
Feb 24, 2023
TristanWatanabe
commented
Feb 24, 2023
8 tasks
TristanWatanabe
changed the title
Hotell
reviewed
Feb 28, 2023
Hotell
reviewed
Feb 28, 2023
TristanWatanabe
changed the title
…t occurs after swc tranpilation migration
TristanWatanabe
commented
Mar 9, 2023
TristanWatanabe
changed the title
🕵 fluentuiv8 No visual regressions between this PR and main |
Hotell
approved these changes
Mar 14, 2023
layershifter
approved these changes
Mar 14, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
* master: (141 commits) chore: prerequisite changes before migrating v9 packages to SWC based transpilation (microsoft#26965) feat: Add InfoLabel component (microsoft#27118) fix(tools): update migrate-converged generator to add node field to package.json exports map (microsoft#27152) applying package updates fix: Embed play/pause indicator should render correctly in high contrast mode (microsoft#27213) feat(tokens): Add colorNeutralBackgroundAlpha and colorNeutralStrokeAlpha tokens (microsoft#27034) chore: Prepare release 0.66.4 (microsoft#27163) fix(react-datepicker-compat): Fix text entry issues with input (microsoft#27204) fix: Smooth out animation of indeterminate progress bar (microsoft#27201) Add cxe-red as a codeowner of react-file-type-icons (microsoft#27147) Added documentation about custom style hooks (microsoft#27087) Custom style react-text (microsoft#27078) Custom style react-image (microsoft#27066) Add JSDoc for tabster focus indicator selector (microsoft#27041) Theme designer: Move colors to local files (microsoft#27191) docs(react-card): move card out of preview (microsoft#27185) Include values in typography table (microsoft#27189) feat: accept a className in `mountNode` in `Portal` (microsoft#27008) RFC: Extend `mountNode` prop in `Portal` (microsoft#27009) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
* master: (141 commits) chore: prerequisite changes before migrating v9 packages to SWC based transpilation (microsoft#26965) feat: Add InfoLabel component (microsoft#27118) fix(tools): update migrate-converged generator to add node field to package.json exports map (microsoft#27152) applying package updates fix: Embed play/pause indicator should render correctly in high contrast mode (microsoft#27213) feat(tokens): Add colorNeutralBackgroundAlpha and colorNeutralStrokeAlpha tokens (microsoft#27034) chore: Prepare release 0.66.4 (microsoft#27163) fix(react-datepicker-compat): Fix text entry issues with input (microsoft#27204) fix: Smooth out animation of indeterminate progress bar (microsoft#27201) Add cxe-red as a codeowner of react-file-type-icons (microsoft#27147) Added documentation about custom style hooks (microsoft#27087) Custom style react-text (microsoft#27078) Custom style react-image (microsoft#27066) Add JSDoc for tabster focus indicator selector (microsoft#27041) Theme designer: Move colors to local files (microsoft#27191) docs(react-card): move card out of preview (microsoft#27185) Include values in typography table (microsoft#27189) feat: accept a className in `mountNode` in `Portal` (microsoft#27008) RFC: Extend `mountNode` prop in `Portal` (microsoft#27009) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
swc.withFluentProviderdecorator is explicitly applied in@fluentui/vr-tests-react-componentsstorybook config to address an issue where VR tests written inCSFwere not applying the decorator when built with storybook'sbuild-storybookcommand.puppeteeris now pinned to version 19 to address a hang that occurs with perf testing in v9 presumably caused by a super old version (v1) of puppeteer used by our perf testing toolflamegrill. After this change, everything works as expected besides v8'sTeachingBubbleperf test which freezes during testing and has now been temporarily disabled.rollupversion used for@fluentui/projects-testis bumped to version2.68.0to resolve issue related to usage of the rollup commonjs package in the rollup config.Related Issue(s)