[TEST] Run migration generator with changes for browser matrix based transpilation #26528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by v9 packages to transpile based on browser matrix
…ts build to new build:react-components task
…react-storybook-addon and have vr-tests-react-components directly consume it
Asset size changes
Baseline commit: 30ad74d01e550256a7f62dd8760d393d54473959 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ec48d7:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 888 | 902 | 5000 | |
| Button | mount | 542 | 571 | 5000 | |
| Field | mount | 1611 | 1612 | 5000 | |
| FluentProvider | mount | 1107 | 1116 | 5000 | |
| FluentProviderWithTheme | mount | 294 | 303 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 230 | 229 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 276 | 278 | 10 | |
| InfoButton | mount | 183 | 193 | 5000 | |
| MakeStyles | mount | 1319 | 1289 | 50000 | |
| Persona | mount | 2232 | 2250 | 5000 | |
| SpinButton | mount | 1945 | 1953 | 5000 |
Perf Analysis (
|
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 954 | 950 | 5000 | |
| Breadcrumb | mount | 2174 | 2159 | 1000 | |
| Checkbox | mount | 2150 | 2176 | 5000 | |
| CheckboxBase | mount | 1929 | 1938 | 5000 | |
| ChoiceGroup | mount | 3719 | 3644 | 5000 | |
| ComboBox | mount | 946 | 949 | 1000 | |
| CommandBar | mount | 7972 | 8016 | 1000 | |
| ContextualMenu | mount | 14027 | 14411 | 1000 | |
| DefaultButton | mount | 1093 | 1094 | 5000 | |
| DetailsRow | mount | 2785 | 2762 | 5000 | |
| DetailsRowFast | mount | 2793 | 2758 | 5000 | |
| DetailsRowNoStyles | mount | 2555 | 2576 | 5000 | |
| Dialog | mount | 3105 | 3144 | 1000 | |
| DocumentCardTitle | mount | 424 | 429 | 1000 | |
| Dropdown | mount | 2609 | 2607 | 5000 | |
| FocusTrapZone | mount | 1556 | 1515 | 5000 | |
| FocusZone | mount | 1538 | 1543 | 5000 | |
| GroupedList | mount | 45730 | 52709 | 2 | |
| GroupedList | virtual-rerender | 22481 | 22404 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 63192 | 63259 | 2 | |
| GroupedListV2 | mount | 413 | 416 | 2 | |
| GroupedListV2 | virtual-rerender | 399 | 388 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 414 | 427 | 2 | |
| IconButton | mount | 1457 | 1455 | 5000 | |
| Label | mount | 573 | 575 | 5000 | |
| Layer | mount | 3500 | 3579 | 5000 | |
| Link | mount | 661 | 657 | 5000 | |
| MenuButton | mount | 1290 | 1321 | 5000 | |
| MessageBar | mount | 26192 | 26224 | 5000 | |
| Nav | mount | 2500 | 2515 | 1000 | |
| OverflowSet | mount | 1138 | 1097 | 5000 | |
| Panel | mount | 2090 | 2045 | 1000 | |
| Persona | mount | 1058 | 1040 | 1000 | |
| Pivot | mount | 1195 | 1218 | 1000 | |
| PrimaryButton | mount | 1190 | 1201 | 5000 | |
| Rating | mount | 5811 | 5805 | 5000 | |
| SearchBox | mount | 1216 | 1224 | 5000 | |
| Shimmer | mount | 2426 | 2453 | 5000 | |
| Slider | mount | 1774 | 1758 | 5000 | |
| SpinButton | mount | 3578 | 3604 | 5000 | |
| Spinner | mount | 645 | 651 | 5000 | |
| SplitButton | mount | 2348 | 2360 | 5000 | |
| Stack | mount | 666 | 665 | 5000 | |
| StackWithIntrinsicChildren | mount | 1224 | 1204 | 5000 | |
| StackWithTextChildren | mount | 3551 | 3545 | 5000 | |
| SwatchColorPicker | mount | 7590 | 7539 | 5000 | |
| TagPicker | mount | 1890 | 1881 | 5000 | |
| Text | mount | 615 | 624 | 5000 | |
| TextField | mount | 1277 | 1257 | 5000 | |
| ThemeProvider | mount | 1113 | 1123 | 5000 | |
| ThemeProvider | virtual-rerender | 906 | 916 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1641 | 1654 | 5000 | |
| Toggle | mount | 905 | 898 | 5000 | |
| buttonNative | mount | 366 | 371 | 5000 |
TristanWatanabe
commented
Jan 27, 2023
| @@ -67,3 +68,5 @@ setAddon({ | |||
|
|
|||
| /** @type {import("@fluentui/react-storybook-addon").FluentParameters} */ | |||
| export const parameters = { layout: 'none', mode: 'vr-test' }; | |||
|
|
|||
| export const decorators = [withFluentProvider]; | |||
There was a problem hiding this comment.
Why this was added: #26504 (comment)
…' into use-swc-transpilation-tooling-updates
TristanWatanabe
commented
Feb 18, 2023
| "firefox": "75", | ||
| "opera": "73", | ||
| "safari": "14.1" | ||
| "chrome": "79", |
There was a problem hiding this comment.
Had to lower the browser support to our partial support matrix here since this package is being used by northstar and is throwing the error below regarding not being able to understand nullish coalescing:
verb @fluentui/projects-test test | [!] (plugin commonjs) SyntaxError: Unexpected token (6:48) in /tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/@fluentui/react-portal-compat-context/lib/PortalCompatContext.js
verb @fluentui/projects-test test | node_modules/@fluentui/react-portal-compat-context/lib/PortalCompatContext.js (6:48)
verb @fluentui/projects-test test | 4: export const PortalCompatContextProvider = PortalCompatContext.Provider;
verb @fluentui/projects-test test | 5: export function usePortalCompat() {
verb @fluentui/projects-test test | 6: return React.useContext(PortalCompatContext) ?? portalCompatContextDefaultValue;
verb @fluentui/projects-test test | ^
verb @fluentui/projects-test test | 7: }
verb @fluentui/projects-test test | 8: //# sourceMappingURL=PortalCompatContext.js.map
verb @fluentui/projects-test test | SyntaxError: Unexpected token (6:48) in /tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/@fluentui/react-portal-compat-context/lib/PortalCompatContext.js
verb @fluentui/projects-test test | at Object.pp$4.raise (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:3399:13)
verb @fluentui/projects-test test | at Object.pp.unexpected (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:1248:8)
verb @fluentui/projects-test test | at Object.pp$3.parseExprAtom (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:2822:10)
verb @fluentui/projects-test test | at Object.parseExprAtom (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:5836:77)
verb @fluentui/projects-test test | at Object.pp$3.parseExprSubscripts (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:2651:19)
verb @fluentui/projects-test test | at Object.pp$3.parseMaybeUnary (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:2628:17)
verb @fluentui/projects-test test | at Object.parseMaybeUnary (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:5720:29)
verb @fluentui/projects-test test | at Object.pp$3.parseExprOps (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:2572:19)
verb @fluentui/projects-test test | at Object.pp$3.parseMaybeConditional (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:2555:19)
verb @fluentui/projects-test test | at Object.pp$3.parseMaybeAssign (/tmp/project-rollup--7012-JvE6lzYMysp0/test-app/node_modules/rollup/dist/shared/rollup.js:2528:19)
verb @fluentui/projects-test test |
github-actions
bot
modified the milestones:
January Project Cycle Q1 2023,
February Project Cycle Q1 2023
TristanWatanabe
commented
Feb 18, 2023
| @@ -379,7 +382,8 @@ | |||
| "jest-axe/axe-core": "4.4.3", | |||
| "eslint": "7.25.0", | |||
| "@mdx-js/loader/loader-utils": "~2.0.4", | |||
| "swc-loader": "^0.2.3" | |||
| "swc-loader": "^0.2.3", | |||
| "puppeteer": "19.6.0" | |||
There was a problem hiding this comment.
Had to pin puppeteer to the latest version we use because when v9 packages are transpiled with swc, the perf-test-react-components package completely freezes. This is presumably caused by flamegrill using an ancient version of puppeteer. After this change, the v8 and v9 perf tests run as expected except for v8's TeachingBubble perf test which runs into a Navigation Timeout Error and causes another freeze. Mitigation to move this work forward is to temporarilty disable v8's TeachingBubble perf test
…erged-pkg generator to EXTEND that file within each respective v9 babelrc.json file
🕵 fluentuiv9 No visual regressions between this PR and main |
🕵 FluentUI-v0 No visual regressions between this PR and main |
fabricteam
reviewed
Feb 24, 2023
| @@ -0,0 +1,23 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots
✅ There was 0 screenshots added, 2 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png | 0 | Removed |
| Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png | 0 | Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #26527 and #26965
Related Issue(s)