Convert a11y-testing package to testing-library #22262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e138e19:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a152e0879d1711ca459710815843080ae966b1c1 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 288 | 302 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 903 | 867 | 5000 | |
| Button | mount | 552 | 531 | 5000 | |
| FluentProvider | mount | 1904 | 1940 | 5000 | |
| FluentProviderWithTheme | mount | 288 | 302 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 217 | 237 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 300 | 312 | 10 | |
| MakeStyles | mount | 1503 | 1526 | 50000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 199 | 172 | 1.16:1 |
| RefMinimalPerf.default | 284 | 245 | 1.16:1 |
| ChatDuplicateMessagesPerf.default | 359 | 316 | 1.14:1 |
| CarouselMinimalPerf.default | 521 | 483 | 1.08:1 |
| TextMinimalPerf.default | 388 | 360 | 1.08:1 |
| TextAreaMinimalPerf.default | 538 | 503 | 1.07:1 |
| ButtonSlotsPerf.default | 598 | 564 | 1.06:1 |
| ListWith60ListItems.default | 681 | 645 | 1.06:1 |
| TableMinimalPerf.default | 437 | 414 | 1.06:1 |
| ReactionMinimalPerf.default | 409 | 391 | 1.05:1 |
| AttachmentMinimalPerf.default | 170 | 164 | 1.04:1 |
| AttachmentSlotsPerf.default | 1147 | 1101 | 1.04:1 |
| ChatWithPopoverPerf.default | 414 | 398 | 1.04:1 |
| DividerMinimalPerf.default | 382 | 369 | 1.04:1 |
| ImageMinimalPerf.default | 387 | 372 | 1.04:1 |
| AccordionMinimalPerf.default | 167 | 162 | 1.03:1 |
| BoxMinimalPerf.default | 376 | 365 | 1.03:1 |
| ChatMinimalPerf.default | 784 | 763 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1275 | 1239 | 1.03:1 |
| LabelMinimalPerf.default | 407 | 397 | 1.03:1 |
| ListMinimalPerf.default | 564 | 549 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1795 | 1751 | 1.03:1 |
| PortalMinimalPerf.default | 191 | 185 | 1.03:1 |
| SegmentMinimalPerf.default | 362 | 350 | 1.03:1 |
| SplitButtonMinimalPerf.default | 4605 | 4476 | 1.03:1 |
| AnimationMinimalPerf.default | 581 | 571 | 1.02:1 |
| CardMinimalPerf.default | 590 | 581 | 1.02:1 |
| DropdownManyItemsPerf.default | 737 | 725 | 1.02:1 |
| FlexMinimalPerf.default | 300 | 295 | 1.02:1 |
| HeaderMinimalPerf.default | 390 | 381 | 1.02:1 |
| ProviderMinimalPerf.default | 1190 | 1162 | 1.02:1 |
| SkeletonMinimalPerf.default | 370 | 361 | 1.02:1 |
| DatepickerMinimalPerf.default | 5796 | 5751 | 1.01:1 |
| EmbedMinimalPerf.default | 4351 | 4323 | 1.01:1 |
| GridMinimalPerf.default | 367 | 362 | 1.01:1 |
| LayoutMinimalPerf.default | 383 | 381 | 1.01:1 |
| ListNestedPerf.default | 578 | 573 | 1.01:1 |
| LoaderMinimalPerf.default | 724 | 720 | 1.01:1 |
| IconMinimalPerf.default | 651 | 642 | 1.01:1 |
| TableManyItemsPerf.default | 2014 | 1989 | 1.01:1 |
| AvatarMinimalPerf.default | 206 | 206 | 1:1 |
| CheckboxMinimalPerf.default | 2822 | 2834 | 1:1 |
| FormMinimalPerf.default | 416 | 417 | 1:1 |
| InputMinimalPerf.default | 1357 | 1358 | 1:1 |
| MenuMinimalPerf.default | 901 | 902 | 1:1 |
| PopupMinimalPerf.default | 669 | 670 | 1:1 |
| ProviderMergeThemesPerf.default | 1851 | 1852 | 1:1 |
| CustomToolbarPrototype.default | 4269 | 4258 | 1:1 |
| ToolbarMinimalPerf.default | 1002 | 1004 | 1:1 |
| TooltipMinimalPerf.default | 1074 | 1079 | 1:1 |
| VideoMinimalPerf.default | 661 | 664 | 1:1 |
| DropdownMinimalPerf.default | 3162 | 3201 | 0.99:1 |
| RadioGroupMinimalPerf.default | 454 | 460 | 0.99:1 |
| SliderMinimalPerf.default | 1765 | 1790 | 0.99:1 |
| StatusMinimalPerf.default | 707 | 715 | 0.99:1 |
| TreeWith60ListItems.default | 192 | 193 | 0.99:1 |
| AlertMinimalPerf.default | 280 | 285 | 0.98:1 |
| ButtonOverridesMissPerf.default | 1756 | 1791 | 0.98:1 |
| DialogMinimalPerf.default | 803 | 816 | 0.98:1 |
| HeaderSlotsPerf.default | 785 | 805 | 0.98:1 |
| TreeMinimalPerf.default | 845 | 866 | 0.98:1 |
| RosterPerf.default | 1140 | 1195 | 0.95:1 |
| ListCommonPerf.default | 634 | 683 | 0.93:1 |
ling1726
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
While working on #22245 I discovered that
@fluentui/a11y-testing(used by northstar, react-button, and react-link) still uses Enzyme.New Behavior
Switch the package to use testing-library. I also simplified some of the logic in the one base file that was modified.
Related Issue(s)
Part of #21663