Remove enzyme test setup code from converged packages #22245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
requested review from
a team,
behowell,
khmakoto,
sopranopillow,
GeoffCoxMSFT,
tomi-msft,
micahgodbolt and
smhigley
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f22b93d:
|
📊 Bundle size reportUnchanged fixtures
|
TristanWatanabe
approved these changes
Mar 29, 2022
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1051 | 1073 | 5000 | |
| Button | mount | 652 | 659 | 5000 | |
| FluentProvider | mount | 2086 | 2124 | 5000 | |
| FluentProviderWithTheme | mount | 313 | 312 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 260 | 265 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 343 | 355 | 10 | |
| MakeStyles | mount | 1836 | 1865 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6fd7a550bb24d80f63c35e2da2d53cb33fd4ac32 (build) |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 163 | 139 | 1.17:1 |
| AvatarMinimalPerf.default | 205 | 187 | 1.1:1 |
| LayoutMinimalPerf.default | 354 | 328 | 1.08:1 |
| RefMinimalPerf.default | 251 | 233 | 1.08:1 |
| ButtonMinimalPerf.default | 173 | 161 | 1.07:1 |
| CardMinimalPerf.default | 570 | 534 | 1.07:1 |
| GridMinimalPerf.default | 351 | 327 | 1.07:1 |
| ReactionMinimalPerf.default | 387 | 361 | 1.07:1 |
| TextMinimalPerf.default | 367 | 346 | 1.06:1 |
| InputMinimalPerf.default | 1320 | 1259 | 1.05:1 |
| VideoMinimalPerf.default | 696 | 662 | 1.05:1 |
| AlertMinimalPerf.default | 262 | 251 | 1.04:1 |
| RosterPerf.default | 1157 | 1116 | 1.04:1 |
| PortalMinimalPerf.default | 188 | 180 | 1.04:1 |
| BoxMinimalPerf.default | 344 | 335 | 1.03:1 |
| ChatWithPopoverPerf.default | 368 | 356 | 1.03:1 |
| FlexMinimalPerf.default | 283 | 275 | 1.03:1 |
| SliderMinimalPerf.default | 1718 | 1665 | 1.03:1 |
| AnimationMinimalPerf.default | 564 | 555 | 1.02:1 |
| DividerMinimalPerf.default | 347 | 340 | 1.02:1 |
| DropdownManyItemsPerf.default | 674 | 660 | 1.02:1 |
| DropdownMinimalPerf.default | 3078 | 3031 | 1.02:1 |
| EmbedMinimalPerf.default | 4176 | 4105 | 1.02:1 |
| FormMinimalPerf.default | 406 | 398 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1183 | 1163 | 1.02:1 |
| LabelMinimalPerf.default | 387 | 379 | 1.02:1 |
| MenuMinimalPerf.default | 862 | 845 | 1.02:1 |
| SkeletonMinimalPerf.default | 339 | 333 | 1.02:1 |
| TreeWith60ListItems.default | 193 | 189 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1514 | 1496 | 1.01:1 |
| ButtonSlotsPerf.default | 538 | 532 | 1.01:1 |
| DialogMinimalPerf.default | 756 | 749 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1275 | 1267 | 1.01:1 |
| StatusMinimalPerf.default | 677 | 669 | 1.01:1 |
| TableMinimalPerf.default | 392 | 389 | 1.01:1 |
| CustomToolbarPrototype.default | 2749 | 2730 | 1.01:1 |
| ToolbarMinimalPerf.default | 960 | 955 | 1.01:1 |
| TooltipMinimalPerf.default | 1093 | 1077 | 1.01:1 |
| TreeMinimalPerf.default | 865 | 856 | 1.01:1 |
| AttachmentSlotsPerf.default | 1109 | 1106 | 1:1 |
| ListNestedPerf.default | 557 | 556 | 1:1 |
| MenuButtonMinimalPerf.default | 1710 | 1708 | 1:1 |
| PopupMinimalPerf.default | 631 | 634 | 1:1 |
| RadioGroupMinimalPerf.default | 453 | 453 | 1:1 |
| SplitButtonMinimalPerf.default | 4377 | 4360 | 1:1 |
| ChatMinimalPerf.default | 729 | 737 | 0.99:1 |
| DatepickerMinimalPerf.default | 5691 | 5759 | 0.99:1 |
| HeaderSlotsPerf.default | 758 | 764 | 0.99:1 |
| ListCommonPerf.default | 645 | 652 | 0.99:1 |
| LoaderMinimalPerf.default | 667 | 676 | 0.99:1 |
| TableManyItemsPerf.default | 1940 | 1959 | 0.99:1 |
| TextAreaMinimalPerf.default | 492 | 497 | 0.99:1 |
| CheckboxMinimalPerf.default | 2689 | 2739 | 0.98:1 |
| ListWith60ListItems.default | 636 | 646 | 0.98:1 |
| CarouselMinimalPerf.default | 476 | 490 | 0.97:1 |
| HeaderMinimalPerf.default | 343 | 355 | 0.97:1 |
| ProviderMinimalPerf.default | 396 | 407 | 0.97:1 |
| IconMinimalPerf.default | 589 | 608 | 0.97:1 |
| AccordionMinimalPerf.default | 138 | 144 | 0.96:1 |
| ImageMinimalPerf.default | 357 | 371 | 0.96:1 |
| ListMinimalPerf.default | 496 | 516 | 0.96:1 |
| SegmentMinimalPerf.default | 334 | 351 | 0.95:1 |
| ChatDuplicateMessagesPerf.default | 269 | 294 | 0.91:1 |
GeoffCoxMSFT
approved these changes
Mar 29, 2022
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 931 | 972 | 5000 | |
| Breadcrumb | mount | 2848 | 2755 | 1000 | |
| Checkbox | mount | 1554 | 1514 | 5000 | |
| CheckboxBase | mount | 1347 | 1391 | 5000 | |
| ChoiceGroup | mount | 4956 | 4967 | 5000 | |
| ComboBox | mount | 1000 | 1032 | 1000 | |
| CommandBar | mount | 11244 | 11292 | 1000 | |
| ContextualMenu | mount | 11730 | 13085 | 1000 | |
| DefaultButton | mount | 1216 | 1176 | 5000 | |
| DetailsRow | mount | 3932 | 4019 | 5000 | |
| DetailsRowFast | mount | 3954 | 3956 | 5000 | |
| DetailsRowNoStyles | mount | 3812 | 3791 | 5000 | |
| Dialog | mount | 2312 | 2343 | 1000 | |
| DocumentCardTitle | mount | 171 | 171 | 1000 | |
| Dropdown | mount | 3553 | 3419 | 5000 | |
| FocusTrapZone | mount | 1950 | 1945 | 5000 | |
| FocusZone | mount | 1883 | 1922 | 5000 | |
| IconButton | mount | 1798 | 1867 | 5000 | |
| Label | mount | 363 | 382 | 5000 | |
| Layer | mount | 3054 | 3025 | 5000 | |
| Link | mount | 512 | 505 | 5000 | |
| MenuButton | mount | 1565 | 1578 | 5000 | |
| MessageBar | mount | 2345 | 2296 | 5000 | |
| Nav | mount | 3556 | 3530 | 1000 | |
| OverflowSet | mount | 1120 | 1207 | 5000 | |
| Panel | mount | 2322 | 2183 | 1000 | |
| Persona | mount | 1044 | 1020 | 1000 | |
| Pivot | mount | 1576 | 1518 | 1000 | |
| PrimaryButton | mount | 1359 | 1382 | 5000 | |
| Rating | mount | 8258 | 8214 | 5000 | |
| SearchBox | mount | 1345 | 1418 | 5000 | |
| Shimmer | mount | 2606 | 2605 | 5000 | |
| Slider | mount | 1980 | 1995 | 5000 | |
| SpinButton | mount | 5230 | 5193 | 5000 | |
| Spinner | mount | 449 | 436 | 5000 | |
| SplitButton | mount | 3302 | 3384 | 5000 | |
| Stack | mount | 553 | 541 | 5000 | |
| StackWithIntrinsicChildren | mount | 2587 | 2385 | 5000 | |
| StackWithTextChildren | mount | 5448 | 5481 | 5000 | |
| SwatchColorPicker | mount | 12065 | 12042 | 5000 | |
| TagPicker | mount | 2836 | 2831 | 5000 | |
| TeachingBubble | mount | 100279 | 93564 | 5000 | |
| Text | mount | 472 | 440 | 5000 | |
| TextField | mount | 1434 | 1523 | 5000 | |
| ThemeProvider | mount | 1193 | 1229 | 5000 | |
| ThemeProvider | virtual-rerender | 694 | 686 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1950 | 1979 | 5000 | |
| Toggle | mount | 815 | 827 | 5000 | |
| buttonNative | mount | 123 | 150 | 5000 |
ecraig12345
force-pushed
the
remove-enzyme-setup
branch
2 times, most recently
from
d81e3e7 to
308879b
Compare
12 tasks
layershifter
approved these changes
Mar 30, 2022
Hotell
previously requested changes
Mar 30, 2022
msft-fluent-ui-bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Hotell
reviewed
Mar 31, 2022
ecraig12345
force-pushed
the
remove-enzyme-setup
branch
from
32437b9 to
7d230d4
Compare
ecraig12345
force-pushed
the
remove-enzyme-setup
branch
from
7d230d4 to
dba9034
Compare
|
@Hotell Can you please take another look? |
ecraig12345
force-pushed
the
remove-enzyme-setup
branch
2 times, most recently
from
bb04e30 to
4cf0963
Compare
Hotell
reviewed
Apr 6, 2022
ecraig12345
force-pushed
the
remove-enzyme-setup
branch
from
4cf0963 to
f22b93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
After #22009, react-conformance no longer uses enzyme, which means converged packages no longer use enzyme at all. But they still have setup for it in their test setup files.
New Behavior
Remove Enzyme test setup from converged packages.
Through a build failure, I discovered that@fluentui/a11y-testingstill uses Enzyme, so@fluentui/react-buttonand@fluentui/react-linkmust keep their Enzyme setup for now.This is tracked by an item in #21663 or I can make a separate issue.
Also add
**/config/tests.jsto the list of files ignored by beachball, since those will never affect the published packages (that path should have already been ignored but it was an unintentional omission).Related Issue(s)
Fixes #22118