Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run migration for @fluentui/react-context-selector #20741

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

layershifter
Copy link
Member

Pull request checklist

Description of changes

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against f472b7b8b893b2b076bc47da294d308cb956f1b6

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 29707f5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f472b7b8b893b2b076bc47da294d308cb956f1b6 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1056 1027 5000
BaseButton mount 1082 1067 5000
Breadcrumb mount 2881 2882 1000
ButtonNext mount 650 629 5000
Checkbox mount 1682 1681 5000
CheckboxBase mount 1414 1427 5000
ChoiceGroup mount 4836 4907 5000
ComboBox mount 1125 1173 1000
CommandBar mount 10530 10353 1000
ContextualMenu mount 8512 8653 1000
DefaultButton mount 1309 1267 5000
DetailsRow mount 3938 4120 5000
DetailsRowFast mount 4114 4058 5000
DetailsRowNoStyles mount 3755 3811 5000
Dialog mount 2715 2659 1000
DocumentCardTitle mount 293 275 1000
Dropdown mount 3281 3376 5000
FluentProviderNext mount 4259 4407 5000
FluentProviderWithTheme mount 357 359 10
FluentProviderWithTheme virtual-rerender 215 229 10
FluentProviderWithTheme virtual-rerender-with-unmount 387 416 10
FocusTrapZone mount 1890 2014 5000
FocusZone mount 1994 1934 5000
IconButton mount 2026 1894 5000
Label mount 475 488 5000
Layer mount 3143 3080 5000
Link mount 623 646 5000
MakeStyles mount 2015 1991 50000
MenuButton mount 1669 1617 5000
MessageBar mount 2188 2133 5000
Nav mount 3347 3517 1000
OverflowSet mount 1210 1240 5000
Panel mount 2653 2684 1000
Persona mount 982 995 1000
Pivot mount 1542 1560 1000
PrimaryButton mount 1423 1423 5000
Rating mount 7949 7948 5000
SearchBox mount 1544 1478 5000
Shimmer mount 2644 2699 5000
Slider mount 2014 2088 5000
SpinButton mount 5224 5305 5000
Spinner mount 543 568 5000
SplitButton mount 3377 3359 5000
Stack mount 614 635 5000
StackWithIntrinsicChildren mount 1762 1818 5000
StackWithTextChildren mount 4870 4863 5000
SwatchColorPicker mount 10777 10905 5000
TagPicker mount 2786 2903 5000
TeachingBubble mount 13307 13515 5000
Text mount 563 557 5000
TextField mount 1484 1539 5000
ThemeProvider mount 1322 1357 5000
ThemeProvider virtual-rerender 768 721 5000
ThemeProvider virtual-rerender-with-unmount 2081 2003 5000
Toggle mount 962 937 5000
buttonNative mount 266 262 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 199 175 1.14:1
AvatarMinimalPerf.default 227 201 1.13:1
AlertMinimalPerf.default 291 261 1.11:1
TextMinimalPerf.default 368 335 1.1:1
FlexMinimalPerf.default 310 288 1.08:1
ImageMinimalPerf.default 394 364 1.08:1
ListCommonPerf.default 656 606 1.08:1
PortalMinimalPerf.default 185 171 1.08:1
TreeWith60ListItems.default 184 170 1.08:1
CarouselMinimalPerf.default 508 476 1.07:1
ChatWithPopoverPerf.default 395 373 1.06:1
AttachmentSlotsPerf.default 1113 1060 1.05:1
ButtonSlotsPerf.default 551 526 1.05:1
DividerMinimalPerf.default 397 378 1.05:1
LayoutMinimalPerf.default 405 386 1.05:1
RefMinimalPerf.default 246 235 1.05:1
AttachmentMinimalPerf.default 166 160 1.04:1
DatepickerMinimalPerf.default 5644 5406 1.04:1
SegmentMinimalPerf.default 349 337 1.04:1
ItemLayoutMinimalPerf.default 1198 1162 1.03:1
PopupMinimalPerf.default 611 595 1.03:1
RadioGroupMinimalPerf.default 464 451 1.03:1
SliderMinimalPerf.default 1712 1667 1.03:1
TextAreaMinimalPerf.default 508 491 1.03:1
AnimationMinimalPerf.default 410 400 1.02:1
DropdownMinimalPerf.default 3026 2964 1.02:1
HeaderMinimalPerf.default 386 377 1.02:1
HeaderSlotsPerf.default 784 768 1.02:1
ListMinimalPerf.default 517 505 1.02:1
RosterPerf.default 1222 1196 1.02:1
ReactionMinimalPerf.default 396 387 1.02:1
IconMinimalPerf.default 635 623 1.02:1
TableMinimalPerf.default 399 390 1.02:1
BoxMinimalPerf.default 352 350 1.01:1
CardMinimalPerf.default 548 543 1.01:1
ChatDuplicateMessagesPerf.default 304 300 1.01:1
DialogMinimalPerf.default 744 736 1.01:1
ListWith60ListItems.default 651 645 1.01:1
ProviderMinimalPerf.default 1180 1168 1.01:1
ButtonOverridesMissPerf.default 1737 1734 1:1
InputMinimalPerf.default 1297 1302 1:1
ProviderMergeThemesPerf.default 1731 1732 1:1
TooltipMinimalPerf.default 1030 1031 1:1
CheckboxMinimalPerf.default 2695 2717 0.99:1
LabelMinimalPerf.default 388 391 0.99:1
ListNestedPerf.default 553 556 0.99:1
SkeletonMinimalPerf.default 372 376 0.99:1
DropdownManyItemsPerf.default 691 703 0.98:1
EmbedMinimalPerf.default 4054 4131 0.98:1
FormMinimalPerf.default 413 422 0.98:1
GridMinimalPerf.default 336 342 0.98:1
SplitButtonMinimalPerf.default 4274 4353 0.98:1
TableManyItemsPerf.default 1866 1908 0.98:1
ToolbarMinimalPerf.default 937 953 0.98:1
CustomToolbarPrototype.default 4117 4223 0.97:1
AccordionMinimalPerf.default 158 164 0.96:1
LoaderMinimalPerf.default 695 729 0.95:1
TreeMinimalPerf.default 778 816 0.95:1
ChatMinimalPerf.default 648 686 0.94:1
MenuMinimalPerf.default 818 867 0.94:1
MenuButtonMinimalPerf.default 1611 1706 0.94:1
StatusMinimalPerf.default 689 734 0.94:1
VideoMinimalPerf.default 625 664 0.94:1

@layershifter layershifter merged commit 59b3beb into master Nov 24, 2021
@layershifter layershifter deleted the chore/migrate-rcs branch November 24, 2021 13:02
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
…20741)

* chore: run migration for @fluentui/react-context-selector

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants