migrate-converged-pkg: creates unnecessary .storybook folder

[layershifter]

I am migrating @fluentui/react-shared-contexts via:

yarn nx workspace-generator migrate-converged-pkg --name='@fluentui/react-shared-contexts'

During migration the generator creates .storybook that is not necessary for this package:

CREATE packages/react-shared-contexts/.storybook/tsconfig.json
CREATE packages/react-shared-contexts/.storybook/main.js
CREATE packages/react-shared-contexts/.storybook/preview.js

[layershifter]

@Hotell I am not sure that it's solvable as I don't see any logical condition for this, but if you have ideas it will be awesome to solve this.

[layershifter]

@fluentui/react-context-selector (#20741), @fluentui/make-styles (#20742) have the same problem.

[layershifter]

For @fluentui/babel-make-styles (#20744) it's different: .storybook folder was not created, but scripts were added to package.json.

Edit: moved this to a separate issue #20745

[Hotell]

right, adding this "via context" is tricky in general. I was thinking about a flag for user

nx workspace-generator migrate-converged-package --name=@fluentui/react-zzz --init-storybook

so the logic would be something like:

• if there is existing storybook , update the setup
• if there is no existing storybook, do nothing, unless user provided --init-storybook

WDYT?

[layershifter]

WDYT?

I like the flag idea, but I think that it should be opposite: --disable-storybook
As generally we create components, not utility packages ¯_(ツ)_/¯

[msft-fluent-ui-bot]

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.