Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-radio: migrate converged packages to TS Solution style config #20675

Merged

Conversation

tringakrasniqi
Copy link
Contributor

@tringakrasniqi tringakrasniqi commented Nov 19, 2021

Pull request checklist

Description of changes

Added migration to new DX ts configs for react-radio package

@tringakrasniqi tringakrasniqi requested review from a team November 19, 2021 13:00
@tringakrasniqi tringakrasniqi changed the title Added ts config migration react-radio: migrate converged packages to TS Solution style config Nov 19, 2021
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 944dd049cce65b7b9af11e9bded706dea417f4d8

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 09c0de4:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 19, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 944dd049cce65b7b9af11e9bded706dea417f4d8 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 966 921 5000
BaseButton mount 941 967 5000
Breadcrumb mount 2497 2534 1000
ButtonNext mount 505 514 5000
Checkbox mount 1590 1538 5000
CheckboxBase mount 1384 1384 5000
ChoiceGroup mount 4876 4811 5000
ComboBox mount 956 964 1000
CommandBar mount 9950 9901 1000
ContextualMenu mount 8147 8153 1000
DefaultButton mount 1154 1177 5000
DetailsRow mount 3797 3860 5000
DetailsRowFast mount 3885 3750 5000
DetailsRowNoStyles mount 3651 3693 5000
Dialog mount 2550 2562 1000
DocumentCardTitle mount 168 170 1000
Dropdown mount 3293 3269 5000
FluentProviderNext mount 3733 3707 5000
FluentProviderWithTheme mount 217 226 10
FluentProviderWithTheme virtual-rerender 92 102 10
FluentProviderWithTheme virtual-rerender-with-unmount 252 249 10
FocusTrapZone mount 1836 1775 5000
FocusZone mount 1775 1794 5000
IconButton mount 1817 1818 5000
Label mount 343 350 5000
Layer mount 2994 2986 5000
Link mount 471 492 5000
MakeStyles mount 1783 1755 50000
MenuButton mount 1512 1539 5000
MessageBar mount 1950 1961 5000
Nav mount 3355 3309 1000
OverflowSet mount 1116 1087 5000
Panel mount 2421 2450 1000
Persona mount 841 836 1000
Pivot mount 1413 1452 1000
PrimaryButton mount 1292 1317 5000
Rating mount 8157 8113 5000
SearchBox mount 1397 1403 5000
Shimmer mount 2576 2642 5000
Slider mount 1949 1959 5000
SpinButton mount 5080 5061 5000
Spinner mount 414 426 5000
SplitButton mount 3215 3167 5000
Stack mount 523 507 5000
StackWithIntrinsicChildren mount 1761 1772 5000
StackWithTextChildren mount 4841 4860 5000
SwatchColorPicker mount 10438 10522 5000
TagPicker mount 2728 2609 5000
TeachingBubble mount 12636 12660 5000
Text mount 451 444 5000
TextField mount 1412 1422 5000
ThemeProvider mount 1159 1136 5000
ThemeProvider virtual-rerender 600 584 5000
ThemeProvider virtual-rerender-with-unmount 1983 1907 5000
Toggle mount 840 837 5000
buttonNative mount 122 137 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
VideoMinimalPerf.default 664 609 1.09:1
HeaderSlotsPerf.default 816 758 1.08:1
AttachmentMinimalPerf.default 179 167 1.07:1
PortalMinimalPerf.default 177 166 1.07:1
TableMinimalPerf.default 433 406 1.07:1
AvatarMinimalPerf.default 214 202 1.06:1
CarouselMinimalPerf.default 506 479 1.06:1
DividerMinimalPerf.default 379 357 1.06:1
FlexMinimalPerf.default 291 275 1.06:1
AnimationMinimalPerf.default 427 407 1.05:1
DropdownManyItemsPerf.default 721 686 1.05:1
LayoutMinimalPerf.default 388 368 1.05:1
DialogMinimalPerf.default 758 730 1.04:1
ItemLayoutMinimalPerf.default 1275 1231 1.04:1
ListWith60ListItems.default 678 655 1.04:1
MenuMinimalPerf.default 883 845 1.04:1
SegmentMinimalPerf.default 373 359 1.04:1
AlertMinimalPerf.default 310 302 1.03:1
ChatMinimalPerf.default 681 662 1.03:1
RadioGroupMinimalPerf.default 471 458 1.03:1
SliderMinimalPerf.default 1689 1640 1.03:1
TextAreaMinimalPerf.default 547 529 1.03:1
AccordionMinimalPerf.default 176 172 1.02:1
ButtonSlotsPerf.default 578 564 1.02:1
EmbedMinimalPerf.default 4203 4139 1.02:1
HeaderMinimalPerf.default 374 365 1.02:1
ImageMinimalPerf.default 395 387 1.02:1
ListMinimalPerf.default 528 516 1.02:1
ReactionMinimalPerf.default 391 385 1.02:1
StatusMinimalPerf.default 691 675 1.02:1
CustomToolbarPrototype.default 4020 3950 1.02:1
TreeWith60ListItems.default 190 186 1.02:1
AttachmentSlotsPerf.default 1098 1087 1.01:1
CheckboxMinimalPerf.default 2652 2624 1.01:1
DropdownMinimalPerf.default 2937 2915 1.01:1
GridMinimalPerf.default 348 345 1.01:1
LoaderMinimalPerf.default 682 672 1.01:1
SkeletonMinimalPerf.default 361 359 1.01:1
SplitButtonMinimalPerf.default 4377 4345 1.01:1
TreeMinimalPerf.default 823 818 1.01:1
ButtonOverridesMissPerf.default 1691 1697 1:1
ChatWithPopoverPerf.default 376 376 1:1
DatepickerMinimalPerf.default 5489 5466 1:1
ProviderMergeThemesPerf.default 1613 1605 1:1
RefMinimalPerf.default 226 226 1:1
IconMinimalPerf.default 646 643 1:1
ToolbarMinimalPerf.default 980 976 1:1
TooltipMinimalPerf.default 1047 1042 1:1
BoxMinimalPerf.default 362 366 0.99:1
ChatDuplicateMessagesPerf.default 312 316 0.99:1
FormMinimalPerf.default 428 433 0.99:1
ListNestedPerf.default 581 587 0.99:1
RosterPerf.default 1278 1294 0.99:1
PopupMinimalPerf.default 577 583 0.99:1
TableManyItemsPerf.default 1996 2011 0.99:1
LabelMinimalPerf.default 392 398 0.98:1
CardMinimalPerf.default 588 609 0.97:1
InputMinimalPerf.default 1309 1352 0.97:1
ListCommonPerf.default 653 675 0.97:1
MenuButtonMinimalPerf.default 1659 1702 0.97:1
TextMinimalPerf.default 348 358 0.97:1
ProviderMinimalPerf.default 1088 1138 0.96:1
ButtonMinimalPerf.default 190 199 0.95:1

@tringakrasniqi tringakrasniqi marked this pull request as ready for review November 19, 2021 13:35
@tringakrasniqi tringakrasniqi merged commit 14fb4cb into microsoft:master Nov 19, 2021
@tringakrasniqi tringakrasniqi deleted the react-radio-migration branch November 19, 2021 13:41
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants