eslint error with isConformant.ts in some packages

[ling1726]

Seen in #20692

To repro simply run yarn eslint . in react-portal.

It seems that none of the tsconfigs actually include src/common/isConformant.ts however, it has currently worked or other packages both in that PR or already completed ones like: #20599 #20673 #20675

[Hotell]

I played with it few minutes, here is a quickfix -> isConformant is actually not used at all, that's what makes it fail. if you import it in test file then tsconfig.lib.json will "know" about it although it's being excluded in exclude, thus eslint wont complain.

💡 So to unblock your PR either remove that file completely or use it within test.

In general I think the linting approach will need to be redone because project references are not supported by typescript-eslint, but for some reason our lint configuration "works" as is for now

[Hotell]

additional observation:

we invoke eslint via just differently than how IDE/native eslint invokes it

• we execute it only against src folder
• fluentui/packages/react-portal/src --ext ".ts,.tsx,.js,.jsx" --config "/microsoft/fluentui/packages/react-portal/.eslintrc.json" --color

This is "problematic" as IDE is giving use squigless where CI wont ( bad DX )

[ecraig12345]

I think the intent with the just version was to expand it to include config/other files outside of src as well, but nobody had time to add that.

[Hotell]

I think the intent with the just version was to expand it to include config/other files outside of src as well, but nobody had time to add that.

can we transform this to some knowledge base - actionable item ?

[msft-fluent-ui-bot]

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

[msft-fluent-ui-bot]

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.