Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-image: migrate converged packages to TS Solution style config #20673

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

tringakrasniqi
Copy link
Contributor

@tringakrasniqi tringakrasniqi commented Nov 19, 2021

Pull request checklist

Description of changes

Migration of ts config for react-image package.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 74eb01b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 19, 2021

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
169.377 kB
48.544 kB
react-components
react-components: FluentProvider & webLightTheme
32.669 kB
10.652 kB
react-image
Image
8.989 kB
3.717 kB
🤖 This report was generated against 42c69701f6af74ab511549343c01a88d1889cfd3

@tringakrasniqi tringakrasniqi requested a review from a team November 19, 2021 12:41
@size-auditor
Copy link

size-auditor bot commented Nov 19, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 944dd049cce65b7b9af11e9bded706dea417f4d8 (build)

@tringakrasniqi tringakrasniqi changed the title react-image: Added ts config migration react-image: migrate converged packages to TS Solution style config Nov 19, 2021
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1067 1057 5000
BaseButton mount 1038 1049 5000
Breadcrumb mount 2794 2771 1000
ButtonNext mount 549 584 5000
Checkbox mount 1736 1703 5000
CheckboxBase mount 1487 1471 5000
ChoiceGroup mount 5413 5303 5000
ComboBox mount 1063 1060 1000
CommandBar mount 11019 10954 1000
ContextualMenu mount 9335 9168 1000
DefaultButton mount 1242 1304 5000
DetailsRow mount 4239 4164 5000
DetailsRowFast mount 4160 4124 5000
DetailsRowNoStyles mount 3926 3903 5000
Dialog mount 2766 2755 1000
DocumentCardTitle mount 177 156 1000
Dropdown mount 3614 3530 5000
FluentProviderNext mount 4113 4122 5000
FluentProviderWithTheme mount 228 243 10
FluentProviderWithTheme virtual-rerender 112 118 10
FluentProviderWithTheme virtual-rerender-with-unmount 293 278 10
FocusTrapZone mount 1948 1929 5000
FocusZone mount 1898 1865 5000
IconButton mount 1982 1988 5000
Label mount 375 385 5000
Layer mount 3326 3292 5000
Link mount 554 545 5000
MakeStyles mount 1955 1926 50000
MenuButton mount 1730 1706 5000
MessageBar mount 2153 2234 5000
Nav mount 3650 3657 1000
OverflowSet mount 1248 1242 5000
Panel mount 2663 2684 1000
Persona mount 937 933 1000
Pivot mount 1576 1560 1000
PrimaryButton mount 1458 1481 5000
Rating mount 8657 8812 5000
SearchBox mount 1539 1525 5000
Shimmer mount 2904 2897 5000
Slider mount 2158 2218 5000
SpinButton mount 5472 5485 5000
Spinner mount 474 459 5000
SplitButton mount 3738 3573 5000
Stack mount 587 610 5000
StackWithIntrinsicChildren mount 1960 1961 5000
StackWithTextChildren mount 5443 5535 5000
SwatchColorPicker mount 11746 11710 5000
TagPicker mount 2898 2893 5000
TeachingBubble mount 14210 14058 5000
Text mount 492 496 5000
TextField mount 1530 1568 5000
ThemeProvider mount 1323 1321 5000
ThemeProvider virtual-rerender 667 648 5000
ThemeProvider virtual-rerender-with-unmount 2154 2097 5000
Toggle mount 895 949 5000
buttonNative mount 149 143 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 221 197 1.12:1
TreeWith60ListItems.default 225 207 1.09:1
BoxMinimalPerf.default 419 389 1.08:1
HeaderMinimalPerf.default 426 393 1.08:1
AvatarMinimalPerf.default 250 236 1.06:1
CardMinimalPerf.default 651 620 1.05:1
ImageMinimalPerf.default 461 439 1.05:1
LabelMinimalPerf.default 454 433 1.05:1
LayoutMinimalPerf.default 431 412 1.05:1
SkeletonMinimalPerf.default 434 415 1.05:1
FlexMinimalPerf.default 332 318 1.04:1
ListWith60ListItems.default 726 701 1.04:1
ReactionMinimalPerf.default 454 438 1.04:1
TableManyItemsPerf.default 2197 2121 1.04:1
AttachmentSlotsPerf.default 1223 1192 1.03:1
HeaderSlotsPerf.default 873 848 1.03:1
InputMinimalPerf.default 1424 1384 1.03:1
LoaderMinimalPerf.default 753 733 1.03:1
SplitButtonMinimalPerf.default 4819 4681 1.03:1
StatusMinimalPerf.default 780 755 1.03:1
ChatDuplicateMessagesPerf.default 331 325 1.02:1
DividerMinimalPerf.default 420 413 1.02:1
DropdownManyItemsPerf.default 764 751 1.02:1
FormMinimalPerf.default 473 462 1.02:1
PortalMinimalPerf.default 189 186 1.02:1
IconMinimalPerf.default 680 669 1.02:1
CustomToolbarPrototype.default 4444 4342 1.02:1
TooltipMinimalPerf.default 1185 1161 1.02:1
TreeMinimalPerf.default 936 922 1.02:1
AnimationMinimalPerf.default 460 456 1.01:1
ButtonOverridesMissPerf.default 1889 1863 1.01:1
ChatMinimalPerf.default 761 757 1.01:1
ChatWithPopoverPerf.default 427 423 1.01:1
DropdownMinimalPerf.default 3210 3163 1.01:1
ListCommonPerf.default 740 732 1.01:1
ListMinimalPerf.default 582 577 1.01:1
ListNestedPerf.default 654 650 1.01:1
SliderMinimalPerf.default 1823 1808 1.01:1
AlertMinimalPerf.default 325 326 1:1
CarouselMinimalPerf.default 534 533 1:1
RosterPerf.default 1343 1343 1:1
PopupMinimalPerf.default 645 643 1:1
ProviderMergeThemesPerf.default 1805 1812 1:1
ProviderMinimalPerf.default 1219 1221 1:1
TextMinimalPerf.default 402 402 1:1
TextAreaMinimalPerf.default 596 597 1:1
CheckboxMinimalPerf.default 2908 2928 0.99:1
DatepickerMinimalPerf.default 5995 6059 0.99:1
DialogMinimalPerf.default 837 844 0.99:1
EmbedMinimalPerf.default 4490 4519 0.99:1
ItemLayoutMinimalPerf.default 1346 1353 0.99:1
MenuButtonMinimalPerf.default 1845 1868 0.99:1
RadioGroupMinimalPerf.default 513 517 0.99:1
RefMinimalPerf.default 258 261 0.99:1
TableMinimalPerf.default 460 464 0.99:1
VideoMinimalPerf.default 692 698 0.99:1
AccordionMinimalPerf.default 174 177 0.98:1
AttachmentMinimalPerf.default 183 186 0.98:1
ButtonSlotsPerf.default 623 636 0.98:1
MenuMinimalPerf.default 953 974 0.98:1
GridMinimalPerf.default 367 377 0.97:1
SegmentMinimalPerf.default 402 415 0.97:1
ToolbarMinimalPerf.default 1068 1102 0.97:1

@tringakrasniqi tringakrasniqi marked this pull request as ready for review November 19, 2021 13:22
@tringakrasniqi tringakrasniqi merged commit 01111bb into microsoft:master Nov 19, 2021
@tringakrasniqi tringakrasniqi deleted the react-image-migration branch November 19, 2021 13:41
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants