Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-card - Migrate converged packages to TS Solution style config #20599

Merged
merged 5 commits into from
Nov 19, 2021
Merged

react-card - Migrate converged packages to TS Solution style config #20599

merged 5 commits into from
Nov 19, 2021

Conversation

andrefcdias
Copy link
Contributor

@andrefcdias andrefcdias commented Nov 12, 2021 •
edited
Loading

Pull request checklist

Description of changes

See parent issue #20597.

@andrefcdias andrefcdias requested review from a team as code owners November 12, 2021 14:17
@size-auditor
Copy link

size-auditor bot commented Nov 12, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ca5d6c6d1af2e7d4bed71853a924f83d1dee6c89 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 12, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff803ef:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@andrefcdias andrefcdias mentioned this pull request Nov 12, 2021
Closed
39 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 12, 2021 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All		 49.986 kB
14.787 kB
react-card
Card		 45.406 kB
13.558 kB
react-card
CardFooter		 7.418 kB
3.182 kB
react-card
CardHeader		 8.778 kB
3.64 kB
react-card
CardPreview		 7.682 kB
3.341 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 169.377 kB
48.544 kB
react-components
react-components: FluentProvider & webLightTheme		 32.669 kB
10.652 kB
🤖 This report was generated against ca5d6c6d1af2e7d4bed71853a924f83d1dee6c89

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 12, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1056 1068 5000
BaseButton mount 1049 1090 5000
Breadcrumb mount 2876 2834 1000
ButtonNext mount 576 594 5000
Checkbox mount 1763 1741 5000
CheckboxBase mount 1526 1530 5000
ChoiceGroup mount 5287 5366 5000
ComboBox mount 1048 1110 1000
CommandBar mount 11020 11169 1000
ContextualMenu mount 9278 9193 1000
DefaultButton mount 1274 1323 5000
DetailsRow mount 4264 4212 5000
DetailsRowFast mount 4315 4272 5000
DetailsRowNoStyles mount 4067 4103 5000
Dialog mount 2832 2835 1000
DocumentCardTitle mount 202 198 1000
Dropdown mount 3699 3706 5000
FluentProviderNext mount 4246 4258 5000
FluentProviderWithTheme mount 249 238 10
FluentProviderWithTheme virtual-rerender 107 110 10
FluentProviderWithTheme virtual-rerender-with-unmount 295 286 10
FocusTrapZone mount 1959 2022 5000
FocusZone mount 1925 1971 5000
IconButton mount 2055 2047 5000
Label mount 396 403 5000
Layer mount 3398 3423 5000
Link mount 557 555 5000
MakeStyles mount 2001 2060 50000
MenuButton mount 1792 1810 5000
MessageBar mount 2285 2285 5000
Nav mount 3893 3786 1000
OverflowSet mount 1240 1264 5000
Panel mount 2710 2718 1000
Persona mount 960 980 1000
Pivot mount 1631 1682 1000
PrimaryButton mount 1494 1542 5000
Rating mount 8966 9078 5000
SearchBox mount 1596 1566 5000
Shimmer mount 2990 2886 5000
Slider mount 2237 2193 5000
SpinButton mount 5653 5678 5000
Spinner mount 485 500 5000
SplitButton mount 3653 3655 5000
Stack mount 586 634 5000
StackWithIntrinsicChildren mount 2016 1969 5000
StackWithTextChildren mount 5436 5526 5000
SwatchColorPicker mount 11759 11804 5000
TagPicker mount 3030 2961 5000
TeachingBubble mount 14382 14319 5000
Text mount 506 507 5000
TextField mount 1558 1628 5000
ThemeProvider mount 1303 1369 5000
ThemeProvider virtual-rerender 663 667 5000
ThemeProvider virtual-rerender-with-unmount 2160 2199 5000
Toggle mount 905 944 5000
buttonNative mount 137 159 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 208 184 1.13:1
DropdownManyItemsPerf.default 836 775 1.08:1
SkeletonMinimalPerf.default 433 400 1.08:1
PortalMinimalPerf.default 217 202 1.07:1
TextMinimalPerf.default 430 407 1.06:1
TextAreaMinimalPerf.default 631 598 1.06:1
TreeWith60ListItems.default 220 208 1.06:1
InputMinimalPerf.default 1534 1466 1.05:1
ListNestedPerf.default 675 643 1.05:1
ListWith60ListItems.default 781 745 1.05:1
LoaderMinimalPerf.default 814 777 1.05:1
MenuMinimalPerf.default 1029 980 1.05:1
RadioGroupMinimalPerf.default 528 503 1.05:1
IconMinimalPerf.default 714 680 1.05:1
ButtonSlotsPerf.default 649 626 1.04:1
ChatWithPopoverPerf.default 468 452 1.04:1
HeaderMinimalPerf.default 427 412 1.04:1
RefMinimalPerf.default 263 253 1.04:1
SliderMinimalPerf.default 1929 1861 1.04:1
FormMinimalPerf.default 510 494 1.03:1
ListCommonPerf.default 780 758 1.03:1
PopupMinimalPerf.default 688 671 1.03:1
SegmentMinimalPerf.default 415 401 1.03:1
AnimationMinimalPerf.default 479 469 1.02:1
BoxMinimalPerf.default 420 413 1.02:1
CardMinimalPerf.default 689 676 1.02:1
DialogMinimalPerf.default 885 864 1.02:1
EmbedMinimalPerf.default 4967 4856 1.02:1
GridMinimalPerf.default 396 389 1.02:1
ProviderMergeThemesPerf.default 1917 1888 1.02:1
SplitButtonMinimalPerf.default 4957 4853 1.02:1
TableManyItemsPerf.default 2296 2255 1.02:1
TooltipMinimalPerf.default 1237 1217 1.02:1
TreeMinimalPerf.default 959 938 1.02:1
AttachmentSlotsPerf.default 1246 1232 1.01:1
ChatDuplicateMessagesPerf.default 379 375 1.01:1
ChatMinimalPerf.default 790 784 1.01:1
ImageMinimalPerf.default 447 441 1.01:1
ListMinimalPerf.default 599 596 1.01:1
MenuButtonMinimalPerf.default 1930 1903 1.01:1
RosterPerf.default 1367 1349 1.01:1
ToolbarMinimalPerf.default 1140 1134 1.01:1
VideoMinimalPerf.default 734 724 1.01:1
ButtonOverridesMissPerf.default 2035 2043 1:1
CarouselMinimalPerf.default 569 569 1:1
CheckboxMinimalPerf.default 3149 3149 1:1
DatepickerMinimalPerf.default 6382 6396 1:1
DropdownMinimalPerf.default 3501 3509 1:1
FlexMinimalPerf.default 324 325 1:1
ItemLayoutMinimalPerf.default 1416 1422 1:1
LayoutMinimalPerf.default 432 432 1:1
ProviderMinimalPerf.default 1296 1295 1:1
ReactionMinimalPerf.default 444 442 1:1
StatusMinimalPerf.default 827 823 1:1
TableMinimalPerf.default 476 476 1:1
CustomToolbarPrototype.default 4694 4673 1:1
ButtonMinimalPerf.default 205 208 0.99:1
DividerMinimalPerf.default 429 434 0.99:1
AccordionMinimalPerf.default 195 198 0.98:1
AlertMinimalPerf.default 320 328 0.98:1
HeaderSlotsPerf.default 880 908 0.97:1
LabelMinimalPerf.default 444 456 0.97:1
AvatarMinimalPerf.default 237 248 0.96:1

@varholak-peter varholak-peter added the Status: Blocked Resolution blocked by another issue label Nov 16, 2021
@varholak-peter
Copy link
Contributor

Blocked: See issue for details.

@andrefcdias andrefcdias added Area: Build System Component: Card and removed Status: Blocked Resolution blocked by another issue labels Nov 18, 2021
@andrefcdias andrefcdias enabled auto-merge (squash) November 19, 2021 08:35
ling1726
ling1726 reviewed Nov 19, 2021
View reviewed changes
packages/react-card/src/stories/CardAction.stories.tsx
@@ -1,9 +1,7 @@
import * as React from 'react';
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesomeness 😍😍

tringakrasniqi
tringakrasniqi approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@tringakrasniqi tringakrasniqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@andrefcdias andrefcdias merged commit 5f5fb9f into microsoft:master Nov 19, 2021
@ling1726 ling1726 mentioned this pull request Nov 23, 2021
Closed
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@andrefcdias
react-card - Migrate converged packages to TS Solution style config (m…
b6f26b7 
…icrosoft#20599)
@andrefcdias andrefcdias deleted the migrate-card branch May 12, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tringakrasniqi tringakrasniqi tringakrasniqi approved these changes

@ling1726 ling1726 ling1726 approved these changes

Assignees
No one assigned
Labels
Area: Build System Component: Card
Projects
None yet
Milestone
November Project Cycle Q4 2021
Development

Successfully merging this pull request may close these issues.
6 participants
@andrefcdias @fabricteam @varholak-peter @tringakrasniqi @ling1726 @khmakoto