fix(tools): update migrate-converged-pkg with latest changes so its usable again #20386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8a7f4d9adf50c49d27b52c16f22d91bfd3afb2b4 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f6b0622:
|
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 954 | 953 | 5000 | |
| BaseButton | mount | 913 | 941 | 5000 | |
| Breadcrumb | mount | 2654 | 2668 | 1000 | |
| ButtonNext | mount | 519 | 516 | 5000 | |
| Checkbox | mount | 1580 | 1565 | 5000 | |
| CheckboxBase | mount | 1323 | 1316 | 5000 | |
| ChoiceGroup | mount | 4801 | 4823 | 5000 | |
| ComboBox | mount | 1013 | 1019 | 1000 | |
| CommandBar | mount | 10340 | 10306 | 1000 | |
| ContextualMenu | mount | 6448 | 6423 | 1000 | |
| DefaultButton | mount | 1139 | 1156 | 5000 | |
| DetailsRow | mount | 3861 | 3859 | 5000 | |
| DetailsRowFast | mount | 3906 | 3815 | 5000 | |
| DetailsRowNoStyles | mount | 3662 | 3617 | 5000 | |
| Dialog | mount | 2615 | 2656 | 1000 | |
| DocumentCardTitle | mount | 177 | 188 | 1000 | |
| Dropdown | mount | 3297 | 3302 | 5000 | |
| FluentProviderNext | mount | 3476 | 3419 | 5000 | |
| FluentProviderWithTheme | mount | 219 | 221 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 109 | 101 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 243 | 246 | 10 | |
| FocusTrapZone | mount | 1892 | 1822 | 5000 | |
| FocusZone | mount | 1850 | 1832 | 5000 | |
| IconButton | mount | 1776 | 1768 | 5000 | |
| Label | mount | 361 | 361 | 5000 | |
| Layer | mount | 2995 | 2942 | 5000 | |
| Link | mount | 485 | 524 | 5000 | |
| MakeStyles | mount | 1916 | 1881 | 50000 | |
| MenuButton | mount | 1501 | 1536 | 5000 | |
| MessageBar | mount | 2050 | 2026 | 5000 | |
| Nav | mount | 3410 | 3350 | 1000 | |
| OverflowSet | mount | 1127 | 1129 | 5000 | |
| Panel | mount | 2502 | 2513 | 1000 | |
| Persona | mount | 835 | 874 | 1000 | |
| Pivot | mount | 1449 | 1478 | 1000 | |
| PrimaryButton | mount | 1336 | 1342 | 5000 | |
| Rating | mount | 8016 | 8188 | 5000 | |
| SearchBox | mount | 1389 | 1404 | 5000 | |
| Shimmer | mount | 2585 | 2670 | 5000 | |
| Slider | mount | 1976 | 1995 | 5000 | |
| SpinButton | mount | 5080 | 5076 | 5000 | |
| Spinner | mount | 438 | 451 | 5000 | |
| SplitButton | mount | 3242 | 3275 | 5000 | |
| Stack | mount | 528 | 519 | 5000 | |
| StackWithIntrinsicChildren | mount | 1728 | 1762 | 5000 | |
| StackWithTextChildren | mount | 4763 | 4705 | 5000 | |
| SwatchColorPicker | mount | 10791 | 10796 | 5000 | |
| Tabs | mount | 1473 | 1495 | 1000 | |
| TagPicker | mount | 2654 | 2760 | 5000 | |
| TeachingBubble | mount | 13161 | 13243 | 5000 | |
| Text | mount | 441 | 445 | 5000 | |
| TextField | mount | 1437 | 1420 | 5000 | |
| ThemeProvider | mount | 1218 | 1225 | 5000 | |
| ThemeProvider | virtual-rerender | 641 | 630 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1939 | 1912 | 5000 | |
| Toggle | mount | 844 | 843 | 5000 | |
| buttonNative | mount | 134 | 143 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AnimationMinimalPerf.default | 457 | 413 | 1.11:1 |
| ButtonMinimalPerf.default | 186 | 169 | 1.1:1 |
| PortalMinimalPerf.default | 188 | 176 | 1.07:1 |
| ToolbarMinimalPerf.default | 1008 | 939 | 1.07:1 |
| TreeWith60ListItems.default | 185 | 173 | 1.07:1 |
| SliderMinimalPerf.default | 1820 | 1725 | 1.06:1 |
| AccordionMinimalPerf.default | 160 | 153 | 1.05:1 |
| LabelMinimalPerf.default | 404 | 383 | 1.05:1 |
| BoxMinimalPerf.default | 366 | 351 | 1.04:1 |
| AttachmentMinimalPerf.default | 162 | 158 | 1.03:1 |
| ListMinimalPerf.default | 525 | 511 | 1.03:1 |
| TableManyItemsPerf.default | 1943 | 1892 | 1.03:1 |
| CarouselMinimalPerf.default | 482 | 472 | 1.02:1 |
| DropdownManyItemsPerf.default | 704 | 691 | 1.02:1 |
| HeaderMinimalPerf.default | 400 | 391 | 1.02:1 |
| HeaderSlotsPerf.default | 775 | 757 | 1.02:1 |
| ListCommonPerf.default | 639 | 626 | 1.02:1 |
| MenuMinimalPerf.default | 849 | 831 | 1.02:1 |
| SkeletonMinimalPerf.default | 358 | 350 | 1.02:1 |
| TableMinimalPerf.default | 415 | 407 | 1.02:1 |
| TreeMinimalPerf.default | 830 | 810 | 1.02:1 |
| VideoMinimalPerf.default | 642 | 631 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1813 | 1789 | 1.01:1 |
| CardMinimalPerf.default | 558 | 550 | 1.01:1 |
| DialogMinimalPerf.default | 770 | 766 | 1.01:1 |
| DividerMinimalPerf.default | 358 | 354 | 1.01:1 |
| DropdownMinimalPerf.default | 3286 | 3245 | 1.01:1 |
| FlexMinimalPerf.default | 290 | 288 | 1.01:1 |
| InputMinimalPerf.default | 1366 | 1356 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1662 | 1648 | 1.01:1 |
| RadioGroupMinimalPerf.default | 469 | 463 | 1.01:1 |
| TextMinimalPerf.default | 352 | 348 | 1.01:1 |
| AvatarMinimalPerf.default | 205 | 205 | 1:1 |
| ChatDuplicateMessagesPerf.default | 301 | 302 | 1:1 |
| ChatMinimalPerf.default | 676 | 678 | 1:1 |
| CheckboxMinimalPerf.default | 2797 | 2794 | 1:1 |
| ItemLayoutMinimalPerf.default | 1242 | 1238 | 1:1 |
| ListWith60ListItems.default | 661 | 658 | 1:1 |
| LoaderMinimalPerf.default | 729 | 728 | 1:1 |
| PopupMinimalPerf.default | 596 | 596 | 1:1 |
| SplitButtonMinimalPerf.default | 4339 | 4324 | 1:1 |
| AttachmentSlotsPerf.default | 1077 | 1083 | 0.99:1 |
| ButtonSlotsPerf.default | 556 | 562 | 0.99:1 |
| EmbedMinimalPerf.default | 4396 | 4449 | 0.99:1 |
| ListNestedPerf.default | 560 | 568 | 0.99:1 |
| RosterPerf.default | 1183 | 1197 | 0.99:1 |
| ProviderMinimalPerf.default | 1200 | 1216 | 0.99:1 |
| IconMinimalPerf.default | 616 | 624 | 0.99:1 |
| TextAreaMinimalPerf.default | 488 | 491 | 0.99:1 |
| CustomToolbarPrototype.default | 4201 | 4226 | 0.99:1 |
| AlertMinimalPerf.default | 281 | 288 | 0.98:1 |
| ChatWithPopoverPerf.default | 383 | 392 | 0.98:1 |
| GridMinimalPerf.default | 355 | 362 | 0.98:1 |
| ImageMinimalPerf.default | 375 | 383 | 0.98:1 |
| ReactionMinimalPerf.default | 384 | 393 | 0.98:1 |
| DatepickerMinimalPerf.default | 5427 | 5581 | 0.97:1 |
| ProviderMergeThemesPerf.default | 1769 | 1817 | 0.97:1 |
| RefMinimalPerf.default | 234 | 242 | 0.97:1 |
| StatusMinimalPerf.default | 675 | 693 | 0.97:1 |
| TooltipMinimalPerf.default | 1037 | 1066 | 0.97:1 |
| FormMinimalPerf.default | 404 | 422 | 0.96:1 |
| LayoutMinimalPerf.default | 359 | 377 | 0.95:1 |
| SegmentMinimalPerf.default | 347 | 368 | 0.94:1 |
ecraig12345
approved these changes
Oct 27, 2021
| @@ -16,10 +16,6 @@ Workspace Generator for migrating converged packages to new DX (stage 1)[https:/ | |||
|
|
|||
| ## NOTES | |||
There was a problem hiding this comment.
Maybe remove this heading too?
| storyFileTwo: `${pathToStoriesWithinReactExamples}/${normalizedProjectNameNamesVariants.className}Other/${normalizedProjectNameNamesVariants.className}Other.stories.tsx`, | ||
| /* eslint-enable @fluentui/max-len */ | ||
| }, | ||
| storyOne: `${projectConfig.root}/src/${normalizedProjectNameNamesVariants.className}.stories.tsx`, |
There was a problem hiding this comment.
I think stories are supposed to go under src/stories now
There was a problem hiding this comment.
q: do we have this documented ? I noticed some packages moved it there but was missing context/reasoning. ty
There was a problem hiding this comment.
also in general it is not important where they are - having implementation with test coverage tightly coupled on details is not a good testing pattern.
|
Auto-merge strikes again...I wish github had a prominent warning when approving that auto-merge is enabled. |
This was referenced Nov 4, 2021
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
…sable again (microsoft#20386) * fix(tools): remove caret when adding babel make styles dependency * refactor(tools): remove all related logic to migrating react-examples which is obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Include a change request file using$ yarn changeDescription of changes
Focus areas to test
(optional)