-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tools): don't add 3rd party packages with same scope as we use to… #20561
fix(tools): don't add 3rd party packages with same scope as we use to… #20561
Conversation
📊 Bundle size report🤖 This report was generated against 9a4f32b634150921d3bf4fc89446fd3b8f9cb7fb |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7e24bdf23e54c5d3c66b876711b99e1d83906046 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 759d3f5:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1024 | 1033 | 5000 | |
BaseButton | mount | 1038 | 1042 | 5000 | |
Breadcrumb | mount | 2789 | 2786 | 1000 | |
ButtonNext | mount | 546 | 567 | 5000 | |
Checkbox | mount | 1712 | 1733 | 5000 | |
CheckboxBase | mount | 1450 | 1487 | 5000 | |
ChoiceGroup | mount | 5379 | 5365 | 5000 | |
ComboBox | mount | 1052 | 1114 | 1000 | |
CommandBar | mount | 10813 | 10827 | 1000 | |
ContextualMenu | mount | 9124 | 9003 | 1000 | |
DefaultButton | mount | 1291 | 1262 | 5000 | |
DetailsRow | mount | 4288 | 4237 | 5000 | |
DetailsRowFast | mount | 4146 | 4173 | 5000 | |
DetailsRowNoStyles | mount | 3929 | 4044 | 5000 | |
Dialog | mount | 2723 | 2638 | 1000 | |
DocumentCardTitle | mount | 194 | 176 | 1000 | |
Dropdown | mount | 3480 | 3564 | 5000 | |
FluentProviderNext | mount | 3810 | 3811 | 5000 | |
FluentProviderWithTheme | mount | 222 | 241 | 10 | |
FluentProviderWithTheme | virtual-rerender | 111 | 107 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 255 | 273 | 10 | |
FocusTrapZone | mount | 2014 | 1960 | 5000 | |
FocusZone | mount | 1901 | 1965 | 5000 | |
IconButton | mount | 2013 | 2026 | 5000 | |
Label | mount | 379 | 388 | 5000 | |
Layer | mount | 3272 | 3241 | 5000 | |
Link | mount | 533 | 514 | 5000 | |
MakeStyles | mount | 1932 | 1896 | 50000 | |
MenuButton | mount | 1673 | 1670 | 5000 | |
MessageBar | mount | 2145 | 2183 | 5000 | |
Nav | mount | 3626 | 3627 | 1000 | |
OverflowSet | mount | 1228 | 1196 | 5000 | |
Panel | mount | 2588 | 2580 | 1000 | |
Persona | mount | 926 | 906 | 1000 | |
Pivot | mount | 1595 | 1608 | 1000 | |
PrimaryButton | mount | 1446 | 1465 | 5000 | |
Rating | mount | 8916 | 8773 | 5000 | |
SearchBox | mount | 1531 | 1556 | 5000 | |
Shimmer | mount | 2919 | 2947 | 5000 | |
Slider | mount | 2162 | 2125 | 5000 | |
SpinButton | mount | 5544 | 5472 | 5000 | |
Spinner | mount | 453 | 465 | 5000 | |
SplitButton | mount | 3504 | 3561 | 5000 | |
Stack | mount | 567 | 551 | 5000 | |
StackWithIntrinsicChildren | mount | 1990 | 2008 | 5000 | |
StackWithTextChildren | mount | 5346 | 5395 | 5000 | |
SwatchColorPicker | mount | 11575 | 11562 | 5000 | |
TagPicker | mount | 2893 | 2986 | 5000 | |
TeachingBubble | mount | 13863 | 13874 | 5000 | |
Text | mount | 507 | 473 | 5000 | |
TextField | mount | 1499 | 1556 | 5000 | |
ThemeProvider | mount | 1272 | 1275 | 5000 | |
ThemeProvider | virtual-rerender | 649 | 658 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 2125 | 2061 | 5000 | |
Toggle | mount | 893 | 900 | 5000 | |
buttonNative | mount | 134 | 151 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
HeaderMinimalPerf.default | 442 | 396 | 1.12:1 |
LoaderMinimalPerf.default | 810 | 730 | 1.11:1 |
ButtonMinimalPerf.default | 220 | 201 | 1.09:1 |
ChatDuplicateMessagesPerf.default | 355 | 329 | 1.08:1 |
VideoMinimalPerf.default | 734 | 682 | 1.08:1 |
AnimationMinimalPerf.default | 469 | 438 | 1.07:1 |
ListNestedPerf.default | 671 | 626 | 1.07:1 |
TextAreaMinimalPerf.default | 621 | 583 | 1.07:1 |
ChatMinimalPerf.default | 769 | 726 | 1.06:1 |
RefMinimalPerf.default | 249 | 236 | 1.06:1 |
ChatWithPopoverPerf.default | 451 | 429 | 1.05:1 |
DividerMinimalPerf.default | 413 | 393 | 1.05:1 |
FlexMinimalPerf.default | 316 | 302 | 1.05:1 |
SliderMinimalPerf.default | 1923 | 1824 | 1.05:1 |
TreeMinimalPerf.default | 928 | 880 | 1.05:1 |
AttachmentMinimalPerf.default | 184 | 177 | 1.04:1 |
ImageMinimalPerf.default | 455 | 439 | 1.04:1 |
LabelMinimalPerf.default | 443 | 424 | 1.04:1 |
SkeletonMinimalPerf.default | 426 | 410 | 1.04:1 |
TextMinimalPerf.default | 401 | 387 | 1.04:1 |
CardMinimalPerf.default | 673 | 654 | 1.03:1 |
CheckboxMinimalPerf.default | 3030 | 2928 | 1.03:1 |
ListWith60ListItems.default | 729 | 709 | 1.03:1 |
TooltipMinimalPerf.default | 1165 | 1130 | 1.03:1 |
ButtonOverridesMissPerf.default | 1981 | 1948 | 1.02:1 |
EmbedMinimalPerf.default | 4735 | 4651 | 1.02:1 |
HeaderSlotsPerf.default | 888 | 867 | 1.02:1 |
InputMinimalPerf.default | 1440 | 1417 | 1.02:1 |
LayoutMinimalPerf.default | 417 | 410 | 1.02:1 |
SegmentMinimalPerf.default | 407 | 399 | 1.02:1 |
ToolbarMinimalPerf.default | 1082 | 1059 | 1.02:1 |
CarouselMinimalPerf.default | 532 | 528 | 1.01:1 |
DialogMinimalPerf.default | 832 | 820 | 1.01:1 |
ItemLayoutMinimalPerf.default | 1387 | 1368 | 1.01:1 |
MenuButtonMinimalPerf.default | 1833 | 1811 | 1.01:1 |
RosterPerf.default | 1339 | 1329 | 1.01:1 |
ReactionMinimalPerf.default | 431 | 425 | 1.01:1 |
StatusMinimalPerf.default | 777 | 771 | 1.01:1 |
IconMinimalPerf.default | 714 | 705 | 1.01:1 |
BoxMinimalPerf.default | 412 | 410 | 1:1 |
ButtonSlotsPerf.default | 624 | 627 | 1:1 |
GridMinimalPerf.default | 372 | 373 | 1:1 |
ListCommonPerf.default | 751 | 750 | 1:1 |
SplitButtonMinimalPerf.default | 4801 | 4784 | 1:1 |
TableMinimalPerf.default | 457 | 455 | 1:1 |
CustomToolbarPrototype.default | 4373 | 4369 | 1:1 |
AttachmentSlotsPerf.default | 1192 | 1206 | 0.99:1 |
DropdownMinimalPerf.default | 3386 | 3419 | 0.99:1 |
TableManyItemsPerf.default | 2170 | 2188 | 0.99:1 |
DatepickerMinimalPerf.default | 5999 | 6107 | 0.98:1 |
PopupMinimalPerf.default | 640 | 652 | 0.98:1 |
ProviderMergeThemesPerf.default | 1770 | 1810 | 0.98:1 |
ProviderMinimalPerf.default | 1223 | 1243 | 0.98:1 |
RadioGroupMinimalPerf.default | 524 | 537 | 0.98:1 |
AccordionMinimalPerf.default | 178 | 183 | 0.97:1 |
AlertMinimalPerf.default | 307 | 315 | 0.97:1 |
AvatarMinimalPerf.default | 224 | 231 | 0.97:1 |
DropdownManyItemsPerf.default | 799 | 825 | 0.97:1 |
FormMinimalPerf.default | 480 | 496 | 0.97:1 |
TreeWith60ListItems.default | 197 | 203 | 0.97:1 |
ListMinimalPerf.default | 581 | 605 | 0.96:1 |
MenuMinimalPerf.default | 928 | 977 | 0.95:1 |
PortalMinimalPerf.default | 188 | 206 | 0.91:1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bf66728
to
759d3f5
Compare
… ts paths
Pull request checklist
[ ] Include a change request file using$ yarn change
Description of changes
@fluentui
) that is not living in our repo it will be added totsconfig.base.json
paths as"undefined/src/index.ts"
@fluentui/react-icons
as dependencyFocus areas to test
(optional)