chore: move normalize-import to scripts so we can reuse it for new dx migration tool #18401

Hotell · 2021-06-01T10:54:18Z

Pull request checklist

Addresses an existing issue: partially implements Implement build infra around TS path aliases for convergence #16889
Include a change request file using $ yarn change

Description of changes

prerequisite to our migration tooling for new DX

Focus areas to test

(optional)

… migration setup

Hotell · 2021-06-01T10:56:03Z

packages/react-utilities/src/hooks/useOnClickOutside.ts

@@ -67,7 +67,7 @@ export const useOnClickOutside = (options: UseOnClickOrScrollOutsideOptions) =>
    }

    // Garbage collect this event after it's no longer useful to avoid memory leaks
-    timeoutId.current = setTimeout(() => {
+    timeoutId.current = window.setTimeout(() => {


without being explicit regarding from what global context are we accessing props TS will fail (basically local api-extractor build for react-menu was broken because of this)

please use the canUseDom utility, otherwise this will crash during SSR.

cc @layershifter

do we need to use that in this PR ? there are multiple other occurrences in other projects which are using window

canUseDom

where does it live ?

kudos to @layershifter for looking into this specifically and finding out that at least for Next.js window and document usages seem to not throw (??!!??)

It might still be better to be explicit about the SSR case. the utility function I mentioned in the same package:

https://github.com/microsoft/fluentui/blob/master/packages/react-utilities/src/ssr/canUseDOM.ts

I just realised, all of this is happening within useEffect which AFAIR is not executed when SSR, thus I'd leave it as is and do the necessary changes in other PR. there are other uses of window directly within this file.

Are we ok with this ? thx

size-auditor · 2021-06-01T11:05:10Z

Asset size changes

Project	Bundle	Baseline Size	New Size	Difference
office-ui-fabric-react	fluentui-react-components-Menu	101.919 kB	101.926 kB	7 bytes

Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B

Baseline commit: cdc8b4768ede2349bee2c97b6c2860794ec075d1 (build)

fabricteam · 2021-06-01T11:21:10Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	872	835	5000
BaseButton	mount	973	959	5000
Breadcrumb	mount	2672	2623	1000
ButtonNext	mount	517	511	5000
Checkbox	mount	1621	1590	5000
CheckboxBase	mount	1354	1374	5000
ChoiceGroup	mount	5067	5062	5000
ComboBox	mount	1000	1038	1000
CommandBar	mount	10213	10185	1000
ContextualMenu	mount	6142	6225	1000
DefaultButton	mount	1211	1191	5000
DetailsRow	mount	3976	3797	5000
DetailsRowFast	mount	3784	3942	5000
DetailsRowNoStyles	mount	3644	3632	5000
Dialog	mount	2204	2172	1000
DocumentCardTitle	mount	158	151	1000
Dropdown	mount	3444	3499	5000
FocusTrapZone	mount	1835	1807	5000
FocusZone	mount	1814	1840	5000
IconButton	mount	1860	1829	5000
Label	mount	345	344	5000
Layer	mount	1871	1876	5000
Link	mount	489	480	5000
MakeStyles	mount	1757	1759	50000
MenuButton	mount	1559	1555	5000
MessageBar	mount	2078	2089	5000
Nav	mount	3411	3448	1000
OverflowSet	mount	1031	1125	5000
Panel	mount	2105	2059	1000
Persona	mount	837	835	1000
Pivot	mount	1438	1448	1000
PrimaryButton	mount	1337	1356	5000
Rating	mount	8274	8211	5000
SearchBox	mount	1407	1402	5000
Shimmer	mount	2847	2660	5000
Slider	mount	2141	2187	5000
SpinButton	mount	5295	5360	5000
Spinner	mount	417	401	5000
SplitButton	mount	3346	3323	5000
Stack	mount	554	596	5000
StackWithIntrinsicChildren	mount	1679	1675	5000
StackWithTextChildren	mount	5095	4999	5000
SwatchColorPicker	mount	10788	10893	5000
Tabs	mount	1466	1497	1000
TagPicker	mount	2610	2650	5000
TeachingBubble	mount	12104	12242	5000
Text	mount	448	454	5000
TextField	mount	1495	1448	5000
ThemeProvider	mount	1235	1221	5000
ThemeProvider	virtual-rerender	617	622	5000
ThemeProviderNext	mount	6558	6594	5000
Toggle	mount	877	821	5000
buttonNative	mount	124	112	5000