feat(tools): implement npm scripts updates for migration generator #18403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 611c4220bf8df698e1ec774b17596d79b8de5c51 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 871 | 888 | 5000 | |
| BaseButton | mount | 988 | 971 | 5000 | |
| Breadcrumb | mount | 2693 | 2639 | 1000 | |
| ButtonNext | mount | 548 | 544 | 5000 | |
| Checkbox | mount | 1655 | 1677 | 5000 | |
| CheckboxBase | mount | 1403 | 1443 | 5000 | |
| ChoiceGroup | mount | 5194 | 5051 | 5000 | |
| ComboBox | mount | 1019 | 1018 | 1000 | |
| CommandBar | mount | 10345 | 10156 | 1000 | |
| ContextualMenu | mount | 6272 | 6229 | 1000 | |
| DefaultButton | mount | 1215 | 1202 | 5000 | |
| DetailsRow | mount | 3964 | 3865 | 5000 | |
| DetailsRowFast | mount | 3848 | 3992 | 5000 | |
| DetailsRowNoStyles | mount | 3631 | 3646 | 5000 | |
| Dialog | mount | 2289 | 2237 | 1000 | |
| DocumentCardTitle | mount | 155 | 154 | 1000 | |
| Dropdown | mount | 3459 | 3424 | 5000 | |
| FocusTrapZone | mount | 1908 | 1852 | 5000 | |
| FocusZone | mount | 1864 | 1838 | 5000 | |
| IconButton | mount | 1866 | 1838 | 5000 | |
| Label | mount | 371 | 350 | 5000 | |
| Layer | mount | 1876 | 1979 | 5000 | |
| Link | mount | 490 | 482 | 5000 | |
| MakeStyles | mount | 1783 | 1805 | 50000 | |
| MenuButton | mount | 1583 | 1594 | 5000 | |
| MessageBar | mount | 2007 | 2063 | 5000 | |
| Nav | mount | 3489 | 3497 | 1000 | |
| OverflowSet | mount | 1109 | 1077 | 5000 | |
| Panel | mount | 1433 | 1409 | 1000 | |
| Persona | mount | 869 | 846 | 1000 | |
| Pivot | mount | 1437 | 1504 | 1000 | |
| PrimaryButton | mount | 1417 | 1397 | 5000 | |
| Rating | mount | 8238 | 8193 | 5000 | |
| SearchBox | mount | 1449 | 1469 | 5000 | |
| Shimmer | mount | 2780 | 2847 | 5000 | |
| Slider | mount | 2097 | 2091 | 5000 | |
| SpinButton | mount | 5273 | 5322 | 5000 | |
| Spinner | mount | 465 | 450 | 5000 | |
| SplitButton | mount | 3352 | 3424 | 5000 | |
| Stack | mount | 552 | 543 | 5000 | |
| StackWithIntrinsicChildren | mount | 1709 | 1705 | 5000 | |
| StackWithTextChildren | mount | 5091 | 5016 | 5000 | |
| SwatchColorPicker | mount | 10885 | 11087 | 5000 | |
| Tabs | mount | 1555 | 1490 | 1000 | |
| TagPicker | mount | 2596 | 2641 | 5000 | |
| TeachingBubble | mount | 12073 | 12041 | 5000 | |
| Text | mount | 421 | 452 | 5000 | |
| TextField | mount | 1538 | 1461 | 5000 | |
| ThemeProvider | mount | 1234 | 1222 | 5000 | |
| ThemeProvider | virtual-rerender | 626 | 634 | 5000 | |
| ThemeProviderNext | mount | 6661 | 6683 | 5000 | |
| Toggle | mount | 881 | 918 | 5000 | |
| buttonNative | mount | 120 | 128 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 215 | 193 | 1.11:1 |
| ButtonMinimalPerf.default | 208 | 189 | 1.1:1 |
| AccordionMinimalPerf.default | 167 | 154 | 1.08:1 |
| AlertMinimalPerf.default | 315 | 295 | 1.07:1 |
| ReactionMinimalPerf.default | 439 | 410 | 1.07:1 |
| RefMinimalPerf.default | 249 | 232 | 1.07:1 |
| SkeletonMinimalPerf.default | 415 | 387 | 1.07:1 |
| FlexMinimalPerf.default | 316 | 297 | 1.06:1 |
| HeaderSlotsPerf.default | 881 | 830 | 1.06:1 |
| LayoutMinimalPerf.default | 408 | 384 | 1.06:1 |
| TextMinimalPerf.default | 404 | 381 | 1.06:1 |
| TreeWith60ListItems.default | 197 | 185 | 1.06:1 |
| ButtonSlotsPerf.default | 582 | 552 | 1.05:1 |
| GridMinimalPerf.default | 374 | 355 | 1.05:1 |
| HeaderMinimalPerf.default | 425 | 403 | 1.05:1 |
| IconMinimalPerf.default | 661 | 627 | 1.05:1 |
| AttachmentSlotsPerf.default | 1229 | 1186 | 1.04:1 |
| CarouselMinimalPerf.default | 525 | 506 | 1.04:1 |
| DropdownMinimalPerf.default | 3178 | 3068 | 1.04:1 |
| LoaderMinimalPerf.default | 747 | 716 | 1.04:1 |
| VideoMinimalPerf.default | 677 | 654 | 1.04:1 |
| AnimationMinimalPerf.default | 460 | 446 | 1.03:1 |
| ChatMinimalPerf.default | 654 | 633 | 1.03:1 |
| DropdownManyItemsPerf.default | 743 | 721 | 1.03:1 |
| LabelMinimalPerf.default | 420 | 409 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1730 | 1683 | 1.03:1 |
| StatusMinimalPerf.default | 753 | 732 | 1.03:1 |
| TextAreaMinimalPerf.default | 586 | 568 | 1.03:1 |
| TreeMinimalPerf.default | 847 | 824 | 1.03:1 |
| AttachmentMinimalPerf.default | 179 | 175 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1773 | 1743 | 1.02:1 |
| EmbedMinimalPerf.default | 4327 | 4232 | 1.02:1 |
| FormMinimalPerf.default | 464 | 454 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1330 | 1310 | 1.02:1 |
| BoxMinimalPerf.default | 382 | 379 | 1.01:1 |
| DatepickerMinimalPerf.default | 5636 | 5582 | 1.01:1 |
| ImageMinimalPerf.default | 410 | 405 | 1.01:1 |
| ListCommonPerf.default | 693 | 684 | 1.01:1 |
| ListWith60ListItems.default | 662 | 656 | 1.01:1 |
| PortalMinimalPerf.default | 182 | 180 | 1.01:1 |
| SegmentMinimalPerf.default | 382 | 377 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4011 | 3960 | 1.01:1 |
| TableManyItemsPerf.default | 2108 | 2085 | 1.01:1 |
| CustomToolbarPrototype.default | 4031 | 3980 | 1.01:1 |
| ChatWithPopoverPerf.default | 382 | 381 | 1:1 |
| DialogMinimalPerf.default | 802 | 801 | 1:1 |
| ListMinimalPerf.default | 551 | 551 | 1:1 |
| ListNestedPerf.default | 608 | 610 | 1:1 |
| PopupMinimalPerf.default | 604 | 606 | 1:1 |
| TableMinimalPerf.default | 451 | 450 | 1:1 |
| ToolbarMinimalPerf.default | 991 | 990 | 1:1 |
| TooltipMinimalPerf.default | 1050 | 1052 | 1:1 |
| CardMinimalPerf.default | 611 | 616 | 0.99:1 |
| CheckboxMinimalPerf.default | 2882 | 2902 | 0.99:1 |
| InputMinimalPerf.default | 1304 | 1318 | 0.99:1 |
| MenuMinimalPerf.default | 901 | 910 | 0.99:1 |
| RosterPerf.default | 1264 | 1273 | 0.99:1 |
| ProviderMinimalPerf.default | 1099 | 1112 | 0.99:1 |
| RadioGroupMinimalPerf.default | 487 | 493 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1713 | 1743 | 0.98:1 |
| SliderMinimalPerf.default | 1629 | 1677 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 287 | 305 | 0.94:1 |
| DividerMinimalPerf.default | 399 | 431 | 0.93:1 |
ling1726
reviewed
Jun 1, 2021
| function updateNpmScripts(tree: Tree, options: NormalizedSchema) { | ||
| updateJson(tree, options.paths.packageJson, json => { | ||
| delete json.scripts['update-snapshots']; | ||
| delete json.scripts['start-test']; |
There was a problem hiding this comment.
do we still want the deprecation message with these commands ?
There was a problem hiding this comment.
hmm not really - user that will run the migration on his component is in charge/aware of those changes. WDYT?
There was a problem hiding this comment.
yeah if the user does that it will make sense 👍
ling1726
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Include a change request file using$ yarn changeDescription of changes
This is 4th phase for implementing migration generator with nx:
TASK:
migrate to typescript path aliasesmigrate to use standard jest powered by TS path aliasesbootstrap new storybook configcollocate all package stories from react-examplesFocus areas to test
(optional)