Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply single version policy on storybook #16965

Merged
merged 2 commits into from
Feb 17, 2021
Merged

chore: apply single version policy on storybook #16965

merged 2 commits into from
Feb 17, 2021

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Feb 12, 2021 •
edited
Loading

Pull request checklist

Description of changes

  • apply single version policy for storybook and friends
  • set explicit versions
  • explictly sets nohoist to web-components, so we don't break there anything when migrating to sb 6
  • migrate vr-tests SB config to SB6 apis (bump screener for compatibility)

Focus areas to test

(optional)

@Hotell Hotell changed the title Hotell/16889/sb svp chore: apply single version policy on storybook Feb 12, 2021
@Hotell Hotell force-pushed the hotell/16889/sb-svp branch 2 times, most recently from 359dd0f to ff5ee0c Compare February 12, 2021 10:43
@Hotell Hotell mentioned this pull request Feb 12, 2021
Closed
13 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 12, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d33f5e:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 12, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f4c06e3c80ac9cd218137bae66ae7d1a8f4f28ab (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 12, 2021 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 839 804 5000
BaseButton mount 904 904 5000
Breadcrumb mount 43641 43411 5000
ButtonNext mount 652 674 5000
Checkbox mount 1517 1486 5000
CheckboxBase mount 1244 1246 5000
ChoiceGroup mount 4687 4692 5000
ComboBox mount 955 942 1000
CommandBar mount 10070 10088 1000
ContextualMenu mount 6075 6157 1000
DefaultButton mount 1102 1112 5000
DetailsRow mount 3731 3621 5000
DetailsRowFast mount 3596 3622 5000
DetailsRowNoStyles mount 3397 3374 5000
Dialog mount 1433 1450 1000
DocumentCardTitle mount 1847 1823 1000
Dropdown mount 3298 3284 5000
FocusTrapZone mount 1767 1771 5000
FocusZone mount 1834 1774 5000
IconButton mount 1756 1749 5000
Label mount 333 327 5000
Layer mount 1726 1753 5000
Link mount 449 458 5000
MakeStyles mount 1948 1941 50000
MenuButton mount 1445 1480 5000
MessageBar mount 2011 2022 5000
Nav mount 3226 3199 1000
OverflowSet mount 1020 1041 5000
Panel mount 1363 1438 1000
Persona mount 815 808 1000
Pivot mount 1383 1391 1000
PrimaryButton mount 1253 1264 5000
Rating mount 7471 7466 5000
SearchBox mount 1298 1318 5000
Shimmer mount 2521 2502 5000
Slider mount 1878 1913 5000
SpinButton mount 5078 4961 5000
Spinner mount 415 410 5000
SplitButton mount 3130 3115 5000
Stack mount 498 488 5000
StackWithIntrinsicChildren mount 1524 1521 5000
StackWithTextChildren mount 4411 4423 5000
SwatchColorPicker mount 10167 10238 5000
Tabs mount 1411 1376 1000
TagPicker mount 2736 2780 5000
TeachingBubble mount 11641 11404 5000
Text mount 395 405 5000
TextField mount 1343 1356 5000
ThemeProvider mount 1168 1185 5000
ThemeProvider virtual-rerender 597 600 5000
ThemeProviderNext mount 1972 1970 5000
Toggle mount 768 800 5000
buttonNative mount 106 120 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.17 0.48 0.35:1 2000 347
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 574
🔧 Checkbox.Fluent 0.64 0.35 1.83:1 1000 644
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 802
🔧 Dropdown.Fluent 3.09 0.41 7.54:1 1000 3091
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 683
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 394
🔧 Slider.Fluent 1.6 0.42 3.81:1 1000 1599
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 369
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 578

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 178 161 1.11:1
FlexMinimalPerf.default 337 313 1.08:1
IconMinimalPerf.default 717 679 1.06:1
RefMinimalPerf.default 256 243 1.05:1
DropdownManyItemsPerf.default 769 740 1.04:1
RadioGroupMinimalPerf.default 472 454 1.04:1
SegmentMinimalPerf.default 397 381 1.04:1
ListMinimalPerf.default 539 525 1.03:1
PopupMinimalPerf.default 736 717 1.03:1
TableManyItemsPerf.default 2064 2012 1.03:1
VideoMinimalPerf.default 659 642 1.03:1
GridMinimalPerf.default 363 357 1.02:1
TooltipMinimalPerf.default 845 827 1.02:1
AccordionMinimalPerf.default 161 160 1.01:1
BoxMinimalPerf.default 380 377 1.01:1
ButtonOverridesMissPerf.default 1714 1697 1.01:1
ButtonUseCssPerf.default 842 830 1.01:1
DatepickerMinimalPerf.default 48020 47502 1.01:1
ListWith60ListItems.default 635 631 1.01:1
LoaderMinimalPerf.default 747 741 1.01:1
MenuMinimalPerf.default 907 896 1.01:1
ProviderMinimalPerf.default 990 984 1.01:1
SkeletonMinimalPerf.default 384 380 1.01:1
StatusMinimalPerf.default 750 744 1.01:1
TextMinimalPerf.default 376 372 1.01:1
ToolbarMinimalPerf.default 986 979 1.01:1
TreeMinimalPerf.default 804 796 1.01:1
TreeWith60ListItems.default 184 183 1.01:1
Dialog.Fluent 802 797 1.01:1
Tooltip.Fluent 578 570 1.01:1
AnimationMinimalPerf.default 431 431 1:1
CarouselMinimalPerf.default 500 500 1:1
ChatMinimalPerf.default 643 640 1:1
DividerMinimalPerf.default 382 382 1:1
EmbedMinimalPerf.default 4288 4274 1:1
ImageMinimalPerf.default 404 402 1:1
MenuButtonMinimalPerf.default 1596 1600 1:1
SplitButtonMinimalPerf.default 3765 3761 1:1
TableMinimalPerf.default 426 425 1:1
CustomToolbarPrototype.default 3796 3782 1:1
Button.Fluent 574 576 1:1
Checkbox.Fluent 644 642 1:1
Dropdown.Fluent 3091 3104 1:1
AttachmentSlotsPerf.default 1199 1213 0.99:1
ButtonUseCssNestingPerf.default 1088 1097 0.99:1
ChatDuplicateMessagesPerf.default 374 379 0.99:1
ChatWithPopoverPerf.default 469 473 0.99:1
CheckboxMinimalPerf.default 2811 2841 0.99:1
DialogMinimalPerf.default 796 801 0.99:1
DropdownMinimalPerf.default 3103 3123 0.99:1
FormMinimalPerf.default 424 430 0.99:1
HeaderSlotsPerf.default 793 799 0.99:1
ListCommonPerf.default 655 662 0.99:1
PortalMinimalPerf.default 173 174 0.99:1
ProviderMergeThemesPerf.default 1632 1651 0.99:1
SliderMinimalPerf.default 1625 1640 0.99:1
Avatar.Fluent 347 349 0.99:1
Icon.Fluent 683 688 0.99:1
Slider.Fluent 1599 1610 0.99:1
Text.Fluent 369 371 0.99:1
ButtonMinimalPerf.default 187 191 0.98:1
ButtonSlotsPerf.default 584 593 0.98:1
CardMinimalPerf.default 573 584 0.98:1
InputMinimalPerf.default 1297 1319 0.98:1
ItemLayoutMinimalPerf.default 1221 1248 0.98:1
LabelMinimalPerf.default 437 444 0.98:1
Image.Fluent 394 402 0.98:1
HeaderMinimalPerf.default 386 400 0.97:1
LayoutMinimalPerf.default 436 448 0.97:1
ReactionMinimalPerf.default 404 416 0.97:1
TextAreaMinimalPerf.default 493 508 0.97:1
AvatarMinimalPerf.default 208 216 0.96:1
ListNestedPerf.default 580 605 0.96:1
RosterPerf.default 1148 1220 0.94:1
AlertMinimalPerf.default 300 331 0.91:1

@Hotell Hotell mentioned this pull request Feb 16, 2021
Closed
@Hotell Hotell force-pushed the hotell/16889/sb-svp branch 2 times, most recently from 2f5c71a to fe7d787 Compare February 16, 2021 14:43
Hotell
Hotell commented Feb 16, 2021
View reviewed changes
@Hotell Hotell marked this pull request as ready for review February 16, 2021 15:24
ecraig12345
ecraig12345 approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the minor issues below are resolved.

@Hotell Hotell force-pushed the hotell/16889/sb-svp branch from de3e67c to 580ecee Compare February 17, 2021 11:28
@Hotell Hotell force-pushed the hotell/16889/sb-svp branch from 580ecee to 5d33f5e Compare February 17, 2021 11:29
@Hotell Hotell merged commit 339450a into microsoft:master Feb 17, 2021
joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021
@Hotell @joshualamusga1
chore: apply single version policy on storybook (microsoft#16965)
ede2144 
- chore(vr-tests): prepare storybook config for SB6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@xugao xugao Awaiting requested review from xugao

Assignees

@joschect joschect

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @ecraig12345 @joschect