Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to storybook 6.0.x #17007

Closed
Hotell opened this issue Feb 16, 2021 · 9 comments · Fixed by #17033
Closed

chore: migrate to storybook 6.0.x #17007

Hotell opened this issue Feb 16, 2021 · 9 comments · Fixed by #17033
Assignees
@bsunderhus
Labels
Area: Build System Status: Fixed Fixed in some PR
Milestone
February Project ...

Comments

@Hotell
Copy link
Contributor

Hotell commented Feb 16, 2021 •
edited
Loading

As we are going to leverage Storybook (SB) for convergence (primarily the Composition feature) we need to migrate to SB v6.

Currently we are at 5.3

Tasks:
in general follow migration guide

What apps/packages will be affected:

  • apps/vr-tests - contains storybooks that are executed against Screener for visual regressions
  • packages/storybook - our custom package that provides various fluentui related SB extensions
    • there might be some API changes needed as well
  • packages/react-examples uses deprecated config apis
    • preview.js uses imperative calls configure(), addDecorator() etc
    • this will need to be manually migrated to main.js.

    • If that might turn out to be too difficult, we can opt out temporarily (no-hoist ?, explicitly defining all SB deps to v 5.3 within scripts/ package). In long run we wanna use 1 version of "critical" tool that we use within monorepo.

  • packages/fluentui: no action needed - SB is not being used
  • packages/web-components - they are using SB 5.3. We need to opt out explicitly probably via no-hoist as we are not owners of this package and we don't wanna break their stuff (handled by this PR)
@bsunderhus bsunderhus self-assigned this Feb 16, 2021
@Hotell Hotell mentioned this issue Feb 16, 2021
Merged
2 tasks
@Hotell
Copy link
Contributor Author

Hotell commented Feb 16, 2021

updated vr-tests section

@bsunderhus bsunderhus mentioned this issue Feb 16, 2021
Closed
2 tasks
@Hotell Hotell mentioned this issue Feb 18, 2021
Merged
2 tasks
@Hotell Hotell added this to the February Project Cycle 2021 milestone Feb 22, 2021
@Hotell Hotell changed the title chore: migrate to storybook 6 chore: migrate to storybook 6.0.x Feb 22, 2021
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Feb 23, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17033, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsunderhus bsunderhus

Labels
Area: Build System Status: Fixed Fixed in some PR
Projects
None yet
Milestone
February Project Cycle 2021
Development

Successfully merging a pull request may close this issue.

chore: migrate to Storybook v6.0.x Hotell/fluentui
Migrate to storybook 6 microsoft/fluentui
5 participants
@Hotell @bsunderhus @joschect @JustSlone @msft-fluent-ui-bot