-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run migration for @fluentui/react-shared-contexts #20725
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e413b19:
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
📊 Bundle size report🤖 This report was generated against f472b7b8b893b2b076bc47da294d308cb956f1b6 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f472b7b8b893b2b076bc47da294d308cb956f1b6 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1133 | 1153 | 5000 | |
BaseButton | mount | 1138 | 1207 | 5000 | |
Breadcrumb | mount | 2952 | 3031 | 1000 | |
ButtonNext | mount | 700 | 721 | 5000 | |
Checkbox | mount | 1815 | 1813 | 5000 | |
CheckboxBase | mount | 1585 | 1591 | 5000 | |
ChoiceGroup | mount | 5501 | 5322 | 5000 | |
ComboBox | mount | 1187 | 1243 | 1000 | |
CommandBar | mount | 10858 | 10866 | 1000 | |
ContextualMenu | mount | 9007 | 9120 | 1000 | |
DefaultButton | mount | 1401 | 1412 | 5000 | |
DetailsRow | mount | 4252 | 4280 | 5000 | |
DetailsRowFast | mount | 4312 | 4205 | 5000 | |
DetailsRowNoStyles | mount | 4066 | 4084 | 5000 | |
Dialog | mount | 2868 | 2888 | 1000 | |
DocumentCardTitle | mount | 335 | 324 | 1000 | |
Dropdown | mount | 3659 | 3669 | 5000 | |
FluentProviderNext | mount | 4267 | 4226 | 5000 | |
FluentProviderWithTheme | mount | 380 | 387 | 10 | |
FluentProviderWithTheme | virtual-rerender | 255 | 255 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 422 | 421 | 10 | |
FocusTrapZone | mount | 2064 | 2059 | 5000 | |
FocusZone | mount | 2001 | 2099 | 5000 | |
IconButton | mount | 2068 | 2131 | 5000 | |
Label | mount | 526 | 530 | 5000 | |
Layer | mount | 3405 | 3354 | 5000 | |
Link | mount | 705 | 690 | 5000 | |
MakeStyles | mount | 2063 | 2033 | 50000 | |
MenuButton | mount | 1755 | 1780 | 5000 | |
MessageBar | mount | 2274 | 2268 | 5000 | |
Nav | mount | 3708 | 3751 | 1000 | |
OverflowSet | mount | 1366 | 1359 | 5000 | |
Panel | mount | 2763 | 2763 | 1000 | |
Persona | mount | 1073 | 1036 | 1000 | |
Pivot | mount | 1689 | 1717 | 1000 | |
PrimaryButton | mount | 1582 | 1566 | 5000 | |
Rating | mount | 8753 | 8791 | 5000 | |
SearchBox | mount | 1656 | 1633 | 5000 | |
Shimmer | mount | 3043 | 2956 | 5000 | |
Slider | mount | 2286 | 2222 | 5000 | |
SpinButton | mount | 5497 | 5602 | 5000 | |
Spinner | mount | 608 | 606 | 5000 | |
SplitButton | mount | 3506 | 3573 | 5000 | |
Stack | mount | 718 | 695 | 5000 | |
StackWithIntrinsicChildren | mount | 2115 | 2064 | 5000 | |
StackWithTextChildren | mount | 5428 | 5511 | 5000 | |
SwatchColorPicker | mount | 11506 | 11431 | 5000 | |
TagPicker | mount | 3019 | 2987 | 5000 | |
TeachingBubble | mount | 13634 | 13736 | 5000 | |
Text | mount | 630 | 645 | 5000 | |
TextField | mount | 1678 | 1653 | 5000 | |
ThemeProvider | mount | 1389 | 1391 | 5000 | |
ThemeProvider | virtual-rerender | 819 | 795 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 2210 | 2244 | 5000 | |
Toggle | mount | 986 | 1036 | 5000 | |
buttonNative | mount | 299 | 277 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 216 | 196 | 1.1:1 |
AttachmentMinimalPerf.default | 196 | 180 | 1.09:1 |
LayoutMinimalPerf.default | 429 | 399 | 1.08:1 |
MenuMinimalPerf.default | 1009 | 938 | 1.08:1 |
AvatarMinimalPerf.default | 234 | 221 | 1.06:1 |
IconMinimalPerf.default | 707 | 667 | 1.06:1 |
TextAreaMinimalPerf.default | 580 | 547 | 1.06:1 |
CardMinimalPerf.default | 665 | 633 | 1.05:1 |
CarouselMinimalPerf.default | 544 | 520 | 1.05:1 |
AccordionMinimalPerf.default | 177 | 171 | 1.04:1 |
AttachmentSlotsPerf.default | 1187 | 1142 | 1.04:1 |
ChatMinimalPerf.default | 738 | 710 | 1.04:1 |
FlexMinimalPerf.default | 322 | 309 | 1.04:1 |
ItemLayoutMinimalPerf.default | 1361 | 1310 | 1.04:1 |
RefMinimalPerf.default | 260 | 251 | 1.04:1 |
SkeletonMinimalPerf.default | 404 | 390 | 1.04:1 |
BoxMinimalPerf.default | 392 | 381 | 1.03:1 |
ChatDuplicateMessagesPerf.default | 332 | 321 | 1.03:1 |
DropdownManyItemsPerf.default | 771 | 747 | 1.03:1 |
ToolbarMinimalPerf.default | 1069 | 1039 | 1.03:1 |
VideoMinimalPerf.default | 726 | 707 | 1.03:1 |
DividerMinimalPerf.default | 420 | 410 | 1.02:1 |
DropdownMinimalPerf.default | 3185 | 3124 | 1.02:1 |
EmbedMinimalPerf.default | 4521 | 4448 | 1.02:1 |
GridMinimalPerf.default | 385 | 378 | 1.02:1 |
MenuButtonMinimalPerf.default | 1846 | 1801 | 1.02:1 |
TableMinimalPerf.default | 453 | 443 | 1.02:1 |
TreeMinimalPerf.default | 886 | 870 | 1.02:1 |
AlertMinimalPerf.default | 298 | 294 | 1.01:1 |
AnimationMinimalPerf.default | 456 | 452 | 1.01:1 |
ButtonOverridesMissPerf.default | 1832 | 1817 | 1.01:1 |
DatepickerMinimalPerf.default | 5876 | 5803 | 1.01:1 |
ListCommonPerf.default | 724 | 720 | 1.01:1 |
ListMinimalPerf.default | 585 | 580 | 1.01:1 |
LoaderMinimalPerf.default | 749 | 745 | 1.01:1 |
StatusMinimalPerf.default | 769 | 761 | 1.01:1 |
TableManyItemsPerf.default | 2130 | 2114 | 1.01:1 |
CustomToolbarPrototype.default | 4338 | 4316 | 1.01:1 |
TooltipMinimalPerf.default | 1150 | 1143 | 1.01:1 |
ChatWithPopoverPerf.default | 406 | 406 | 1:1 |
CheckboxMinimalPerf.default | 2851 | 2857 | 1:1 |
DialogMinimalPerf.default | 813 | 815 | 1:1 |
FormMinimalPerf.default | 476 | 477 | 1:1 |
HeaderMinimalPerf.default | 403 | 402 | 1:1 |
HeaderSlotsPerf.default | 846 | 847 | 1:1 |
ListWith60ListItems.default | 743 | 740 | 1:1 |
PopupMinimalPerf.default | 638 | 637 | 1:1 |
ProviderMergeThemesPerf.default | 1781 | 1775 | 1:1 |
SegmentMinimalPerf.default | 393 | 392 | 1:1 |
SliderMinimalPerf.default | 1790 | 1791 | 1:1 |
ButtonSlotsPerf.default | 592 | 597 | 0.99:1 |
ProviderMinimalPerf.default | 1220 | 1237 | 0.99:1 |
SplitButtonMinimalPerf.default | 4687 | 4721 | 0.99:1 |
ImageMinimalPerf.default | 409 | 419 | 0.98:1 |
InputMinimalPerf.default | 1374 | 1397 | 0.98:1 |
LabelMinimalPerf.default | 430 | 437 | 0.98:1 |
RosterPerf.default | 1359 | 1390 | 0.98:1 |
PortalMinimalPerf.default | 181 | 184 | 0.98:1 |
ListNestedPerf.default | 621 | 638 | 0.97:1 |
RadioGroupMinimalPerf.default | 514 | 531 | 0.97:1 |
TextMinimalPerf.default | 387 | 400 | 0.97:1 |
ReactionMinimalPerf.default | 429 | 446 | 0.96:1 |
TreeWith60ListItems.default | 193 | 206 | 0.94:1 |
Co-authored-by: ling1726 <[email protected]>
Another non-blocking problem #20740. |
…0725) * chore: run migration for @fluentui/react-shared-contexts * Change files * Update packages/react-shared-contexts/tsconfig.json Co-authored-by: ling1726 <[email protected]> * fix fmt * restore " --passWithNoTests" Co-authored-by: ling1726 <[email protected]>
Pull request checklist
$ yarn change
Description of changes
.storybook
and relatedpackage.json#scripts
(issue created migrate-converged-pkg: creates unnecessary .storybook folder #20724)