fix(react-keytips): address issues after bug bash #301
Conversation
mainframev
force-pushed
the
docs/react-keytips-bug-bash-improve
branch
5 times, most recently
from
bea7ae1 to
60fb46b
Compare
| import { addons } from '@storybook/manager-api'; | ||
|
|
||
| addons.setConfig({ | ||
| enableShortcuts: false, |
There was a problem hiding this comment.
disabled the shortcuts, as some of them were conflicting with keytips hotkeys. For instance, if invokeEvent is keyup, digit 1 is not captured at all.
| textAlign: 'center', | ||
| cursor: 'default', | ||
| fontFamily: tokens.fontFamilyBase, | ||
| fontSize: tokens.fontSizeBase200, | ||
| lineHeight: tokens.lineHeightBase200, | ||
| borderRadius: tokens.borderRadiusMedium, | ||
| padding: tokens.spacingHorizontalXS, | ||
| border: `1px solid ${tokens.colorTransparentStroke}`, | ||
| padding: `calc(${tokens.spacingHorizontalXS} - 1px)`, |
There was a problem hiding this comment.
Why do we need the -1px? Is the box-sizing: border-box not enough?
There was a problem hiding this comment.
box-sizing is already applied. I add this calc in order to keep the correct token and avoid setting height, just rely on border and padding sizes. The size should be 24x24, which becomes 24x26 with padding token from Figma spec and 1px border, because border is not taking into account in Figma, but we need it, so we could set padding 3px (no token), use fixed height, or this approach.
There was a problem hiding this comment.
It should probably use tokens.strokeWidthThin instead of -1px, e.g.:
calc(${tokens.spacingHorizontalXS} - ${tokens.strokeWidthThin})
packages/react-keytips/src/components/Keytip/useKeytipStyles.styles.ts
Outdated
Show resolved
Hide resolved
mainframev
force-pushed
the
docs/react-keytips-bug-bash-improve
branch
from
60fb46b to
77dca7a
Compare
mainframev
force-pushed
the
docs/react-keytips-bug-bash-improve
branch
from
77bcaad to
62479a0
Compare
mainframev
force-pushed
the
docs/react-keytips-bug-bash-improve
branch
from
62479a0 to
f6e563d
Compare
Fixing the issues spotted during the bug bash session: 1, 2, 3, 4, 7