feat(react-keytips): add overflowSequence prop #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
refactor/react-keytips-overflow
branch
2 times, most recently
from
5cfbed3 to
36d5321
Compare
mainframev
force-pushed
the
refactor/react-keytips-overflow
branch
2 times, most recently
from
e501b82 to
03a4642
Compare
dmytrokirpa
approved these changes
Feb 21, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "minor", | |||
There was a problem hiding this comment.
shouldn't we use major for breaking changes?
There was a problem hiding this comment.
@dmytrokirpa not until stable AFAIK, when stable -> major, until not stable minor is considered as breaking. The first release was as minor, so I guess it's ok that we have already one minor.
mainframev
force-pushed
the
refactor/react-keytips-overflow
branch
from
03a4642 to
7793748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
overflowSequenceprop, removedisShortcut, refactored and simplified the examples with Overflow. Follow-up of #301