[PT Run]Removed BinaryFormatter

[davidegiacometti]

Summary of the Pull Request

Replaced insicure BinaryFormatter.

PR Checklist

• Closes: [PT Run] Replace BinaryFormatter  #15610
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Replaced the BInaryFormatter with the already existing JsonStorage.

Validation Steps Performed

• Launch PT Run from the PT Runner
• File %LOCALAPPDATA%\Microsoft\PowerToys\PowerToys Run\Settings\ImageCache.json should be created
• Perform some searches in PT Run
• Close PT
• File %LOCALAPPDATA%\Microsoft\PowerToys\PowerToys Run\Settings\ImageCache.json should be updated with cached images

[jaimecbernardo]

This is pretty interesting. Somehow I feel this might fix those Image.cache can't be accessed errors we get from time to time ;) There's only hoping.

[jaimecbernardo]

So, I look for notepad:

Then, I exit PowerToys, start it again, and look for it again:

I think the current solution is not really caching the images.

[davidegiacometti]

I will look into this

[davidegiacometti]

I have retested my changes.
Images are preloaded on startup from ImageCache.json.
Sometimes the program fail to extract thumbnail, but AFAIK this is an issue that I have always seen.

-------------------------- Begin exception --------------------------
Message: Failed to get thumbnail for C:\ProgramData\Microsoft\Windows\Start Menu\Programs\NAPS2\NAPS2.lnk

Exception full name  : System.Runtime.InteropServices.InvalidComObjectException
Exception message    : Error while extracting thumbnail for C:\ProgramData\Microsoft\Windows\Start Menu\Programs\NAPS2\NAPS2.lnk
Exception stack trace:
   at Wox.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap(String fileName, Int32 width, Int32 height, ThumbnailOptions options) in C:\Users\david\source\repos\PowerToys\src\modules\launcher\Wox.Infrastructure\Image\WindowsThumbnailProvider.cs:line 126
   at Wox.Infrastructure.Image.WindowsThumbnailProvider.GetThumbnail(String fileName, Int32 width, Int32 height, ThumbnailOptions options) in C:\Users\david\source\repos\PowerToys\src\modules\launcher\Wox.Infrastructure\Image\WindowsThumbnailProvider.cs:line 82
   at Wox.Infrastructure.Image.ImageLoader.LoadInternal(String path, Boolean loadFullImage) in C:\Users\david\source\repos\PowerToys\src\modules\launcher\Wox.Infrastructure\Image\ImageLoader.cs:line 183
Exception source     : Wox.Infrastructure
Exception target site: IntPtr GetHBitmap(System.String, Int32, Int32, Wox.Infrastructure.Image.ThumbnailOptions)
Exception HResult    : -2146233049

Exception full name  : System.Runtime.InteropServices.COMException
Exception message    : The data necessary to complete this operation is not yet available. (0x8000000A)
Exception stack trace:

Exception source     : 
Exception target site: 
Exception HResult    : -2147483638
-------------------------- End exception --------------------------

@jaimecbernardo are you able to reproduce it?

EDIT: the interesting thing is that the code for extract thumbnails fail only when executed in parallel. I am not able to repro the issue with a foreach.

[jaimecbernardo]

You're right, I'm able to repro it on 0.59.1 as well, so no regression here. 🤔
Might there be something wrong just with the cache logic in general? Either way, this is OK to go in.

[jaimecbernardo]

LGTM! Thank you for the contribution!

[davidegiacometti]

I will check if there is already an issue for this, if not I will open one.

[davidegiacometti]

Created issue #19138