Missing Win32 Icons

[davidegiacometti]

Microsoft PowerToys version

0.60 dev

Running as admin

• Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Originally posted: #19036 (comment)
Xref #7456

Sometimes icons for Win32 programs failed to load.

-------------------------- Begin exception --------------------------
Message: Failed to get thumbnail for C:\ProgramData\Microsoft\Windows\Start Menu\Programs\NAPS2\NAPS2.lnk

Exception full name  : System.Runtime.InteropServices.InvalidComObjectException
Exception message    : Error while extracting thumbnail for C:\ProgramData\Microsoft\Windows\Start Menu\Programs\NAPS2\NAPS2.lnk
Exception stack trace:
   at Wox.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap(String fileName, Int32 width, Int32 height, ThumbnailOptions options) in C:\Users\david\source\repos\PowerToys\src\modules\launcher\Wox.Infrastructure\Image\WindowsThumbnailProvider.cs:line 126
   at Wox.Infrastructure.Image.WindowsThumbnailProvider.GetThumbnail(String fileName, Int32 width, Int32 height, ThumbnailOptions options) in C:\Users\david\source\repos\PowerToys\src\modules\launcher\Wox.Infrastructure\Image\WindowsThumbnailProvider.cs:line 82
   at Wox.Infrastructure.Image.ImageLoader.LoadInternal(String path, Boolean loadFullImage) in C:\Users\david\source\repos\PowerToys\src\modules\launcher\Wox.Infrastructure\Image\ImageLoader.cs:line 183
Exception source     : Wox.Infrastructure
Exception target site: IntPtr GetHBitmap(System.String, Int32, Int32, Wox.Infrastructure.Image.ThumbnailOptions)
Exception HResult    : -2146233049

Exception full name  : System.Runtime.InteropServices.COMException
Exception message    : The data necessary to complete this operation is not yet available. (0x8000000A)
Exception stack trace:

Exception source     : 
Exception target site: 
Exception HResult    : -2147483638
-------------------------- End exception --------------------------

✔️ Expected Behavior

Icons should be displayed

❌ Actual Behavior

Icons are missing

Other Software

No response

[htcfreek]

@davidegiacometti , @jaimecbernardo
Related to #16625?

[davidegiacometti]

From my investigation the issue isn't really related to the cache, but to the code used to retrieve thumbnails, mostly when executed in parallel (cache).

[htcfreek]

@davidegiacometti
In which situation does the crash happens? Randomly or at the first execution?

[davidegiacometti]

From my test it happens during startup, when images are preloaded from cache in parallel, but not at every run.

[jaimecbernardo]

I think this is related to having the items in cache, since it seems never replicate at first time after deleting %localappdata%\Microsoft\PowerToys.

[davidegiacometti]

@jaimecbernardo it looks related to fetching thumbnails in parallel that of course happens when preloading images from the cache.
Not sure if during a search thumbnails are retrieved in parallel.

[stefansjfw]

@davidegiacometti @htcfreek I can't repro this? Can you ? We did some changes in the meantime related to thumbnails logic, so it might affected this one too. /needinfo

[stefansjfw]

I coudn't repro what you were seeing , but I found the cause of not getting notepad.exe icon properly : #31170

[jaimecbernardo]

This has been worked on during the 0.79.0 release cycle.
Please update to the latest: https://github.com/microsoft/PowerToys/releases