Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retention Policy: Convert total number of deleted records to BigInteger #2962

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ codeunit 3904 "Apply Retention Policy Impl."
Permissions = tabledata AllObjWithCaption = r;

var
TotalNumberOfRecordsDeleted: Integer;
TotalNumberOfRecordsDeleted: BigInteger;
EndCurrentRun: Boolean;
ApplyAllRetentionPolicies: Boolean;
IsUserInvokedRun: Boolean;
Expand Down Expand Up @@ -222,7 +222,7 @@ codeunit 3904 "Apply Retention Policy Impl."
RecordRefDuplicate: RecordRef;
RetenPolDeleting: Interface "Reten. Pol. Deleting";
Handled: Boolean;
NumberOfRecordsDeleted: Integer;
NumberOfRecordsDeleted: BigInteger;
RecordCountBefore: Integer;
RecordCountAfter: Integer;
begin
Expand Down Expand Up @@ -427,12 +427,12 @@ codeunit 3904 "Apply Retention Policy Impl."
exit(RetentionPolicyLogCategory::"Retention Policy - Apply");
end;

internal procedure MaxNumberOfRecordsToDelete(): Integer
internal procedure MaxNumberOfRecordsToDelete(): BigInteger
begin
exit(10000)
end;

internal procedure NumberOfRecordsToDeleteBuffer(): Integer
internal procedure NumberOfRecordsToDeleteBuffer(): BigInteger
begin
exit(0)
end;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
/// <summary>
/// Indicates the maximum number of records to be deleted.
/// </summary>
field(4; "Max. Number of Rec. to Delete"; Integer)
field(4; "Max. Number of Rec. to Delete"; BigInteger)

Check failure on line 59 in src/System Application/App/Retention Policy/src/Apply Retention Policy/RetenPolDeletingParam.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Default) / System Application and Tools (Default)

AS0004 Field 'Max. Number of Rec. to Delete' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.

Check failure on line 59 in src/System Application/App/Retention Policy/src/Apply Retention Policy/RetenPolDeletingParam.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Translated) / System Application and Tools (Translated)

AS0004 Field 'Max. Number of Rec. to Delete' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grobyns to confirm this is not breaking partners or at least very unlikely to do so and fine to check in.

{
DataClassification = SystemMetadata;
MinValue = 0;
Expand All @@ -69,9 +69,9 @@
DataClassification = SystemMetadata;
}
/// <summary>
/// Indicates the maximum number of records that can be deleted at the same time accross all retention policies
/// Indicates the maximum number of records that can be deleted at the same time across all retention policies
/// </summary>
field(6; "Total Max. Nr. of Rec. to Del."; Integer)
field(6; "Total Max. Nr. of Rec. to Del."; BigInteger)

Check failure on line 74 in src/System Application/App/Retention Policy/src/Apply Retention Policy/RetenPolDeletingParam.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Default) / System Application and Tools (Default)

AS0004 Field 'Total Max. Nr. of Rec. to Del.' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.

Check failure on line 74 in src/System Application/App/Retention Policy/src/Apply Retention Policy/RetenPolDeletingParam.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Translated) / System Application and Tools (Translated)

AS0004 Field 'Total Max. Nr. of Rec. to Del.' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.
{
DataClassification = SystemMetadata;
MinValue = 0;
Expand All @@ -88,7 +88,7 @@
/// The number of records in the table before the deletion.
/// The count is calculated once before passing this table to the deletion implementation and is used to limit the number of records to be deleted as well as record the number of records actually deleted.
/// </summary>
field(8; "Record Count Before Delete"; Integer)
field(8; "Record Count Before Delete"; BigInteger)

Check failure on line 91 in src/System Application/App/Retention Policy/src/Apply Retention Policy/RetenPolDeletingParam.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Default) / System Application and Tools (Default)

AS0004 Field 'Record Count Before Delete' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.

Check failure on line 91 in src/System Application/App/Retention Policy/src/Apply Retention Policy/RetenPolDeletingParam.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Translated) / System Application and Tools (Translated)

AS0004 Field 'Record Count Before Delete' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.
{
DataClassification = SystemMetadata;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
{
DataClassification = SystemMetadata;
}
field(100; "Number Of Records Deleted"; Integer)
field(100; "Number Of Records Deleted"; BigInteger)

Check failure on line 151 in src/System Application/App/Retention Policy/src/Retention Policy Setup/RetentionPolicySetup.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Default) / System Application and Tools (Default)

AS0004 Field 'Number Of Records Deleted' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.

Check failure on line 151 in src/System Application/App/Retention Policy/src/Retention Policy Setup/RetentionPolicySetup.Table.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Translated) / System Application and Tools (Translated)

AS0004 Field 'Number Of Records Deleted' has changed type from 'Integer' to 'BigInteger'. Type changes are not allowed.
{
DataClassification = SystemMetadata;
Access = Internal;
Expand Down
Loading