Retention Policy: Convert total number of deleted records to BigInteger #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasMoth
commented
Feb 17, 2025
| @@ -56,7 +56,7 @@ table 3907 "Reten. Pol. Deleting Param" | |||
| /// <summary> | |||
| /// Indicates the maximum number of records to be deleted. | |||
| /// </summary> | |||
| field(4; "Max. Number of Rec. to Delete"; Integer) | |||
| field(4; "Max. Number of Rec. to Delete"; BigInteger) | |||
There was a problem hiding this comment.
@grobyns to confirm this is not breaking partners or at least very unlikely to do so and fine to check in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some very rare cases, we delete more entries than can be stored in an Integer, hence I'm upgrading all the deletion fields to BigInteger to make us future proof.
Fixes AB#562945