-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E-Document Core] - Show Purchase attachments in Peppol #27876
base: main
Are you sure you want to change the base?
[E-Document Core] - Show Purchase attachments in Peppol #27876
Conversation
[E-Document Core] - Code workspace
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
@microsoft-github-policy-service agree company="Companial" |
Database::"E-Document": | ||
begin | ||
RecRef.Open(Database::"E-Document"); | ||
if EDocument.Get(DocumentAttachment."No.") then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the DocumentAttachment."No."
really correct here?
Shouldn't it be DocumentAttachment."E-Document Entry No."
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: This change partially addresses the issue that the attachments should be visible on an E-Document. If the lines were not mapped during processing, the processing will fail, and the attachments will not appear in the Fact box for received e-doc. Ideally a user should be able to see the attachments in order to create mapping to GL for example. Currently:
|
That's right. Attachment must be presented even if the processing is not finished. This is the main reason why we want to show attachment in the e-document. |
Thanks, does that mean that we agree that this change might be just a first step towards it? |
Yes |
This pull request does not have a related issue as it's part of delivery for development agreed directly with @altotovi @Groenbech96
Implementation
This update ensures that when a Peppol file with Purchase document which contains an embedded PDF is received, the system extracts the PDF and displays it in assigned Factbox as attachment. This feature allows users to access embedded PDF before creating Purchase documents like invoices, orders or credit memos.
A new Factbox 'Doc. Attachment List' is added to the following pages:
'E-Document' (Page 6121)
'E-Documents' (Page 6122)
Fixes #