Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E-Document Core] - Show attachments for E-Document and E-Documents page tests #3

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

petemchlk
Copy link
Collaborator

@petemchlk petemchlk commented Dec 30, 2024

Implementation

This update ensures that when a Peppol file with Purchase document which contains an embedded PDF is received, the system extracts the PDF and displays it in assigned Factbox as attachment. This feature allows users to access embedded PDF before creating Purchase documents like invoices, orders or credit memos.

A new Factbox 'Doc. Attachment List' is added to the following pages:
'E-Document' (Page 6121)
'E-Documents' (Page 6122)

MS PR: microsoft#27876

Copy link
Collaborator

@tinestaric tinestaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest having just one PR for both the functionality and tests.

Apps/W1/EDocument/app/src/Document/EDocuments.Page.al Outdated Show resolved Hide resolved
@nerkel91
Copy link
Collaborator

nerkel91 commented Jan 3, 2025

Implementation

This update ensures that when a Peppol file with Purchase document which contains an embedded PDF is received, the system extracts the PDF and displays it in assigned Factbox as attachment. This feature allows users to access embedded PDF before creating Purchase documents like invoices, orders or credit memos.

A new Factbox 'Doc. Attachment List' is added to the following pages:
'E-Document' (Page 6121)
'E-Documents' (Page 6122)

tinestaric
tinestaric previously approved these changes Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants