Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use "if" "then" with get for posted document when calling e-document subscriptions #25289

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Halilovast
Copy link
Contributor

@Halilovast Halilovast commented Nov 24, 2023

In our BG localization we have a functionality based on Bulgarian legislation that allows to void a posting document. Therefore, during voiding, the header of an posted document is deleted, which is taken with GET without checking in the e-document app. For now we remove e-document for our customers to work with our localization. Please change the code i think it will not cause errors.

Internal work item: AB#492530

@Halilovast Halilovast requested a review from a team as a code owner November 24, 2023 11:47
@Halilovast
Copy link
Contributor Author

Halilovast commented Nov 24, 2023 via email

@Halilovast
Copy link
Contributor Author

Halilovast commented Nov 24, 2023 via email

@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Nov 28, 2023
@JesperSchulz
Copy link
Contributor

Sounds like a fair request and the code makes sense. We'll take a look!

Copy link

@VolodySyn VolodySyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, changes will be added to the app.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Nov 30, 2023

@VolodySyn has processed this PR and it will release with 23.3.

@JesperSchulz JesperSchulz merged commit da1af69 into microsoft:main Nov 30, 2023
4 of 6 checks passed
@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Dec 13, 2023
@JesperSchulz
Copy link
Contributor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 14320.

@Halilovast Halilovast deleted the TeamVision branch December 18, 2023 08:41
aholstrup1 pushed a commit to aholstrup1/ALAppExtensions that referenced this pull request Sep 6, 2024
…subscriptions (microsoft#25289)

In our BG localization we have a functionality based on Bulgarian
legislation that allows to void a posting document. Therefore, during
voiding, the header of an posted document is deleted, which is taken
with GET without checking in the e-document app. For now we remove
e-document for our customers to work with our localization. Please
change the code i think it will not cause errors.<br /><br />Internal
work item: AB#492530

Co-authored-by: Selime Halilova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants