Skip to content

Commit da1af69

Browse files
HalilovastSelime Halilova
and
Selime Halilova
authoredNov 30, 2023
use "if" "then" with get for posted document when calling e-document subscriptions (#25289)
In our BG localization we have a functionality based on Bulgarian legislation that allows to void a posting document. Therefore, during voiding, the header of an posted document is deleted, which is taken with GET without checking in the e-document app. For now we remove e-document for our customers to work with our localization. Please change the code i think it will not cause errors.<br /><br />Internal work item: AB#492530 Co-authored-by: Selime Halilova <[email protected]>
1 parent 81aae0f commit da1af69

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed
 

‎Apps/W1/EDocument/app/src/Processing/EDocumentSubscription.Codeunit.al

+16-16
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,11 @@ codeunit 6103 "E-Document Subscription"
8888
exit;
8989

9090
if SalesInvHdrNo <> '' then begin
91-
SalesInvHeader.Get(SalesInvHdrNo);
92-
RunEDocumentCreation(SalesHeader, SalesInvHeader, SalesInvHdrNo);
91+
if SalesInvHeader.Get(SalesInvHdrNo) then
92+
RunEDocumentCreation(SalesHeader, SalesInvHeader, SalesInvHdrNo);
9393
end else begin
94-
SalesCrMemoHeader.Get(SalesCrMemoHdrNo);
95-
RunEDocumentCreation(SalesHeader, SalesCrMemoHeader, SalesCrMemoHdrNo);
94+
if SalesCrMemoHeader.Get(SalesCrMemoHdrNo) then
95+
RunEDocumentCreation(SalesHeader, SalesCrMemoHeader, SalesCrMemoHdrNo);
9696
end;
9797
end;
9898

@@ -106,11 +106,11 @@ codeunit 6103 "E-Document Subscription"
106106
exit;
107107

108108
if PurchInvHdrNo <> '' then begin
109-
PurchInvHeader.Get(PurchInvHdrNo);
110-
RunEDocumentCreation(PurchaseHeader, PurchInvHeader, PurchInvHdrNo);
109+
if PurchInvHeader.Get(PurchInvHdrNo) then
110+
RunEDocumentCreation(PurchaseHeader, PurchInvHeader, PurchInvHdrNo);
111111
end else begin
112-
PurchCrMemoHdr.Get(PurchCrMemoHdrNo);
113-
RunEDocumentCreation(PurchaseHeader, PurchCrMemoHdr, PurchCrMemoHdrNo);
112+
if PurchCrMemoHdr.Get(PurchCrMemoHdrNo) then
113+
RunEDocumentCreation(PurchaseHeader, PurchCrMemoHdr, PurchCrMemoHdrNo);
114114
end;
115115
end;
116116

@@ -124,11 +124,11 @@ codeunit 6103 "E-Document Subscription"
124124
exit;
125125

126126
if ServInvoiceNo <> '' then begin
127-
ServiceInvoiceHeader.Get(ServInvoiceNo);
128-
RunEDocumentCreation(ServiceHeader, ServiceInvoiceHeader, ServInvoiceNo);
127+
if ServiceInvoiceHeader.Get(ServInvoiceNo) then
128+
RunEDocumentCreation(ServiceHeader, ServiceInvoiceHeader, ServInvoiceNo);
129129
end else begin
130-
ServiceCrMemoHdr.Get(ServCrMemoNo);
131-
RunEDocumentCreation(ServiceHeader, ServiceCrMemoHdr, ServCrMemoNo);
130+
if ServiceCrMemoHdr.Get(ServCrMemoNo) then
131+
RunEDocumentCreation(ServiceHeader, ServiceCrMemoHdr, ServCrMemoNo);
132132
end;
133133
end;
134134

@@ -139,8 +139,8 @@ codeunit 6103 "E-Document Subscription"
139139
begin
140140
if IssuedFinChargeMemoNo = '' then
141141
exit;
142-
IssuedFinChrgMemoHeader.Get(IssuedFinChargeMemoNo);
143-
RunEDocumentCreation(FinChargeMemoHeader, IssuedFinChrgMemoHeader, IssuedFinChargeMemoNo);
142+
if IssuedFinChrgMemoHeader.Get(IssuedFinChargeMemoNo) then
143+
RunEDocumentCreation(FinChargeMemoHeader, IssuedFinChrgMemoHeader, IssuedFinChargeMemoNo);
144144
end;
145145

146146
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Reminder-Issue", 'OnAfterIssueReminder', '', false, false)]
@@ -150,8 +150,8 @@ codeunit 6103 "E-Document Subscription"
150150
begin
151151
if IssuedReminderNo = '' then
152152
exit;
153-
IssuedReminderHeader.Get(IssuedReminderNo);
154-
RunEDocumentCreation(ReminderHeader, IssuedReminderHeader, IssuedReminderNo);
153+
if IssuedReminderHeader.Get(IssuedReminderNo) then
154+
RunEDocumentCreation(ReminderHeader, IssuedReminderHeader, IssuedReminderNo);
155155
end;
156156

157157
[EventSubscriber(ObjectType::Table, Database::"Document Sending Profile", 'OnCheckElectronicSendingEnabled', '', false, false)]

0 commit comments

Comments
 (0)
Please sign in to comment.