CB-390: Shouldn't have to choose a license just to save drafts #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
amCap1712
force-pushed
the
optional_license
branch
from
44ab9f5
to
3a909d4
Compare
This comment has been minimized.
This comment has been minimized.
amCap1712
force-pushed
the
optional_license
branch
from
3a909d4
to
1a7fbbb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
amCap1712
force-pushed
the
optional_license
branch
from
9dbbf0a
to
0948bb3
Compare
This comment has been minimized.
This comment has been minimized.
amCap1712
added a commit
that referenced
this pull request
Sep 26, 2022
This is needed for #417. Unselected radio field results in the value of the field being 'None' not None. This is fixed in newer versions. In newer versions, a few imports have changed and email_validators needs to be added a dependency separately to use EmailField.
Merged
amCap1712
force-pushed
the
optional_license
branch
2 times, most recently
from
278ab14
to
cd613e0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
To allow for draft reviews without a license, we need to make license_id NULLABLE in reviews table. Also add a constraint to ensure that license_id is always NOT NULL for published reviews. Update dumps schema version because of the same reason.
license_id can be nullable for draft reviews so need to use LEFT JOIN.
manual validation validate_license_choice will take care of choice validation. see comments for rationale.
amCap1712
force-pushed
the
optional_license
branch
from
9f68870
to
601b9df
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This doesn't make sense any more in the context of #474, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #327