Try validator other way

critiquebrainz/frontend/forms/review.py

@@ -19,17 +19,6 @@ def __call__(self, form, field):
             raise ValidationError(self.message)
 
 
-def optional_license(message):
-    def _license(form, field):
-        if form.state.data == "draft":
-            return
-        else:
-            # https://wtforms.readthedocs.io/en/2.3.x/_modules/wtforms/validators/#InputRequired
-            if not field.raw_data or not field.raw_data[0]:
-                raise ValidationError(message)
-    return _license
-
-
 # Loading supported languages
 languages = []
 for language_code in supported_languages:
@@ -48,8 +37,7 @@ class ReviewEditForm(FlaskForm):
         choices=[
             ('CC BY-SA 3.0', lazy_gettext('Allow commercial use of this review(<a href="https://creativecommons.org/licenses/by-sa/3.0/" target="_blank">CC BY-SA 3.0 license</a>)')),  # noqa: E501
             ('CC BY-NC-SA 3.0', lazy_gettext('Do not allow commercial use of this review, unless approved by MetaBrainz Foundation (<a href="https://creativecommons.org/licenses/by-nc-sa/3.0/" target="_blank">CC BY-NC-SA 3.0 license</a>)')),  # noqa: E501
-        ],
-        validators=[optional_license(lazy_gettext("You need to choose a license"))])
+        ])
     remember_license = BooleanField(lazy_gettext("Remember this license choice for further preference"))
     language = SelectField(lazy_gettext("You need to accept the license agreement!"), choices=languages)
     rating = IntegerField(lazy_gettext("Rating"), widget=Input(input_type='number'), validators=[validators.Optional()])
@@ -67,6 +55,14 @@ def validate(self):
             return False
         return True
 
+    def validate_license_choice(self, field):
+        if self.state.data == "draft":
+            return
+        else:
+            # https://wtforms.readthedocs.io/en/2.3.x/_modules/wtforms/validators/#InputRequired
+            if not field.raw_data or not field.raw_data[0]:
+                raise ValidationError(lazy_gettext("You need to choose a license"))
+
 
 class ReviewCreateForm(ReviewEditForm):
     agreement = BooleanField(validators=[