feat: Make region, collections, categories, products and cart v2 compatible #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sradevski
commented
May 1, 2024
| "next": "^14.0.0", | ||
| "pg": "^8.11.3", | ||
| "qs": "^6.12.1", |
There was a problem hiding this comment.
This is temporary until we move the SDK to medusa-js
| } | ||
| } | ||
|
|
||
| // TODO: Make response a bit more user friendly (throw errors, return JSON if resp content type is json, etc.) |
There was a problem hiding this comment.
We will need to decide what the behavior of the our SDKs fetch should be when it comes to the responses, either here or when I open the PR to medusa-js
sradevski
changed the title
VariableVic
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of changes, and a lot of things that are still not working yet. For review I would recommend checking the final state, rather than the diff, as it will make it easier to evaluate the end state.
Note that there have been very few UI changes, it's mostly the API calls and the code structure.