fix: Cleanup unused functions and only use convert to locale for money formatting

Author: sradevski

src/lib/util/get-number-of-skeletons.ts

@@ -4,7 +4,7 @@ import { useMemo } from "react"
 
 import Thumbnail from "@modules/products/components/thumbnail"
 import LocalizedClientLink from "@modules/common/components/localized-client-link"
-import { formatAmount } from "@lib/util/prices"
+import { convertToLocale } from "@lib/util/money"
 
 type OrderCardProps = {
   order: Omit<Order, "beforeInsert">
@@ -31,10 +31,9 @@ const OrderCard = ({ order }: OrderCardProps) => {
           {new Date(order.created_at).toDateString()}
         </span>
         <span className="px-2" data-testid="order-amount">
-          {formatAmount({
+          {convertToLocale({
             amount: order.total,
-            region: order.region,
-            includeTaxes: false,
+            currency_code: order.region.currency_code,
           })}
         </span>
         <span className="pl-2">{`${numberOfLines} ${

src/lib/util/prices.ts

@@ -1,9 +1,9 @@
 import { Customer, Order } from "@medusajs/medusa"
 import { Container } from "@medusajs/ui"
-import { formatAmount } from "@lib/util/prices"
 
 import ChevronDown from "@modules/common/icons/chevron-down"
 import LocalizedClientLink from "@modules/common/components/localized-client-link"
+import { convertToLocale } from "@lib/util/money"
 
 type OverviewProps = {
   customer: Omit<Customer, "password_hash"> | null
@@ -15,10 +15,18 @@ const Overview = ({ customer, orders }: OverviewProps) => {
     <div data-testid="overview-page-wrapper">
       <div className="hidden small:block">
         <div className="text-xl-semi flex justify-between items-center mb-4">
-          <span data-testid="welcome-message" data-value={customer?.first_name}>Hello {customer?.first_name}</span>
+          <span data-testid="welcome-message" data-value={customer?.first_name}>
+            Hello {customer?.first_name}
+          </span>
           <span className="text-small-regular text-ui-fg-base">
             Signed in as:{" "}
-            <span className="font-semibold" data-testid="customer-email" data-value={customer?.email}>{customer?.email}</span>
+            <span
+              className="font-semibold"
+              data-testid="customer-email"
+              data-value={customer?.email}
+            >
+              {customer?.email}
+            </span>
           </span>
         </div>
         <div className="flex flex-col py-8 border-t border-gray-200">
@@ -27,7 +35,11 @@ const Overview = ({ customer, orders }: OverviewProps) => {
               <div className="flex flex-col gap-y-4">
                 <h3 className="text-large-semi">Profile</h3>
                 <div className="flex items-end gap-x-2">
-                  <span className="text-3xl-semi leading-none" data-testid="customer-profile-completion" data-value={getProfileCompletion(customer)}>
+                  <span
+                    className="text-3xl-semi leading-none"
+                    data-testid="customer-profile-completion"
+                    data-value={getProfileCompletion(customer)}
+                  >
                     {getProfileCompletion(customer)}%
                   </span>
                   <span className="uppercase text-base-regular text-ui-fg-subtle">
@@ -39,7 +51,11 @@ const Overview = ({ customer, orders }: OverviewProps) => {
               <div className="flex flex-col gap-y-4">
                 <h3 className="text-large-semi">Addresses</h3>
                 <div className="flex items-end gap-x-2">
-                  <span className="text-3xl-semi leading-none" data-testid="addresses-count" data-value={customer?.shipping_addresses?.length || 0}>
+                  <span
+                    className="text-3xl-semi leading-none"
+                    data-testid="addresses-count"
+                    data-value={customer?.shipping_addresses?.length || 0}
+                  >
                     {customer?.shipping_addresses?.length || 0}
                   </span>
                   <span className="uppercase text-base-regular text-ui-fg-subtle">
@@ -53,11 +69,18 @@ const Overview = ({ customer, orders }: OverviewProps) => {
               <div className="flex items-center gap-x-2">
                 <h3 className="text-large-semi">Recent orders</h3>
               </div>
-              <ul className="flex flex-col gap-y-4" data-testid="orders-wrapper">
+              <ul
+                className="flex flex-col gap-y-4"
+                data-testid="orders-wrapper"
+              >
                 {orders && orders.length > 0 ? (
                   orders.slice(0, 5).map((order) => {
                     return (
-                      <li key={order.id} data-testid="order-wrapper" data-value={order.id}>
+                      <li
+                        key={order.id}
+                        data-testid="order-wrapper"
+                        data-value={order.id}
+                      >
                         <LocalizedClientLink
                           href={`/account/orders/details/${order.id}`}
                         >
@@ -73,16 +96,23 @@ const Overview = ({ customer, orders }: OverviewProps) => {
                               <span data-testid="order-created-date">
                                 {new Date(order.created_at).toDateString()}
                               </span>
-                              <span data-testid="order-id" data-value={order.display_id}>#{order.display_id}</span>
+                              <span
+                                data-testid="order-id"
+                                data-value={order.display_id}
+                              >
+                                #{order.display_id}
+                              </span>
                               <span data-testid="order-amount">
-                                {formatAmount({
+                                {convertToLocale({
                                   amount: order.total,
-                                  region: order.region,
-                                  includeTaxes: false,
+                                  currency_code: order.region.currency_code,
                                 })}
                               </span>
                             </div>
-                            <button className="flex items-center justify-between" data-testid="open-order-button">
+                            <button
+                              className="flex items-center justify-between"
+                              data-testid="open-order-button"
+                            >
                               <span className="sr-only">
                                 Go to order #{order.display_id}
                               </span>