Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublicKeyCredential.getClientCapabilities - add #37734
PublicKeyCredential.getClientCapabilities - add #37734
Changes from 10 commits
ae06161
3d925c6
d3f1689
a3d149e
abfdf44
80b111f
54158a0
cee647f
75fa993
567fd95
dead2d6
3d48853
ee6327a
61f5c58
98bd777
a41932d
8f7d35e
1df22d5
cb53ad8
e012ddc
07b0060
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"providing proof of possession of a credential private key provide" doesn't make sense; rephrase? Not sure if there is a missing word or something.
Also, the Chrome folks have a lot of detailed info about passkey. Maybe consider linking to something like https://developers.google.com/identity/passkeys/developer-guides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that sux. What it was supposed to say is that you have to have a physical "thing" that grants access (which holds the credential's private key) and you require a user check to use it.
I've updated in https://github.com/mdn/content/pull/37734/files#r1936651860
It is still a little unclear to me if in reality all discoverable credentials are passkeys, and/or what differentiates a passkey from other discoverable credentials. Do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AIUI, passkeys are basically the main available use case for discoverable credentials right now, implemented by Google. Others may be available in the future, hence me saying "for example passkey" in my PR, to future proof the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps be more specific as to which types of permission policy will block it? Maybe link to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Permissions-Policy/publickey-credentials-create and/or https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Permissions-Policy/publickey-credentials-get?
I'm not sure if both of them block usage of
getClientCapabilities()
, or just one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave for now because it is unspecified. Asking in w3c/webauthn#2251, but I don't think this should block merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that's fine.