-
Notifications
You must be signed in to change notification settings - Fork 22.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublicKeyCredential.getClientCapabilities - add #37734
PublicKeyCredential.getClientCapabilities - add #37734
Conversation
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
Preview URLs
Flaws (3)Note! 4 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (5)URL:
URL:
URL:
(comment last updated: 2025-02-04 01:42:37) |
files/en-us/web/api/authenticatorattestationresponse/gettransports/index.md
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishwillee nice work, sir. Few comments for you, but nothing really serious. I suspect you might change up a few things after reviewing my PR.
files/en-us/web/api/authenticatorattestationresponse/gettransports/index.md
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
This means the the client can use authenticators that rely on Bluetooth, NFC or USB. | ||
- `passkeyPlatformAuthenticator` | ||
- : The client supports usage of a passkey platform authenticator, locally and/or via hybrid transport. | ||
These authenticators enable passwordless multi-factor authentication, providing proof of possession of a credential private key provide and requiring a second authentication mechanism such as a PIN or biometric check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"providing proof of possession of a credential private key provide" doesn't make sense; rephrase? Not sure if there is a missing word or something.
Also, the Chrome folks have a lot of detailed info about passkey. Maybe consider linking to something like https://developers.google.com/identity/passkeys/developer-guides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that sux. What it was supposed to say is that you have to have a physical "thing" that grants access (which holds the credential's private key) and you require a user check to use it.
I've updated in https://github.com/mdn/content/pull/37734/files#r1936651860
It is still a little unclear to me if in reality all discoverable credentials are passkeys, and/or what differentiates a passkey from other discoverable credentials. Do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AIUI, passkeys are basically the main available use case for discoverable credentials right now, implemented by Google. Others may be available in the future, hence me saying "for example passkey" in my PR, to future proof the text.
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Mills <[email protected]>
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/authenticatorattestationresponse/gettransports/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
|
||
- `NotAllowedError` {{domxref("DOMException")}} | ||
- : The Web Authentication API is not allowed in the current browsing context. | ||
For example, it might be blocked by a permission policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that's fine.
files/en-us/web/api/publickeycredential/getclientcapabilities_static/index.md
Outdated
Show resolved
Hide resolved
This means the the client can use authenticators that rely on Bluetooth, NFC or USB. | ||
- `passkeyPlatformAuthenticator` | ||
- : The client supports usage of a passkey platform authenticator, locally and/or via hybrid transport. | ||
These authenticators enable passwordless multi-factor authentication, providing proof of possession of a credential private key provide and requiring a second authentication mechanism such as a PIN or biometric check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AIUI, passkeys are basically the main available use case for discoverable credentials right now, implemented by Google. Others may be available in the future, hence me saying "for example passkey" in my PR, to future proof the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishwillee few more bits for you, but nothing serious. I'm going to approve this, so as not to hold you up.
Co-authored-by: Chris Mills <[email protected]>
@chrisdavidmills . I've accepted all your fixes (how was I so sloppy?) except the one about update/vs delete in the signal all credentials. I'm going to merge because you'll be able to merge yours shortly too, and it would be good to fix the corresponding release note links to this. Thanks very much for all your help and advice. |
FF135 adds support for
PublicKeyCredential_getClientCapabilities()
.This adds API reference.
Perhaps also an update to the guide.
#37557 is a precondition for this
Related docs work can be tracked in #37516