Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document speak-as CSS property. #37706

Merged
merged 35 commits into from
Feb 26, 2025
Merged

Document speak-as CSS property. #37706

merged 35 commits into from
Feb 26, 2025

Conversation

younisdev
Copy link
Contributor

@younisdev younisdev commented Jan 18, 2025

Description

Documented the speak-as CSS property as a standalone property, ensuring accuracy, simplicity, and user-friendliness. In addition, edited the title of @counter-style/speak-as from speak-as to speak-as (@counter-style), and removed unnecessary redirect .

Motivation

I made these changes to ensure that the speak-as property is more documented(only documented in one or two websites), allowing developers a wider options for designing their website.These changes help clarify CSS Speech.

Additional details

None

Related issues and pull requests

Fixes #37548

@younisdev younisdev requested review from a team as code owners January 18, 2025 21:52
@younisdev younisdev requested review from estelle and hamishwillee and removed request for a team January 18, 2025 21:52
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jan 18, 2025
Copy link
Contributor

github-actions bot commented Jan 18, 2025

Preview URLs

Flaws (11)

URL: /en-US/docs/Web/CSS/speak-as
Title: speak-as
Flaw count: 11

  • broken_links:
    • /en-US/docs/Glossary/screen_reader is ill cased
    • /en-US/docs/Web/CSS/Value_definition_syntax#single_bar is a redirect
    • /en-US/docs/Web/CSS/Value_definition_syntax#double_bar is a redirect
    • /en-US/docs/Web/CSS/Value_definition_syntax#double_bar is a redirect
    • /en-US/docs/Web/CSS/Value_definition_syntax#brackets is a redirect
    • and 2 more flaws omitted
  • macros:
    • Macro produces link /en-US/docs/Glossary/screen_reader which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/inheritance which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/computed_value which is a redirect

(comment last updated: 2025-02-26 04:07:42)

younisdev and others added 13 commits January 18, 2025 23:57
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hamishwillee hamishwillee removed their request for review January 28, 2025 06:26
@hamishwillee
Copy link
Collaborator

@estelle I have removed myself as reviewer as this is a CSS property. Also after my long holiday I am well behind on review tasks.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Feb 13, 2025
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

@skyclouds2001 skyclouds2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 52 to 72
```CSS
.normal {
speak-as: normal;
}

.spell-out {
speak-as: spell-out;
}

.literal-punctuation {
speak-as: literal-punctuation;
}

.no-punctuation {
speak-as: no-punctuation;
}

.digits {
speak-as: digits;
}
```
Copy link
Contributor

@skyclouds2001 skyclouds2001 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to the comment under syntax section

#37706 (comment)

younisdev and others added 4 commits February 19, 2025 15:40
Co-authored-by: skyclouds2001 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
younisdev and others added 3 commits February 19, 2025 16:27
Co-authored-by: skyclouds2001 <[email protected]>
Co-authored-by: skyclouds2001 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@skyclouds2001
Copy link
Contributor

image

CI is saying something about the end-of-line

@younisdev
Copy link
Contributor Author

younisdev commented Feb 21, 2025

image

CI is saying something about the end-of-line

I'll take a look

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Feb 25, 2025
@Josh-Cena
Copy link
Member

Make sure that you configure your editor to use LF instead of CRLF as line endings

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this content. I made some suggestions for you to consider.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit fa09009 into mdn:main Feb 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page for css speak-as property and remove its redirect to @counter-style/speak-as
5 participants