-
Notifications
You must be signed in to change notification settings - Fork 22.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document speak-as
CSS property.
#37706
Conversation
Preview URLs Flaws (11)URL:
(comment last updated: 2025-02-26 04:07:42) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle I have removed myself as reviewer as this is a CSS property. Also after my long holiday I am well behind on review tasks. |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```CSS | ||
.normal { | ||
speak-as: normal; | ||
} | ||
|
||
.spell-out { | ||
speak-as: spell-out; | ||
} | ||
|
||
.literal-punctuation { | ||
speak-as: literal-punctuation; | ||
} | ||
|
||
.no-punctuation { | ||
speak-as: no-punctuation; | ||
} | ||
|
||
.digits { | ||
speak-as: digits; | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to the comment under syntax section
Co-authored-by: skyclouds2001 <[email protected]>
Co-authored-by: skyclouds2001 <[email protected]>
Co-authored-by: skyclouds2001 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: skyclouds2001 <[email protected]>
Co-authored-by: skyclouds2001 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: skyclouds2001 <[email protected]>
Make sure that you configure your editor to use LF instead of CRLF as line endings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this content. I made some suggestions for you to consider.
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Description
Documented the
speak-as
CSS property
as a standalone property, ensuring accuracy, simplicity, and user-friendliness. In addition, edited the title of@counter-style/speak-as
from speak-as tospeak-as (@counter-style)
, and removed unnecessary redirect .Motivation
I made these changes to ensure that the
speak-as
property is more documented(only documented in one or two websites), allowing developers a wider options for designing their website.These changes help clarifyCSS Speech
.Additional details
None
Related issues and pull requests
Fixes #37548